Time Nick Message 00:22 Hijiri if a release takes longer than a year does that mean it's ok to break all compatibility? 00:30 est31 Hijiri, 00:30 est31 err 00:30 est31 no its not okay 00:31 est31 you still have to be compatible with the last release 00:31 est31 at least with older clients 00:31 est31 most servers update faster 00:32 est31 (than the clients) 01:03 paramat hi hmmmm please could you review #4520 sometime? 01:03 ShadowBot https://github.com/minetest/minetest/issues/4520 -- Decorations: Allow schematic decorations to use 'spawn by' by paramat 07:03 Hijiri I don't know what it needs for approval since it's not code, but could someone look at #4509 ? 07:03 ShadowBot https://github.com/minetest/minetest/issues/4509 -- Fix inconsistencies between different descriptions of the entity callbacks in docs by raymoo 07:06 hmmmm hijiri: why is it dtime_s as opposed to dtime? 07:11 Hijiri the existing one was called dtime_s, should I just rename both to dtime? 07:11 Hijiri I assume s means static or something 07:11 Hijiri or seconds? 07:12 hmmmm oh, i thought you added that 07:12 Hijiri I added it to the one that was missing the argument 07:12 hmmmm hm 07:12 hmmmm https://github.com/minetest/minetest/commit/9cadaf824b3a59c85ad03f9c7185f43724b8e7ff 07:12 hmmmm "add dtime_s to entity activation" - yup, we can tell.. 07:12 hmmmm but why 07:13 hmmmm as far as i can tell, literally the only place where this dtime_s is used is in builtin/item_entity.lua for some kind of "data age" 07:14 Hijiri it's probably also used in mobs to have them go away after some time 07:14 Hijiri in general if an entity has some process that occurs over time you can use it for catchup 07:14 hmmmm ah right 07:14 Hijiri I thought you were making a rhetorical question about nondescriptive commit messages so I didn't say anything earlier 07:15 hmmmm i was 07:15 Hijiri sorry, I meant that I assumed that you knew some uses and were just using it to highlight bad commit message 07:17 hmmmm it's pretty much a mystery 07:17 hmmmm does this make sense though for the claimed usage? 07:17 Hijiri the parameter name? 07:18 hmmmm i mean the reason you gave for having that parameter to begin with 07:18 hmmmm so in the environment tick it has a newly loaded static object that hasn't been activated yet 07:19 hmmmm it activates the static object to an active object and uses the dtime passed to the environment step 07:19 hmmmm the list of static-objects-that-need-to-get-activated gets cleared 07:19 Hijiri oh, it doesn't actually get how long the entity was inactive? 07:19 hmmmm maybe i'm misunderstanding something here, but is this parameter completely useless? 07:20 hmmmm maybe. 07:20 hmmmm but anyway about your PR, approved 07:20 hmmmm we'll figure out what to do with dtime_s later 07:20 Hijiri alright, thanks 07:23 hmmmm actually no i'm sorry 07:23 hmmmm it doesn't get called in the environment step, that's just me being silly 07:23 hmmmm it uses the block timestamp for dtime 07:23 hmmmm okay you're right, it's for entity catch-up 07:23 hmmmm maybe i should've made you mention that in the documentation before merging 07:24 Hijiri I could make a quick edit right now 07:25 hmmmm you're right, the 5 minute rule 07:25 hmmmm add a note explaining what dtime_s is in that function 07:25 Hijiri in the original commit? 07:25 hmmmm yeah 07:25 hmmmm then amend 07:25 hmmmm force push 07:25 hmmmm i'll force update master 07:25 Hijiri ok 07:27 Hijiri it's force-updated 07:29 hmmmm "which can be used for updating the entity state" 07:29 hmmmm I can't use dtime_s on a hamburger 07:30 Hijiri alright :P 07:30 hmmmm we informally call it catch-up but that sounds out of place in documentation 07:30 Hijiri it's repushed 07:31 hmmmm you didn't 07:31 hmmmm your github branch is still at cd0a602 07:31 Hijiri really? 07:31 Hijiri ok, let me try again 07:32 Zeno` too late. it's now 5 minutes and 2 seconds 07:32 Zeno` heh :D j/k 07:33 hmmmm pshh... 07:33 Hijiri it should be force pushed now 07:33 hmmmm yea it is 07:33 hmmmm ok looks good 07:36 hmmmm :) 07:36 * Zeno` sets off the alarm 07:36 Zeno` whoooooop whoooop whooooop 07:37 Zeno` it was pushed 32.1238913 seconds too late! 07:37 Zeno` whoooooop whoooop whooooop 07:37 hmmmm oh stfu 07:37 Zeno` lol :D 07:37 Zeno` tbh I don't think it would have mattered much if it was up to 10 minutes heh 07:38 Zeno` isn't it a 10 minute rule anyway? I can never remember the exact time 07:39 hmmmm i thought it was 5 minute rule 07:39 hmmmm like you know how you have the 5 second rule when some kind of food falls on the floor 07:39 hmmmm well 5 seconds is a little too short for git 07:42 Zeno` :) 07:42 Zeno` 5 minutes... 10 minutes... it's all relative 07:42 hmmmm relative to the speed of light in a vaccum 07:43 Zeno` well, relative to something so abstract it's almost meaningless 07:44 hmmmm according to the theory of relativity 07:44 Zeno` we can't know time 07:44 Zeno` it's impossible 07:44 hmmmm ok robert nozick 07:45 Zeno` by definition it's impossible (and you gave the reason why!) 07:47 Zeno` because I'm in Australia am I moving away from you relative to the centre of the earth? 07:47 * Zeno` ponders 07:47 hmmmm the australians have been invading my workplace recently 07:47 hmmmm we had 1 now we have 3 07:47 Zeno` that's 'cause we're cool 07:47 hmmmm australian tech sector is kinda meh right now 07:48 Zeno` that's true 07:48 Zeno` because we're too busy helping you 07:48 hmmmm with what 07:48 Zeno` IT 07:48 hmmmm being upside-down? 07:48 Zeno` lol :D 07:48 Zeno` yes! 07:49 Zeno` anyway it's YOU who is upside-down 07:49 hmmmm what is the quaternion to rotate something 180 about the Z axis? 07:49 Zeno` I went to the moon and looked back upon Earth and Australia was on the TOP 07:49 hmmmm sure thing pal 07:50 Zeno` I'm serious... I was on the south pole of the moon and the upness of Earth was clearly with Antarctica, Australia etc on top of the globe 07:50 Zeno` hmm 07:50 Zeno` maybe it's relative 07:51 hmmmm all this talk about relativity is making me hungry 07:51 Zeno` I'm relatively hungry also 07:52 hmmmm i hope i can get to sleep tonight 14:34 tenplus1 hi folks, may I ask any devs handy to help me with this pull please: https://github.com/minetest/minetest_game/pull/1286 15:21 tenplus1 'tis quiet 15:22 nrzkt tenplus1: zzZZ 15:23 tenplus1 hi nrz 15:24 tenplus1 busy ? 15:25 tenplus1 hi hmmmm 15:29 tenplus1 Q. will a git pull always fail if a variable isn't used after defining ??? 15:38 tenplus1 https://github.com/minetest/minetest_game/pull/1286 17:17 paramat closed game#516 < sofar rubenwardy 17:17 ShadowBot https://github.com/minetest/minetest_game/issues/516 -- Translation by Adimgar 18:05 Krock paramat, putting the bracket into the other direction ('>') would write it directly on their desk :P 18:08 paramat oops 18:28 Hijiri can someone label and/or review #4421 18:28 ShadowBot https://github.com/minetest/minetest/issues/4421 -- Expose getPointedThing() as RaycastState by juhdanad 18:32 Krock [Performance] [Enchantement] [@ Script API] done 18:32 Krock perhaps not performance, as there is no such feature yet 18:32 Hijiri performance over an implementation in mod code I guess 18:33 Krock overusing labels isn't a good idea either ;) 18:35 Hijiri what is overuse 18:35 Hijiri I think labelling every PR is normal use 18:36 Hijiri or do you mean that performance would be overused? 18:36 Hijiri I didn't say this but I wasn't serious about my reasoning for adding a performance label 20:04 paramat #4520 updated and retested 20:04 ShadowBot https://github.com/minetest/minetest/issues/4520 -- Decorations: Allow schematic decorations to use 'spawn by' by paramat 23:00 sofar does anyone ever use the squash-and-merge option for trivial merges? 23:04 * sofar merges #4512 23:04 ShadowBot https://github.com/minetest/minetest/issues/4512 -- Plantlike meshoptions: fix degrotate. by sofar 23:05 sofar paramat: I refreshed the slabs combining PR... needs a round of quick touch testing again I'd say 23:06 paramat ok cool 23:06 sofar there's one small catch but I think it's acceptable 23:07 Fixer sofar: i will check it tommorrow too 23:07 sofar Fixer: awesome, that'd help 23:07 Fixer sofar: it also works with stairs, right? 23:07 sofar only slabs 23:09 sofar we can do it with stairs too, though (aim to the side of a stair with an identical stair to place in same orientation) 23:09 sofar it's a slight variation 23:09 Fixer so if i have rotated stair and i place another one near it - it will have different rotation? 23:10 sofar stair rotation is purely based on player look direction, afaik 23:11 Fixer screwdriving is so boring, i will welcome simplification for stairs too 23:11 sofar we can do that 23:11 sofar separate PR, though 23:11 sofar since it's a bit different 23:12 Fixer i imagine it can have some downsides for stairs, like when you want to make a table, but you will need to use screwdriver anyway in both cases 23:13 sofar no, it's just a different problem set 23:13 Fixer ok 23:18 Fixer too bad slabs/stairs don't support smooth lighting yet, I got my indoor places ruined by that light rendering, especially on bright blocks, usual examples are stairs to second floor or roof/floor made with slabs, roof itself from stairs