Time Nick Message 03:04 paramat updated and tested #4339 ready for review 03:04 ShadowBot https://github.com/minetest/minetest/issues/4339 -- CavesNoiseIntersection: Place riverbed node under river water by paramat 03:08 paramat hmmmm #4336 is also ready, whenever you have time 03:08 ShadowBot https://github.com/minetest/minetest/issues/4336 -- Shaders: Disable by default by paramat 03:26 hmmmm sure 03:26 hmmmm i'm neutral 04:08 paramat thanks 22:58 Megaf folks, I'd like to make the fog appears closer to the camera 22:58 Megaf I think I have to change line 942 of game.cpp 22:58 Megaf but I don't quite understand that number 22:59 Megaf https://github.com/minetest/minetest/blob/7a532056e29d00006382caad9ccde66e54ca8aa5/src/game.cpp#L942 22:59 Megaf or maybe https://github.com/minetest/minetest/blob/2060fd9cbe587d7e8ffe0cecdd67925f13a56c05/src/localplayer.cpp#L177 ? 23:02 Megaf well, localplayer sure it isnt 23:06 * Megaf waits 23:24 paramat hm 23:25 paramat there's a number somewhere that controls it 23:25 paramat we were playing with it during one of RBA's PRs 23:27 paramat do you mean you dislike how the world cuts off before it completely disappears into fog? 23:27 paramat because there's a good reason for that 23:31 paramat .. it looks weird 23:32 Megaf the way it is I can see the cuts before the fog 23:33 Megaf so the fog is not doing its function 23:33 Megaf paramat: ^ 23:33 paramat yeah thats exactly what i mean 23:33 paramat when you 'fix' this you'll see why it isn't done, stuff looks really weird 23:34 paramat i can't remember where the code is though 23:35 paramat ah 23:37 paramat https://github.com/minetest/minetest/blob/master/src/game.cpp#L4067 23:37 paramat '0.9' 23:38 paramat i think that number is it 23:40 paramat https://imgur.com/a/o2fJC this is what happens 23:41 paramat it was discussed here #3720 23:41 ShadowBot https://github.com/minetest/minetest/issues/3720 -- Use real camera clipping and single view_range setting by RealBadAngel 23:44 Fixer remember those times 23:44 Fixer good grief he made it at 0.9 23:44 paramat RBA suggested 0.85, you might like even lower 23:44 paramat 0.9 was the original value 23:44 Fixer rbas suggestion was too foggy 23:44 Fixer 0.7 iirc 23:45 paramat ah 23:47 paramat maybe fog colour could be tuned to be closer to the background 23:48 paramat (that's a suggestion for megaf not for a PR) 23:49 Megaf what's wrong in the screenshot paramat? 23:50 paramat distant stuff turns white 23:50 paramat but it's a personal preference 23:51 Megaf that's how fog was coded 23:52 paramat looks like fog gets its colour from 'BgColor' https://github.com/minetest/minetest/blob/master/src/game.cpp#L4143 23:53 Megaf so, the smaller the number the closer the fog is 23:53 Megaf right? 23:53 paramat yes 23:55 Megaf ok, I changed to 0.4, testing now 23:56 Megaf at night is fantastic 23:58 Megaf oops, I ran the wrong binary, testing again 23:59 paramat it's a performance thing too, with fog closer you see less useful stuff for the same view range