Minetest logo

IRC log for #minetest-dev, 2016-07-10

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:09 Erebus_ joined #minetest-dev
00:10 Erebus_ joined #minetest-dev
00:13 damiel_ joined #minetest-dev
01:01 twoelk|2 joined #minetest-dev
01:21 Erebus_ joined #minetest-dev
01:37 Void7 joined #minetest-dev
01:41 Erebus_ joined #minetest-dev
01:43 rubenwardy joined #minetest-dev
02:27 Void7 joined #minetest-dev
02:44 STHGOM joined #minetest-dev
02:55 Tmanyo joined #minetest-dev
03:10 DI3HARD139 joined #minetest-dev
03:48 Icedream joined #minetest-dev
04:15 SloanOnLinux joined #minetest-dev
05:08 est31 joined #minetest-dev
05:23 Hunterz joined #minetest-dev
05:50 Volkj joined #minetest-dev
05:58 nrzkt joined #minetest-dev
06:24 Volkj left #minetest-dev
07:20 cd2 joined #minetest-dev
08:53 xunto joined #minetest-dev
08:53 cat5e joined #minetest-dev
08:54 VanessaE joined #minetest-dev
08:54 Warr1024 joined #minetest-dev
08:54 johnnyjoy joined #minetest-dev
08:54 Tesseract joined #minetest-dev
08:54 Kray joined #minetest-dev
08:54 nore joined #minetest-dev
08:54 damiel joined #minetest-dev
08:57 lisac joined #minetest-dev
09:09 T4im joined #minetest-dev
09:19 Krock joined #minetest-dev
09:36 paramat joined #minetest-dev
09:46 paramat nore please could you consider game#1187 ?
09:46 ShadowBot https://github.com/minetest​/minetest_game/issues/1187 -- Bones: New textures by paramat
09:47 nore paramat: definitely much better than the current texture
09:50 paramat nore if you can we need extra input on these: game#673 game#1002 game#1030 some are possible close
09:50 ShadowBot https://github.com/minetes​t/minetest_game/issues/673 -- Make buckets control scheme consistent. by Jordach
09:50 ShadowBot https://github.com/minetest​/minetest_game/issues/1002 -- Add sandstone wall to Walls mod by vlapsley
09:50 ShadowBot https://github.com/minetest​/minetest_game/issues/1030 -- New cobblestone/mossycobblestone and furnace textures by tobyplowy
09:51 nore paramat: game#673 is +1 from me
09:51 ShadowBot https://github.com/minetes​t/minetest_game/issues/673 -- Make buckets control scheme consistent. by Jordach
09:53 nore hm, I don't know for the others
09:57 paramat sofar is not happy at all about 1002 so i think best close, just need another -1
09:59 paramat the cobblestone textures are a step down in quality
10:00 paramat another screenshot game#1026
10:00 ShadowBot https://github.com/minetest​/minetest_game/issues/1026 -- new cobblestone/mossycobblestone texture (textures inside)
10:04 T4im wouldn't #673 even make game#1032 obsolete then?
10:04 ShadowBot https://github.com/minetest​/minetest_game/issues/1032 -- Allow buckets to run a non-liquid node's on_punch by C1ffisme
10:04 ShadowBot https://github.com/minetest/minetest/issues/673 -- improve getFree*ActiveObjectId to reduce common case cpu usage by sapier
10:04 T4im oops, wrong ref
10:05 T4im s/make obsolete/solve more elegant/ x)
10:05 paramat perhaps
10:17 everamzah joined #minetest-dev
10:18 paramat i prefer 1032 to 673
10:21 T4im oh, I missread something there, yea you're right
10:22 T4im that essentially doesn't use "digging" as filling the bucket anymore
10:22 T4im :/
10:22 est31 https://github.com/est31/share_login
10:22 T4im wow :D
10:23 est31 not 100% finished yet, but ready for being tested
10:23 est31 I want to add auth.txt parsing for example
10:24 est31 that way you can import your older auth.txt and look for conflicts (same username taken on different servers)
10:24 T4im which is nearly guaranteed
10:26 paramat nore let me know if or when you +1 new bones
10:26 nore paramat: I do
10:37 davisonio joined #minetest-dev
10:44 paramat great
10:45 paramat so i feel let's move ahead with 1032, i'll try to review
11:00 davisonio joined #minetest-dev
11:01 T4im I hope you didn't mind me to go ahead and do, too :)
11:01 paramat of course not, more review the better
11:05 Fixer joined #minetest-dev
11:06 * T4im should write a test that alarms about code running get_node twice or more in the same function with the same position
11:11 celeron55 running get_node consecutively for the same position or positions that are within the same mapblock are pretty fast though
11:11 celeron55 you can go wrong by doing manual "optimization" in Lua
11:15 celeron55 ...hmm, looking at this series of functions, i wonder how much faster a get_node that wouldn't use a table for coordinates would be
11:17 celeron55 i wouldn't be surprised if it would be twice as fast for positions inside the same block
11:21 T4im does it make a difference whether you unpack the position in lua or c? post of the time get_node is being used with a callback passed position table, so that would just move the table lookups, wouldn't it?
11:21 T4im most*
11:22 SloanOnLinux joined #minetest-dev
11:23 Zeno` joined #minetest-dev
11:23 T4im and I've seen get_node in loops before, which can be quite expensive if you ignore the stack and just go global lookup + table lookup + get_node call over and over again
11:24 * T4im is always surprised how noticeable global lookups in loops can be
11:24 Zeno` T4im, I assume your profiler changes have been well tested
11:24 * T4im actually has a few changes unpushed, if that would be ok
11:25 celeron55 global lookups in lua are the worst, that's for sure
11:26 Zeno` yeah, ok. I think it should be pushed as soon as it's "ready" though. Any bugs won't affect user experience so it's better, IMO, that it's merged and can get wider testing/use. I don't know if others agree with that philosophy, but the code looks good
11:30 celeron55 T4im: if there is the same amount of position table lookups in any case, then it probably wouldn't make a difference; but i would guess that one could easily get away with fewer of them if there was a table-less version of the final API; it would make code ugly though
11:31 celeron55 i think i'm now guessing overally it wouldn't make sense
11:44 neoascetic joined #minetest-dev
11:45 neoascetic hi everyone
11:45 neoascetic minetest on google play is outdated
11:47 neoascetic why there is no **official** minetest company/developer on google play?
11:52 T4im alright Zeno`, should be ok now, still gonna do some additional testing, but not gonna add huge changes for this pr anymore
11:54 T4im that is, if that helps :P
11:58 Zeno` well minor changes can be other PRs
11:58 Zeno` otherwise it might never be "finished" heh
11:59 Zeno` I guess we should decide what commits, if any, should be squashed as well
12:00 T4im of course, I just appended to give you guys a chance, when I kept pushing during any reviewing :D
12:00 Zeno` based on what I'm look at maybe none need to be squashed
12:02 Zeno` for bisecting it's better that they all stay... none a simple one line changes anyway
12:02 Zeno` s/a/are
12:03 Zeno` paramat, are you here?
12:07 paramat yeah
12:08 Zeno` have you looked at #4245 at all?
12:08 ShadowBot https://github.com/minetest/minetest/issues/4245 -- Builtin/profiler: Rewrite profiler to fix various issues and improve capabilities by t4im
12:09 paramat well, i'm trying to avoid it ;]
12:09 T4im heh
12:09 T4im I'm here for questions
12:09 paramat est31 likes it so i'm sure you'll get enough approval
12:10 Lunatrius joined #minetest-dev
12:10 paramat i'm fairly useless with most engine stuff
12:11 paramat ah it's lua
12:11 paramat still best i leave this to others
12:12 Zeno` paramat, that's cool. est31 and I have agreed (just waiting for est31 to also look at the latest commits though)
12:12 Zeno` I guess the main question is if anything needs squashing (I don't think it does). T4im did you squash along the way?
12:12 T4im every now and then
12:13 Zeno` yeah cool
12:13 paramat ok. i'm so active i'm quite comfortable with refusing to look at stuff ;]
12:13 Zeno` I'll wait until hmmmm and/or est31 are online
12:13 Zeno` paramat, :P
12:21 davisonio joined #minetest-dev
12:24 paramat ~tell neoascetic nrzkt (nerzhul) maintains google play
12:24 ShadowBot paramat: O.K.
12:26 paramat i'll work on fixing #4300 today
12:26 ShadowBot https://github.com/minetest/minetest/issues/4300 -- GCC 6 warning in treegen
13:00 T4im btw, I tried to replace the dots with those new background colors (using different shades every line helps a lot better with reading and probably looks better), but they don't seem to work in the console; are they supposed to? or is that like a formspec-only feature?
13:02 damiel_ joined #minetest-dev
13:30 Krock joined #minetest-dev
13:54 Grandolf joined #minetest-dev
13:57 rdococ where is the code that determines when liquids reappear or disappear? somewhere in the core, right...?
13:59 Zeno` probably here: https://github.com/minetest/minet​est/blob/master/src/map.cpp#L1620
14:01 paramat yeah transformLiquids
14:06 rdococ I can barely understand it... can you point me to where it detects when the source block disappears?
14:06 rdococ ugh... nevermind
14:08 Void7 joined #minetest-dev
14:16 Zeno` it's holy code and therefore not meant to be understood
14:27 rubenwardy joined #minetest-dev
14:27 Player_2 joined #minetest-dev
14:40 paramat joined #minetest-dev
14:41 paramat source disappears in what circumstance? picked up in bucket?
14:49 davisonio joined #minetest-dev
14:50 Krock all hail the holy code, Zeno`!
14:52 hola joined #minetest-dev
15:19 paramat ~tell est31 #4308
15:19 ShadowBot paramat: O.K.
15:19 paramat #4308
15:19 ShadowBot https://github.com/minetest/minetest/issues/4308 -- Treegen: Improve use of signed vs. unsigned integers by paramat
15:35 Zeno` does 'dev' really need to be unsigned?
15:36 Zeno` line 795 then has an implicit cast
15:37 Zeno` and also line 796
15:39 Zeno` that's just hiding the warning anyway
15:40 Zeno` the problem is that 'dev' may be > 19
15:42 Zeno` if ((s16)pr.range(0, 20) <= 19 - dev) {          might be better?
15:42 Zeno` if ((u16)pr.range(0, 20) <= 19 - dev) {          might be better?
15:42 KaadmY joined #minetest-dev
15:44 cd2 joined #minetest-dev
15:45 Zeno` crazy warning
15:45 Zeno` I wonder if just adding an assert() would silence it
15:45 davisonio joined #minetest-dev
15:50 Zeno` paramat, are you using gcc5?
15:51 Zeno` err 6
15:53 davisonio joined #minetest-dev
16:01 Void7 joined #minetest-dev
16:03 paramat erm i'm not sure
16:04 paramat i compile with cmake on linux as per the readme instructions
16:05 Zeno` gcc --version
16:06 paramat 4.8.4
16:06 Zeno` wow
16:06 Zeno` what distro?
16:06 paramat heh ubuntu 14.04 LTS
16:07 Zeno` ok yeah
16:07 paramat need to update
16:07 Zeno` nah, it's cool you're on that
16:07 Zeno` we need people on different versions
16:07 Zeno` I'm using 5.3.1
16:08 paramat concerning signed/unsigned, i just used unsigned wherever possible
16:08 paramat thought that might help
16:09 paramat as signed overflow seems to be more problematic
16:09 Zeno` yeah I guess... I'd just like to experiment with what's triggering it. I guess I'll need a VM or something with gcc 6
16:09 Zeno` i don't really feel like upgrading my distro this week (or month) hehe
16:12 paramat anyway i'll wait to see if this removes the warning as it is
16:12 Zeno` k
16:13 Warr1024 joined #minetest-dev
16:15 paramat afaik dev doesn't need to be unsigned, it just doesn't need to be signed. hmmmm advised to keep things u if they don't need to be s
16:16 Lunatrius joined #minetest-dev
16:19 Warr1024 joined #minetest-dev
16:22 Warr1024 joined #minetest-dev
16:27 whitephoenix joined #minetest-dev
16:27 Warr1024 joined #minetest-dev
16:31 Void7 joined #minetest-dev
16:41 whitephoenix joined #minetest-dev
16:41 Lunatrius joined #minetest-dev
16:44 hmmmm joined #minetest-dev
16:52 paramat \O/
16:52 whitephoenix joined #minetest-dev
16:57 Krock \o/
16:58 paramat i'm happy when hmmmmm joins
17:03 Krock I see :3
17:06 ElectronLibre joined #minetest-dev
17:16 paramat if i want to merge someone's PR but want to also change it, can i: clone, wget their patch, git am patch, make my changes and commit it, squash the 2 commits into 1, then push?
17:17 rubenwardy make changes, git add .
17:17 rubenwardy then git commit --amend
17:17 rubenwardy changes; git add .; git commit --amend   is the same as    changes; git a .; git commit -m "s"; git rebase -i HEAD~2; squash
17:22 Zeno` don't forget to change the author from you back to the original author if that's your intent!
17:23 T4im shouldn't amend preserve the author?
17:23 Zeno` i.e. after squashing git commit --amend --author="Name <emailaddress>"
17:23 Zeno` T4im, nah it doesn't
17:24 Zeno` (unless you include the switches when you amend in the first place)
17:24 T4im "The new commit has the same parents and author as the current one (the --reset-author option can countermand this)."
17:24 Zeno` T4im, well I've found that not to be true :(
17:24 rubenwardy yeah, I'm pretty sure the author is the same ...
17:24 T4im authorin date is usually also preserved
17:24 T4im authoring*
17:24 rubenwardy although it often comes with "commited with: amending author"
17:25 Krock you don't need to add the email, it sould be added automatically
17:25 Zeno` so I guess check it before committing is the best plan :)
17:25 T4im yea, that seems right
17:25 Zeno` err before pushing
17:25 T4im Zeno`: does your log format differ between commiter, author, commit date and author date?
17:26 T4im :D
17:26 Zeno` the dates stay the same
17:26 T4im I would expect the commit date to change though
17:27 Zeno` it would not have been committed before the merge/squash/amend
17:27 Zeno` I dunno... I'm just saying what happens to me :)
17:28 Zeno` If I do what was suggested the author changes to me *shrug*
17:29 Zeno` maybe Fedora has weird git settings
17:30 T4im either way, you're right, that checking before pushing is a good idea :D
17:31 T4im git show --format=raw
17:32 T4im or --format=fuller
17:33 Zeno` well, yeah... especially check history after squashing or something like that
17:33 Zeno` I think most people would (and should) do that
17:33 Zeno` before pushing
17:33 damiel_ joined #minetest-dev
17:34 paramat thanks
17:35 * Zeno` watches Rescue from Gilligan's Island
17:36 Zeno` hmm, need popcorn
17:37 Krock Zeno`, here for you: https://www.youtube.com/watch?v=YK3ZP6frAMc
17:38 Zeno` oh... yummy! thanks
17:40 Krock np
17:41 Zeno` oh noes!
17:41 Zeno` they blew up the spy satellite!
17:44 lisac joined #minetest-dev
17:48 Zeno` they're going to lash all their huts together to survive the tsunami!
17:48 Zeno` genius!
17:49 Zeno` lol, a hutsboat
18:01 Taoki[mobile] joined #minetest-dev
18:07 KaadmY joined #minetest-dev
18:23 Gael-de-Sailly joined #minetest-dev
18:29 davisonio joined #minetest-dev
18:34 Zeno` mary anne is pretty cute
18:35 Krock what are you even talking about?
18:35 Zeno` Gilligan's Island
18:36 Krock I don't see how this is related to #minetest-dev
18:36 Zeno` is that my problem? :D
18:36 Krock I think so
18:36 Zeno` hmm ok :`(
18:37 Zeno` but she is!
18:37 Krock just saying because "Chit-chat goes to #minetest"
18:40 Zeno` yeah i forgot. No fun allowed
18:40 T4im hm, is there any reason against making flowers and grass floodable?
18:40 T4im :o
18:40 T4im common Zeno`, flooding stuff is fun
18:40 Lunatrius joined #minetest-dev
18:40 Void7 joined #minetest-dev
18:41 Krock flooding like lava.. so you'd have slowing grass?
18:41 Krock *flowing
18:44 T4im no, having water that spills over grassland flow into the grass (and replace it)
18:44 T4im like buildable_to, but done by water
18:46 Krock yes, that's a good idea
18:46 T4im I'm certainly gonna PR to make fire floodable, no need to wait for that abm to flood the flame
18:47 Krock but don't forget on_flood for items like torch
18:48 T4im on_flood?
18:48 T4im floodable already exists, but not as callback: https://github.com/minetest/minetes​t/blob/master/doc/lua_api.txt#L3576
18:49 Krock oh!
18:49 Krock alright, then it's just a MTG PR?
18:49 T4im yea
18:49 T4im boring, eh?
18:49 Krock a bit.. yes
18:50 Krock but also little changes can improve the gameplay
18:50 T4im heh, Zeno` kinda wante the profiler in, so I'm currently not working on that, to not delay the reviews :P
18:50 T4im which I'm thankful for btw
18:50 T4im for both Zeno` pushing that forward and the reviews
18:51 Zeno` oh yeah
18:51 Zeno` hmmmm, can you look at it?
18:51 * T4im already has the next set of changes lined up, and is kinda excited to try his luck with mod-memory profiling
18:52 Zeno` I think it should just be pushed because any bugs won't affect end users anyway
18:52 Zeno` and the code is good
18:52 T4im thanks :D
18:54 T4im well, you should be able to run the profiler on a server as well; the instrumentation overhead is pretty low with ~2µs, and mostly on event based functions, nothing that should run more often than globalstep
18:55 Hijiri was floodable added after the 0.4.14 release?
18:55 Hijiri or did it exist by the
18:55 Hijiri by then
18:56 T4im 30 december
18:56 T4im https://github.com/minetest/minetest/commi​t/0bbbc6e13dc8180cf1d98f9866bc72a510162eb3
18:58 Hijiri ok, thanks
18:58 hmmmm look at what?
18:59 T4im #4245
18:59 ShadowBot https://github.com/minetest/minetest/issues/4245 -- Builtin/profiler: Replace builtin profiler by t4im
19:00 hmmmm oh.. lua stuff
19:00 hmmmm yeah in a minute.
19:12 T4im thanks! :)
19:14 paramat joined #minetest-dev
19:16 paramat floodable fire is ok
19:16 T4im but you don't like the idea of floodable grass? :D
19:16 paramat but not flowers and grass
19:17 T4im alright
19:17 Zeno` huh?
19:17 paramat there's an issue about this somewhere where i argue
19:18 T4im yea, that's why I was asking; seemed like there is some reason for it (just fire seemed not to be a gameplay issue :D)
19:18 T4im wondered why
19:18 T4im :)
19:18 T4im protection maybe?
19:18 paramat no, erm, searching
19:21 paramat game#829 my reasons are there :]
19:21 ShadowBot https://github.com/minetes​t/minetest_game/issues/829 -- Make grass, flowers, fire, crops and torches floodable. by red-001
19:21 T4im ah thanks
19:22 paramat we may soon have 'drop on flood' which might be ok for torches
19:22 T4im is on_destruct called with floodable?
19:23 T4im (for the fire hissing sound)
19:23 paramat flooding occurs in liquid code so i doubt it, not sure
19:24 paramat indeed the hiss may not happen
19:24 paramat the plan was an 'on flood' callback
19:25 T4im the on_destruct should be called though imo, I get it with bulk operations for speed, but with liquids, that might lead to missed out clean up when nodes define it (if some floodable node spawns entities or something like that, it should probably clean up afterwards)
19:25 paramat that could do the sounds and other useful things, including drops
19:25 T4im yea
19:25 T4im or that
19:33 paramat 4245 seems to have 2 approvals
19:34 paramat oh, there are more recent additions
19:37 damiel_ joined #minetest-dev
19:40 paramat ok i'll merge game#1186 now as practice in making changes on merge
19:40 ShadowBot https://github.com/minetest​/minetest_game/issues/1186 -- Faster way to look for snow around pine sapling by tenplus1
19:56 blaze joined #minetest-dev
19:56 paramat that went smoothly, merged
20:04 paramat merging game#1185 game#1187
20:04 ShadowBot https://github.com/minetest​/minetest_game/issues/1185 -- Doors: Fix trapdoor crash on can_dig with nil-player by t4im
20:04 ShadowBot https://github.com/minetest​/minetest_game/issues/1187 -- Bones: New textures by paramat
20:11 paramat merged
20:16 paramat nore any opinion on game#1159 ?
20:16 ShadowBot https://github.com/minetest​/minetest_game/issues/1159 -- Stair corners missing
20:19 nore close from me
20:19 miloszs joined #minetest-dev
20:20 davisonio joined #minetest-dev
20:20 nore (I'd say, leave that to mods for now)
20:21 Darcidride joined #minetest-dev
20:23 miloszss joined #minetest-dev
20:25 paramat ok
20:26 paramat 3 disapprovals so closing
20:29 paramat closed my own issue game#1171
20:29 ShadowBot https://github.com/minetest​/minetest_game/issues/1171 -- Remove reverse crafting of mese crystals and fragments
20:29 Lunatrius` joined #minetest-dev
20:29 davisonio joined #minetest-dev
20:30 paramat nore perhaps game#939 can be closed, if you disapprove
20:30 ShadowBot https://github.com/minetes​t/minetest_game/issues/939 -- Add scissors
20:30 T4im paramat: game#1137 doesn't need an engine change, the step code is luaside; probably some hard coded height-assumptions
20:30 ShadowBot https://github.com/minetest​/minetest_game/issues/1137 -- Boats sink through world if underwater, dependent on collisionbox size
20:31 paramat ok
20:31 nore paramat: hm, it feels like a bit too many tools I'd say
20:31 nore so close
20:31 paramat ok
20:37 paramat closed game#884
20:37 ShadowBot https://github.com/minetes​t/minetest_game/issues/884 -- Suggestion: Tweak straw
20:40 paramat i'm fairly happy when mtg is down to roughly 30 issues, 30 PRs :]
20:56 Fixer_ joined #minetest-dev
21:00 jordan4ibanez joined #minetest-dev
21:01 jordan4ibanez joined #minetest-dev
21:12 davisonio joined #minetest-dev
21:17 sloanonhexchat joined #minetest-dev
21:18 sloanonhexchat left #minetest-dev
21:30 davisonio joined #minetest-dev
21:37 Void7 joined #minetest-dev
21:47 davisonio joined #minetest-dev
21:52 paramat left #minetest-dev
22:24 est31 joined #minetest-dev
22:25 est31 with #4308 merged, the only compiler warnings remaining with gcc 6.1 are in lua
22:25 ShadowBot https://github.com/minetest/minetest/issues/4308 -- Treegen: Improve use of signed vs. unsigned integers by paramat
22:25 est31 and those cant be fixed, bc lua ought not to be touched :)
22:49 Void7 joined #minetest-dev
23:17 SloanOnLinux joined #minetest-dev
23:31 whitephoenix joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext