Time Nick Message 04:37 Hijiri not an official dev but I like the idea 04:37 Hijiri inventory tabs is something that needs a canonical implementation 04:38 Hijiri Or, a generic enough common interface to allow many implementations to work with any mod that implements the interface 07:07 paramat ~tell rubenwardy your todo list seems good. until we get new engine support for ambience sounds perhaps you would be interested in considering using the lua implementation in tenplus1's 'ambience' mod, for fire and flowing water only though. fire mod sounds really need replacing, see https://github.com/minetest/minetest_game/issues/1112 07:07 ShadowBot paramat: O.K. 07:28 paramat sofar if you can sometime, review appreciated game#1174 07:28 ShadowBot https://github.com/minetest/minetest_game/issues/1174 -- Ores: Clean up. Simplify. Add ores for upper realms by paramat 09:04 OldCoder "WARNING: ACKed packet not in outgoing queue" 09:04 OldCoder Are there any new thoughts on this one? 10:21 celeron55 OldCoder: normal operation of the network layer under less than ideal network conditions 13:04 Fixer !tell paramat why only fire and water flowing? his mod works nice on 40 players server, why not include it as a whole? I did some mod profiling and it was lightweight iirc, I can do tests in singleplayer if needed again 13:04 ShadowBot Fixer: O.K. 13:26 everamzah a lot of the sounds are low quality (repeatedly compressed, lossy), and some may not be appropriate (canadianloon is louder than glass) 13:32 rubenwardy ShadowBot! 13:32 rubenwardy oh, msg sent in another channel 13:33 rubenwardy !tell paramat I'd like to investigate that at some point. If it's anything like the old immersive sounds / ambience then the effect isn't ideal 13:33 ShadowBot rubenwardy: O.K. 13:33 Fixer everamzah: that can be fixed by better sounds 13:33 Fixer everamzah: with freesounds.org 13:33 everamzah maybe, maybe not. the sounds themselves are fine 13:33 everamzah they're linked in the license files 13:33 everamzah and you can get the original high quality sources, if u want 1mb ogg files 13:34 everamzah but fire/water, maybe a few other choice ones to start 13:34 Fixer ambience lite mod is 1.2mb 13:34 everamzah i like the dripping one deep down. yes 1.2 mb with very poor quality audio files 13:35 everamzah i mean, they're fine on laptop speakers 13:35 everamzah but more than the filesize/audio quality, i think many of the sounds don't really apply 13:35 everamzah why add a canadianloon sound, when there are no canadian loons 13:35 Fixer everamzah: avg bitrate = 46 kbps 13:35 everamzah just listen to the sources 13:35 Fixer everamzah: that can be removed if not needed 13:36 rubenwardy I don't like how sudden the transitions were on the old immersive sounds mod, and how only one sound played at a time 13:36 everamzah i once replaced all the sounds in ambience mod is higher quality originals 13:36 Fixer everamzah: it can be trimmed 13:36 rubenwardy *didn't 13:36 Fixer rubenwardy: yeah 13:36 everamzah ye i have no problem with the actual ambience mod, i love it 13:36 everamzah i think the sounds themselvs should be discussed tho 13:36 Fixer we need wind too 13:36 everamzah in terms of filesize/quality and appropriateness of what they are (re: canadianloon) 13:37 Fixer it is lifeless without wind 13:37 everamzah yes, wind too 13:37 everamzah water/fire a must. wind good, i like dripping sound. 13:38 Fixer i remember one game, that won "sound award" in 2001 iirc, Tom Clancy's Ghost Recon (released in 2001), ambience sounds were very good, they were simple but immersion was damn good 13:38 Fixer big part of this is wind+leaves effect 15:38 Calinou Quake had wind too :p 15:39 KaadmY Calinou: wind in what sense? audio? 15:39 Calinou ambient sounds 15:39 Calinou and wind tunnels :) 15:39 KaadmY wind has a nice atmosphere 15:43 rubenwardy It's much easier for games with premade maps to have ambient sounds 15:43 rubenwardy as you can place the sound sources yourself in the right places 15:44 rubenwardy but a procgen game would need to work out how to optimise/abbreviate large areas of sound sources into one source to reduce sound overlaying 16:26 rubenwardy game#1179 16:26 ShadowBot https://github.com/minetest/minetest_game/issues/1179 -- Add simple fast inventory by rubenwardy 16:26 rubenwardy (updated) 16:28 rubenwardy sfan5, nore ^ 16:28 rubenwardy iirc you are the only mtg devs present... 16:30 Krock we need more of that species called "minetest dev" 16:30 rubenwardy sofar ^ 16:30 Krock make a mod for it 16:31 rubenwardy Create a complete AI whose purpose is to develop Minetest 16:31 rubenwardy [30 marks] 16:31 T4im if you're already heading for inclusion, could you maybe include the linting prepartions that are part of creative? that way I could drop those, if yours gets in faster 16:31 rubenwardy AI escapes into the real world, starts making the real world blocky 16:32 T4im game#1164 that is 16:32 ShadowBot https://github.com/minetest/minetest_game/issues/1164 -- Variable and Value cleanup to prepare CI-Linting by t4im 16:32 rubenwardy okay, will do 16:32 T4im it's probably just some variable renaming there 16:32 T4im to avoid upvalue shadowing 16:32 T4im thanks :) 16:34 rubenwardy the upvalue shadowing doesn't actually matter though 16:35 rubenwardy There's not really much point doing get_player_name() again, in face 16:37 rubenwardy done, T4im 16:43 T4im thanks :) 16:43 rubenwardy urgh 16:43 T4im it won't be a problem in most cases, but since this could lead to errors, the linter still fails on finding those 16:43 rubenwardy why do labels cover up buttons? 16:44 rubenwardy so stupid 16:44 rubenwardy how do I make a label center aligned? 16:45 T4im ah, right, they have different margin/padding or something like that, eh? 16:45 T4im I forgot the details though :( 16:45 rubenwardy found out how to make labels below buttons so they don't cover it up 16:45 rubenwardy but now it's not center aligned 16:46 rubenwardy paramat, game#1179 16:46 ShadowBot https://github.com/minetest/minetest_game/issues/1179 -- Add simple fast inventory by rubenwardy 16:46 rubenwardy oh, and hi! 16:47 paramat will merge game#1081 game#1177 game#1178 in a moment 16:47 paramat hi 16:47 ShadowBot https://github.com/minetest/minetest_game/issues/1081 -- Placing liquid in protected area fixed by tenplus1 16:47 ShadowBot https://github.com/minetest/minetest_game/issues/1177 -- Add api information for sethome functions by tenplus1 16:47 ShadowBot https://github.com/minetest/minetest_game/issues/1178 -- add position table reference by tenplus1 16:49 paramat hm i'm useless at inventory/formspec stuff, and neutral about the feature, so i'll leave this to other devs :] 16:51 rubenwardy All those PRs look good ^ 16:51 rubenwardy Says something when I find HTML/CSS easier to format nice things than formpecs 16:52 paramat nore sfan5 sofar much appreciated if you can consider game#1174 sometime 16:52 ShadowBot https://github.com/minetest/minetest_game/issues/1174 -- Ores: Clean up. Simplify. Add ores for upper realms by paramat 16:53 T4im I'll followup 1081 then though, that looks like that crashs (but already before that pr) when placing against nodes into unknown ones, if I see that right 16:53 T4im shouldn't wait on that though, its probably rather rare, and a quick fix 16:54 paramat ok 16:55 paramat now merging those 3 16:57 nore paramat: game#1174 looks fine 16:57 ShadowBot https://github.com/minetest/minetest_game/issues/1174 -- Ores: Clean up. Simplify. Add ores for upper realms by paramat 16:57 nore but I have not computed how it changes the average number of ores per block 16:57 nore have you? 16:58 * Krock gives rubenwardy a good paper press to squash all the 10 commits 16:58 rubenwardy Will do on merge, Krock 16:58 rubenwardy It's useful for reviewing 16:58 Krock oh okay 16:59 paramat well the simplification of iron registrations changes iron density from 0 to -64, it's more common 17:00 paramat i decided it was worth it for the simplification, and because 0 to -64 is such a small range 17:01 rubenwardy Can't see any problems with game#1174 17:01 ShadowBot https://github.com/minetest/minetest_game/issues/1174 -- Ores: Clean up. Simplify. Add ores for upper realms by paramat 17:01 rubenwardy Mostly magic value changes 17:01 Krock yeah, it looks good 17:02 paramat iron becomes twice as common from 0 to -64 17:02 rubenwardy Just noticed that my 's' key is broken, must be from too many ctrl+s presses. Only works if I press it hard 17:02 rubenwardy #programmertroubles 17:06 paramat ok i'll merge 1174 too then 17:13 rubenwardy update #4276 17:13 ShadowBot https://github.com/minetest/minetest/issues/4276 -- Remove cinematic mode binding by rubenwardy 17:24 paramat merges complete 17:25 T4im heh, do I see that right? skymese? 17:25 T4im ah, I should read the conversation first, nvm :D 17:26 T4im nice 17:29 paramat yeah skymese 17:39 T4im game#1180 paramat 17:39 ShadowBot https://github.com/minetest/minetest_game/issues/1180 -- Fix bucket crash, but allow placing against unknown nodes instead. by t4im 17:40 T4im actually two quick fixes, but the second is minor (no need to prevent placing on top of next to unknown nodes, if that is handled safely) 17:40 paramat ok 17:50 T4im s/of/or/ 18:09 est31 will push #4282 in 10 minutes 18:09 ShadowBot https://github.com/minetest/minetest/issues/4282 -- Fix for cropped text "Toggle Cinematic" by SmallJoker 18:31 Krock hehe.. labeled after merging 18:31 T4im the bad news is, even with skipping builds, travis will still take ~30s before passing and that doesn't account for the time it takes for the system to even start building 18:32 est31 :) 18:36 sfan5 anyone want to bother to merge this? https://github.com/minetest/minetest/pull/4239 18:37 est31 doing it right now 18:38 sfan5 thanks 19:41 T4im #4284 seems to behave, following the tests 19:41 ShadowBot https://github.com/minetest/minetest/issues/4284 -- Travis: Skip installation and compilation for non-C++ related changes by t4im 21:45 OldCoder OldCoder: normal operation of the network layer under less than ideal network conditions 21:45 OldCoder Right 21:45 OldCoder I've been experimenting with tweaks to improve reliablity 21:45 OldCoder I don't think there's a way for it to be both reliable and fast though 21:46 OldCoder I see that proller increased a buffer size to a value that may technically be illegal 21:46 OldCoder I'll talk to him sometime if I can reach him