| Time |
Nick |
Message |
| 00:12 |
|
est31 joined #minetest-dev |
| 00:21 |
|
Tmanyo joined #minetest-dev |
| 00:34 |
paramat |
est31 is it possible you could review #4135 ? big PR though and i know you don't have much time |
| 00:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/4135 -- Biomegen by kwolekr |
| 00:36 |
est31 |
I have looked at parts of it and approve with the changes I could understand |
| 00:36 |
est31 |
but full review, no, I'm heading to bed now |
| 00:41 |
paramat |
cool |
| 00:58 |
|
Tmanyo joined #minetest-dev |
| 01:04 |
|
electrodude512 joined #minetest-dev |
| 01:06 |
|
hmmmm joined #minetest-dev |
| 01:29 |
|
DI3HARD139 joined #minetest-dev |
| 01:57 |
|
Void7 joined #minetest-dev |
| 02:03 |
|
STHGOM joined #minetest-dev |
| 03:01 |
|
Void7 joined #minetest-dev |
| 03:29 |
|
Void7 joined #minetest-dev |
| 03:41 |
|
Void7 joined #minetest-dev |
| 03:45 |
|
ShadowBot joined #minetest-dev |
| 03:47 |
|
VanessaE joined #minetest-dev |
| 03:48 |
|
ShadowNinja joined #minetest-dev |
| 03:48 |
|
ShadowNinja joined #minetest-dev |
| 04:35 |
|
xunto joined #minetest-dev |
| 05:17 |
|
Hunterz joined #minetest-dev |
| 05:59 |
paramat |
hmmmm, with lvm, is it safe to 'read from map', 'get data' and then abort without doing 'set data', 'write to map' afterwards? any memory leak or issues? |
| 05:59 |
hmmmm |
no |
| 05:59 |
paramat |
good |
| 05:59 |
hmmmm |
would've been documented as such if that were the case |
| 06:16 |
hmmmm |
paramat: close #3929? |
| 06:16 |
ShadowBot |
https://github.com/minetest/minetest/issues/3929 -- add a setting for exponential view distance adjustment by DS-Minetest |
| 06:17 |
paramat |
yes |
| 06:18 |
paramat |
almost has 4 disapprovals |
| 06:24 |
hmmmm |
how about #4047 |
| 06:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/4047 -- Merge threads.h into threading/thread.h by ShadowNinja |
| 06:25 |
|
nrzkt joined #minetest-dev |
| 06:28 |
paramat |
looking |
| 06:30 |
paramat |
if the issues were fixed would you support this moving of stuff? i feel somewhat neutral |
| 06:30 |
hmmmm |
yes, it doesn't make sense to have two separate files for threading, and then have one of them dependent on a file in the main source tree |
| 06:30 |
hmmmm |
(aren't the subdirectory source files supposed to be thought of as standalone entities?) |
| 06:31 |
|
jin_xi joined #minetest-dev |
| 06:31 |
hmmmm |
in other words we should be able to take util/ and make that into its own library and use it in other completely different projects |
| 06:31 |
hmmmm |
we should be able to take threading/ and do the same |
| 06:31 |
hmmmm |
perhaps there's an implicit exception to server/ and client/ |
| 06:32 |
paramat |
then i would keep it open and ask for improvement |
| 06:32 |
nrzkt |
hmmmm, agreed |
| 06:32 |
hmmmm |
i'm going to add an action required tag |
| 06:34 |
paramat |
there is one :) |
| 06:34 |
hmmmm |
i mean to that PR |
| 06:34 |
hmmmm |
i'm the one who made that tag btw |
| 06:34 |
paramat |
heh i see |
| 06:34 |
paramat |
yeah |
| 06:34 |
hmmmm |
seems to be the more common case that PRs aren't ready than those that are ready |
| 06:35 |
hmmmm |
unfortunately you can't assign multiple people to the same pr/issue |
| 06:57 |
|
paramat left #minetest-dev |
| 07:11 |
|
Darcidride joined #minetest-dev |
| 07:18 |
|
Guest88969 joined #minetest-dev |
| 07:39 |
|
OldCoder joined #minetest-dev |
| 07:48 |
|
hmmmm joined #minetest-dev |
| 07:50 |
|
nrzkt joined #minetest-dev |
| 07:57 |
|
Amaz joined #minetest-dev |
| 09:00 |
|
paramat joined #minetest-dev |
| 10:12 |
|
Samson1 joined #minetest-dev |
| 10:22 |
|
Fixer joined #minetest-dev |
| 10:33 |
|
nrzkt joined #minetest-dev |
| 10:50 |
|
paramat left #minetest-dev |
| 11:18 |
|
Megaf joined #minetest-dev |
| 11:35 |
|
Grandolf joined #minetest-dev |
| 11:35 |
|
DonBatman joined #minetest-dev |
| 11:43 |
|
damiel joined #minetest-dev |
| 11:52 |
|
Lunatrius` joined #minetest-dev |
| 12:18 |
|
proller joined #minetest-dev |
| 12:19 |
|
electrodude512 joined #minetest-dev |
| 12:23 |
|
STHGOM joined #minetest-dev |
| 12:28 |
|
Megaf joined #minetest-dev |
| 12:38 |
|
Megaf_ joined #minetest-dev |
| 12:59 |
|
lisac joined #minetest-dev |
| 13:00 |
|
srifqi joined #minetest-dev |
| 13:00 |
|
Calinou joined #minetest-dev |
| 13:05 |
|
DFeniks joined #minetest-dev |
| 14:14 |
|
Grandolf joined #minetest-dev |
| 14:44 |
|
Void7 joined #minetest-dev |
| 14:54 |
|
KaadmY joined #minetest-dev |
| 15:06 |
|
hmmmm joined #minetest-dev |
| 15:40 |
|
Krock joined #minetest-dev |
| 16:33 |
|
Obani joined #minetest-dev |
| 16:34 |
|
Obani left #minetest-dev |
| 16:39 |
|
Puka joined #minetest-dev |
| 16:48 |
|
Void7 joined #minetest-dev |
| 17:05 |
|
rubenwardy joined #minetest-dev |
| 17:16 |
|
Darcidride joined #minetest-dev |
| 17:20 |
|
Krock joined #minetest-dev |
| 17:28 |
|
nrzkt joined #minetest-dev |
| 18:02 |
|
est31 joined #minetest-dev |
| 18:14 |
est31 |
nrzkt, just try my PR |
| 18:14 |
est31 |
your suggested change breaks it |
| 18:27 |
nrzkt |
est31 that's very strange... then okay for your virtual |
| 18:29 |
est31 |
nrzkt, do you +1 the Pr |
| 18:30 |
nrzkt |
y |
| 18:32 |
est31 |
I'll push it then |
| 18:33 |
|
Hunterz joined #minetest-dev |
| 18:43 |
|
turtleman joined #minetest-dev |
| 18:50 |
|
jin_xi joined #minetest-dev |
| 18:54 |
|
hmmmmm joined #minetest-dev |
| 19:44 |
|
exoplanet joined #minetest-dev |
| 20:26 |
|
Amaz joined #minetest-dev |
| 20:44 |
nore |
hmmmmm: I thought about your ideas for EnrichedString a bit, and using a basic_string is not a good idea, because it limits the extension possibilities |
| 20:45 |
nore |
for exemple, adding clickable links wouldn't be possible |
| 21:15 |
nrzkt |
est31, in fact yoru PR was wrong :p i didn't see it (was very busy :p) |
| 21:15 |
nrzkt |
the modification on virtual |
| 21:16 |
est31 |
you were wrong, not me :) |
| 21:17 |
nrzkt |
no no |
| 21:17 |
nrzkt |
look at the comment on your extra commit :p |
| 21:17 |
nrzkt |
on your repo |
| 21:17 |
nrzkt |
you removed virtual from parent, you shouldn't, you should only remove from childs :p |
| 21:20 |
|
Void7 joined #minetest-dev |
| 21:31 |
|
xunto joined #minetest-dev |
| 21:49 |
|
stormchaser3000 joined #minetest-dev |
| 21:54 |
|
Megaf_ joined #minetest-dev |
| 22:02 |
|
stormchaser3000 joined #minetest-dev |
| 22:10 |
|
ptv joined #minetest-dev |
| 22:10 |
|
xunto joined #minetest-dev |
| 22:14 |
|
troller joined #minetest-dev |
| 22:15 |
|
xunto joined #minetest-dev |
| 22:37 |
|
stormchaser3000 joined #minetest-dev |
| 22:38 |
|
Zeno` joined #minetest-dev |
| 23:12 |
|
Tmanyo joined #minetest-dev |
| 23:12 |
|
stormchaser3000 joined #minetest-dev |
| 23:12 |
|
Void7 joined #minetest-dev |
| 23:23 |
|
Anchakor__ joined #minetest-dev |
| 23:42 |
|
kahrl joined #minetest-dev |
| 23:44 |
|
Lunatrius` joined #minetest-dev |
| 23:54 |
|
kaeza joined #minetest-dev |
