Time Nick Message 00:03 Fixer minetest needs ingame manual/tutorial 00:03 Fixer now even I'm not sure if i can use logs as fuel 00:41 sofar fixer should just start working on tutor content 01:30 EvergreenTree Any thoughts on #4127 now that the rush to release 0.4.14 is over? 01:30 ShadowBot https://github.com/minetest/minetest/issues/4127 -- Avoid calling DiePlayer more than once by 4Evergreen4 02:11 hmmmm paramat did you recently change one of the biome beach nodes to gravel 02:11 hmmmm i am noticing an inconsistency in one of my test maps and i'm wondering if i screwed up somewhere and made a bug or if it's because that piece was already generated 02:35 paramat hmmmm, i did, tundra 02:35 hmmmm that's a relief 02:36 hmmmm when i start flying over terrain and i see an inconsistent piece ending on a chunk border... i start to panic 02:37 paramat game#810 28 Jan 02:37 ShadowBot https://github.com/minetest/minetest_game/issues/810 -- Default/mapgen: Add gravel beach in Tundra by paramat 02:39 paramat mgv7 cliffs are slightly less steep too, in case you notice that 02:42 paramat what's weird is how my fix for floating dungeon slices has only just gone into stable, that PR feels like years ago 02:46 paramat biomes will be improved again soon #1022 changes of biome with altitude 02:46 ShadowBot https://github.com/minetest/minetest/issues/1022 -- DFSG (and similar) compliance 02:46 paramat oops 02:46 paramat game#1022 02:46 ShadowBot https://github.com/minetest/minetest_game/issues/1022 -- Default/mapgen: Add upper limits to forest biomes and trees by paramat 02:57 hmmmm anybody else want to do a review on my biomegen branch? 02:57 hmmmm https://github.com/kwolekr/minetest/commits/biomegen 02:58 paramat yes, i'll look at it again 02:59 hmmmm well no offense but i want multiple people looking at it 03:00 paramat yeah indeed 03:00 hmmmm i want to make sure that it works correctly 03:00 hmmmm Because we believe anything which does not work correctly should be DESTROYED. 03:02 paramat i'll review the stuff i understand, so we do need other reviewers 03:30 Zeno` hmmmm 03:30 Zeno` https://github.com/kwolekr/minetest/commit/937ac688f659f6a414b3d002427613f7fce8902b#diff-e876a0a129495f2b2dd1182861fa6ea3R136 03:31 Zeno` the order was defined before your change 03:31 hmmmm ??? 03:32 Zeno` that's an initialiser list to a constructor so the order is defined as "in that they appear" (unlike a function call) 03:33 hmmmm the values are assigned in the initializer list, this is evaluating a function call's arguments 03:33 hmmmm try it yourself if you don't believe me that the order is ill-defined 03:33 Zeno` well it's better safe than sorry anyway, even if I'm wrong 03:33 hmmmm no I actually tested this exact scenario in a minimal sample case 03:34 hmmmm clang and gcc are indeed different 03:34 Zeno` weird 03:34 hmmmm what C++ guarantees is that all arguments will have been evaluated by the time the function/constructor/whatever executes 03:34 Zeno` ah, hang on nevermind 03:34 Zeno` the part I am reading is referring to something different. You're right 03:35 hmmmm so the arguments are evaluated, and then the controls transfers to the constructor initializer list head 03:35 hmmmm i'm glad somebody is actually looking at this crap :D 03:39 Zeno` I wish you'd make a PR so I could look at all the changes squashed :p 03:40 Zeno` e.g. https://github.com/kwolekr/minetest/commit/f03fba9ae28c7a0be7532296b2fd1f8720a672ed#diff-e876a0a129495f2b2dd1182861fa6ea3R167 03:40 Zeno` I have to then look at an earlier commit to see if it wasn't missed :P 03:40 hmmmm yeah 03:40 Zeno` can you PR to my repo? 03:41 hmmmm I'll make a PR for it for viewing, but I'd rather not squash the commits since I try to adhere to the one-change-per-commit principle 03:41 Zeno` of course 03:41 hmmmm why make a PR to your repo exactly? 03:41 hmmmm what difference does it make 03:41 Zeno` nothing :) 03:44 hmmmm ok did it, $4135 03:44 hmmmm #4135 03:44 ShadowBot https://github.com/minetest/minetest/issues/4135 -- Biomegen by kwolekr 03:45 paramat will test 03:54 Zeno` Code Boneyard hehe 03:57 Zeno` https://github.com/minetest/minetest/pull/4135/files#diff-5a3527c6dddd0430ce6d04404ea096baR120 03:57 Zeno` why the funny spacing? 04:02 paramat weird 04:03 paramat could be vertically aligned but on single lines? 04:06 paramat i've looked through all commits, as far as i understand it, it looks good, but need to test thoroughly 04:12 hmmmm Zeno`, I couldn't find a way to make it look neat 04:12 hmmmm append &ts=4 to that link and you'll see it line up 05:14 paramat i see, tab size 05:15 Zeno` dat's why I prefer tabs for indent and spaces for alignment 05:16 Zeno` but *shrug* 05:37 Zeno` looks good to me, hmmmm 05:38 Zeno` there is one instance of comparing a float to a double but it's always been there and I don't want to mention it 05:38 hmmmm oh 05:38 hmmmm i never pushed that commit 05:39 Zeno` which commit? 05:40 hmmmm https://github.com/kwolekr/minetest/commit/27a57ca16191c61e7aff7236566e1c4de08e6357 05:41 Zeno` and one more here https://github.com/minetest/minetest/pull/4135/files#diff-e876a0a129495f2b2dd1182861fa6ea3R258 05:41 Zeno` oops you captured it 05:41 Zeno` may as well include that commit as well 05:41 Zeno` since you've already done it :) 05:46 Zeno` https://github.com/minetest/minetest/labels/Merge%20for%20testing%20candidate 05:47 Zeno` tested #4077 and I think when nore addresses any issues that might need addressing it should be merged soon so we can start widespread testing 05:47 ShadowBot https://github.com/minetest/minetest/issues/4077 -- Colored chat and other strings by Ekdohibs 05:47 Zeno` Also tested 4124 but not as thorougly 05:48 Zeno` and #4059 has two approvals, is simple and I think it's baked and ready 05:48 ShadowBot https://github.com/minetest/minetest/issues/4059 -- Add on_punchnode callback to falling.lua by Wayward1 05:48 Zeno` err 05:49 Zeno` hmm... or does it need documentation? 06:21 hmmmm what is "merge for testing"? 06:22 Zeno` kind of like it should be merged ASAP so it can be tested by a lot of people I think 06:22 hmmmm i don't like that 06:23 Zeno` why not 06:23 hmmmm the point of testing is to make sure it can be merged 06:23 Zeno` yeah... 06:24 Zeno` but there are few devs and lots of people who are not devs (who can make testing more efficient) 06:24 thePalindrome Yeah, it's a bit of a weird situation 07:08 nrzkt hmmmm: will fix based on your comments 07:22 est31 nrzkt, my mistake, your pr does not need change https://github.com/minetest/minetest/pull/4124#discussion_r63474027 07:34 nrzkt no problem est31 10:39 nrzkt i'm thinking about a dynamic stat systems for player. I think it could be good to have HUD using local stats in the dynstat systems on client without sending an hud update to client on each stat modification, just updating the stat value 12:05 Wayward_One Zeno`, what kind of documentation did you have in mind? 12:06 Zeno` Wayward_One, should it be documented in the script API docs? I dunno, I was only quickly looking 12:07 nore nrzkt: good idea 12:10 Zeno` anyway apart from the potential need for documentation I'm happy for it to be merged 12:11 Wayward_One Zeno`, I just looked, I don't see anywhere it would need to be documented 12:11 Wayward_One You do mean the lua_api.txt, right? 12:11 Zeno` what's the PR again? 12:12 Zeno` The # I mean 12:12 Wayward_One #4059 12:12 ShadowBot https://github.com/minetest/minetest/issues/4059 -- Add on_punchnode callback to falling.lua by Wayward1 12:13 Zeno` oh yeah 12:13 Zeno` *shrug* merge 12:13 Zeno` nore, can you look at that as well please? 12:14 nore Zeno`: looking 12:15 nore :+1: 12:15 Zeno` ok will merge 12:16 Zeno` done 12:27 Zeno` looks like 0.4.15 is almost ready to release! 12:28 nrzkt Zeno`: hi can you look at my pr for database exception please :) 12:28 nrzkt nore: if i get time i will write a draft for this 12:28 nrzkt nore, Zeno`: why nore remove the env_meta file and add to to each DB backend ? It's more stable than a file which could be corrupted on crash 12:29 nrzkt i have this method on my server and it's far better :) 12:29 nrzkt i can also write a draft 12:29 Zeno` I'm not the best person to ask about reviewing exception related PRs (I hate exceptions) 12:29 nore nrzkt: I agree too 12:29 nrzkt Zeno`: i also hate it, but here it's for having a better naming exception 12:30 nrzkt nore: cool :) when my postgresql backend PR will be merge i will prepare it :) 12:30 Zeno` from what I can see it looks good; it's a pretty small change 12:30 nrzkt nore, Zeno`: please look at #4136 please :) 12:30 ShadowBot https://github.com/minetest/minetest/issues/4136 -- Implement DatabaseException for databases by nerzhul 12:30 nrzkt okay Zeno`then i can merge ? 12:30 Zeno` you don't need to ask me :) est31 has already approved 12:31 Zeno` but I can't see why not 12:31 nrzkt yes, but three is better than two :p 12:31 nore nrzkt: looking 12:31 Zeno` it's just adding another level of detail 12:31 nore Looks good 12:32 nrzkt Zeno`: yes :) 12:32 Zeno` as in more detail if something goes wrong, so yeah 12:32 nrzkt push it then 12:32 Zeno` yep 12:32 nore However, there was nothing to change in leveldb? 12:32 nrzkt i need to to rebase my postgresql thing 12:32 Zeno` after answering nore's question :) 12:33 nrzkt yes i forgot it 12:33 nrzkt #define ENSURE_STATUS_OK(s) \ 12:33 nrzkt only this 12:33 nrzkt i'm changing it and pushing, okay ? 12:33 Zeno` nah hang on 12:34 Zeno` something needs updating for leveldb? 12:34 nrzkt Zeno`: that's pushed on my branch 12:34 nrzkt just the exception name 12:34 nrzkt https://github.com/minetest/minetest/pull/4136/files 12:34 nrzkt There is not more FileNotGoodException in leveldb 12:34 Zeno` and it's not in the PR because... ? 12:35 nrzkt i forget it 12:35 nrzkt and now it's in the pr because you remember me :p 12:35 nore Ok, good :) 12:35 nicoalta01 hey Italian Users 12:35 nicoalta01 italian channel is open! 12:35 nrzkt Zeno`: is this okay for you or did you want me to change anything more ? 12:36 nrzkt nicoalta01: carramba 12:36 nicoalta01 ##minetest-it 12:36 PilzAdam https://github.com/minetest/minetest/commit/8b940c005fd13db4e611ec49bc44881048b42cf7 <- this has a bad commit message 12:36 PilzAdam should be more like "Update falling nodes in on_punchnode, too" 12:38 Zeno` Why didn't you say so then? 12:39 nrzkt nore: can i merge ? :) 12:39 nore nrzkt: looking again 12:40 nore Assuming there is no other forgotten exception, then yes 12:41 nrzkt okay, i merge it and rebase my pgsql pr 12:47 PilzAdam Zeno`, sorry, didn't see it earlier :-/ 13:03 Fixer https://github.com/minetest/minetest/issues/3667 will someone ever decide on "fall with shift cheat", it is feature or bug? 13:03 sfan5 bug definitely 13:05 nrzkt sfan5: agreed 13:06 twoelk I would agree that is a bug while the sneak-ladder is a feature and can be described as climbing with hands and feet - although if the player were a ninja ... 13:10 Fixer sneak-ladder cheat is also caused by this 13:10 Fixer if you fix first bug, sneak-ladder will not work anymore 13:10 Fixer i think 13:13 twoelk I thought they could be devided as of wuzzy's mod 13:14 twoelk https://forum.minetest.net/viewtopic.php?f=3&t=14619&p=217554#p217554 13:24 Wayward_One Actually, this bug only surfaced recently, while the sneak ladder has always worked, at least in my experience. I remember countless frantic button-mashing attempts to stop a deadly fall just last year, but holding shift never reduced damage on a full block until recently, at least for me 14:43 Fixer proposal, gravity api, for this: https://forum.minetest.net/viewtopic.php?f=11&t=7887 15:07 xunto Always wanted to have ability to make space simulator using minetest) 18:49 EvergreenTree Now that the rush to release 0.4.14 is over, can someone take a look at #4127 ? 18:49 ShadowBot https://github.com/minetest/minetest/issues/4127 -- Avoid calling DiePlayer more than once by 4Evergreen4 19:22 Fixer paramat: ohi, I've discovered your "Universal geometry realm [0.4.4]" and it is amazing 19:22 paramat i just saw your screenshots, i feel like updating it now, i've neglected my mods too long 19:23 Fixer paramat: i have a suggestion 19:23 paramat chat in minetest channel? 19:27 betterthanyou710 where can someone on debian download 4.14? 19:32 EvergreenTree betterthanyou710: There are no debian packages for 0.4.14 yet afaik, but you can compile it yourself 19:33 betterthanyou710 k 19:33 betterthanyou710 I'll probably do it at a time when i'm not lazy 19:55 paramat sfan5 ShadowNinja please could you add your opinions to game#1093 ? also game#1094 ? < nore 19:55 ShadowBot https://github.com/minetest/minetest_game/issues/1093 -- Default: New mese block texture by paramat 19:55 ShadowBot https://github.com/minetest/minetest_game/issues/1094 -- Default: Remove unnecessary infotexts for chests and signs by paramat 19:56 sfan5 do two approvals and two disapprovals make zero approvals? 19:57 nore paramat: approving if you update the license 19:57 nore (original author is Thomas--S) 19:57 sfan5 paramat: game-1094 is fine 19:57 paramat yes i will update 19:58 nore 1094 is good 19:59 paramat ok 19:59 paramat i don't think disapprovals subtract but we should still consider the complaints 20:00 paramat so i'm hesitating with 1093 20:00 paramat 1094 is +3 so i'll merge that 20:01 sfan5 paramat: can you look at game#1096 20:01 ShadowBot https://github.com/minetest/minetest_game/issues/1096 -- Change Drinking Glass Texture by Thomas--S 20:03 paramat yes 20:03 paramat related to infotext is #4134 20:04 ShadowBot https://github.com/minetest/minetest/issues/4134 -- Item entities: Only show description in debug mode by paramat 20:04 paramat oh that one has problems it seems, nevermind 20:09 paramat +1 game 1096 20:14 paramat hmm ok i might have to submit a new mese texture 20:25 paramat nore shall we close game#1082 now? 20:25 ShadowBot https://github.com/minetest/minetest_game/issues/1082 -- Mese texture by Ekdohibs 20:26 nore paramat: yep 20:26 nore 1093 replaces it 20:26 paramat will do 20:43 EvergreenTree Is there anything should I do on #4127 ? 20:43 ShadowBot https://github.com/minetest/minetest/issues/4127 -- Avoid calling DiePlayer more than once by 4Evergreen4 20:46 EvergreenTree Should I create a ModifyPlayerHP method as hmmmm suggested? 22:43 est31 !tell EvergreenTree yes ModifyPlayerHP sounds the best choice here 22:43 ShadowBot est31: O.K.