Minetest logo

IRC log for #minetest-dev, 2016-03-07

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:00 Fixer i was surprised how much it needed to add stupid timestamps in chat, 30 files!?
00:01 Fixer and it won't compile anyway
00:04 est31 Fixer, two commits are shadowninja cleanups
00:05 Fixer anything interesting to test for now?
00:06 est31 #3677
00:06 ShadowBot https://github.com/minetest/minetest/issues/3677 -- Add minetest.register_lbm() to run code on block load only by est31
00:06 est31 but you need to be able to code mods for it
00:06 Fixer that will be too slow, I think sofar has something for it
00:07 sofar est31: I'll test that again, sorry, didn't get to it just yet
00:07 Fixer https://github.com/minetest/minetest_game/pull/870
00:08 sofar yes that's my canonical test case
00:09 sofar testing...
00:16 sofar lbm_introduction_times = farming:convert_to_nodetimers__farmi​ng__cotton~155444;farming:convert_to​_nodetimers__farming__wheat~155444;
00:28 sofar est31: tests are fine, lbm code is OK
00:33 est31 nice thanks for the tests
00:43 ABun left #minetest-dev
00:43 ABun joined #minetest-dev
00:43 BigCat13 hi
01:02 SaKeLWorld joined #minetest-dev
02:46 iamafriend joined #minetest-dev
02:47 Miner_48er joined #minetest-dev
02:48 ssieb joined #minetest-dev
03:01 paramat joined #minetest-dev
03:20 Dragonop_ joined #minetest-dev
03:40 linkedinyou joined #minetest-dev
03:44 Icedream joined #minetest-dev
04:23 Fritigern joined #minetest-dev
04:29 Warr1024 joined #minetest-dev
04:43 nolsen joined #minetest-dev
05:16 paramat game#897
05:16 ShadowBot https://github.com/minetes​t/minetest_game/issues/897 -- Default: Add jungletree_branch node, use in tree generation by paramat
05:16 paramat left #minetest-dev
06:07 Hunterz joined #minetest-dev
06:23 sofar game#870 has a second patch converting saplings to nodeTimers.
06:23 ShadowBot https://github.com/minetes​t/minetest_game/issues/870 -- Farming: Trees: Convert saplings and plants to NodeTimerRef. by sofar
06:31 nolsen joined #minetest-dev
06:39 srifqi joined #minetest-dev
06:51 srifqi joined #minetest-dev
07:53 nrzkt joined #minetest-dev
08:30 Obani joined #minetest-dev
08:38 ud1_ joined #minetest-dev
08:52 SaKeL joined #minetest-dev
08:53 SaKeLWorld joined #minetest-dev
10:16 blaze joined #minetest-dev
11:13 Hunterz joined #minetest-dev
11:31 AnotherBrick joined #minetest-dev
11:37 Dragonop joined #minetest-dev
11:49 ud1_ joined #minetest-dev
12:03 Calinou joined #minetest-dev
12:09 srifqi Any image to update this image: https://commons.wikimedia.org/wi​ki/File:Minetest_screenshot.png ?
12:27 Fixer joined #minetest-dev
12:51 srifqi hello?
12:55 est31 joined #minetest-dev
12:56 est31 srifqi, you can try asking on #minetest-project
12:56 srifqi okay
13:23 Megaf joined #minetest-dev
13:25 turtleman joined #minetest-dev
13:40 luizrpgluiz joined #minetest-dev
14:13 twoelk joined #minetest-dev
14:20 kaadmy joined #minetest-dev
15:03 est31 joined #minetest-dev
15:32 johnnyjoy joined #minetest-dev
15:58 Player_2 joined #minetest-dev
16:08 hmmmm joined #minetest-dev
16:15 hmmmm joined #minetest-dev
16:15 DFeniks joined #minetest-dev
16:31 Obani joined #minetest-dev
16:55 everamzah joined #minetest-dev
16:57 Krock joined #minetest-dev
16:58 Hunterz joined #minetest-dev
17:21 Amaz joined #minetest-dev
17:21 Megaf_ joined #minetest-dev
17:38 est31 joined #minetest-dev
17:38 est31 kahrl, ShadowNinja, sfan5 this PR is up for review: #3677
17:38 ShadowBot https://github.com/minetest/minetest/issues/3677 -- Add minetest.register_lbm() to run code on block load only by est31
17:39 est31 already used in PRs for mtgame ^
17:40 ShadowNinja est31: Have you removed the hashing?  I think it's just unnecessary complexity  that makes the config file harder to read and edit.
17:40 est31 yes
17:40 est31 i added policy on the names
17:41 est31 allowed characters
17:41 est31 therefore no escaping needed
17:41 est31 so its pretty simple
17:41 est31 three lines or so
17:41 est31 I even removed the hashing internally
17:42 est31 originally i thought it was a good idea for performance
17:42 est31 but the code wasnt really perf critical and kahrl didnt want it either
17:42 est31 do a ctrl+f for "hash" on https://github.com/minetes​t/minetest/pull/3677/files :)
17:43 ShadowNinja est31: Why'd you remove this?  https://github.com/minetest/minetest/pull/3677/​files#diff-eeff0cd9c4812c27edd6961520ec5dd4L95
17:44 est31 because the lua_istable does take care of it already
17:44 est31 I added else cases to those ifs
17:44 est31 giving a nice FATAL ERROR
17:44 est31 instead of just simply letting lua panic
17:44 est31 because thats whats happening
17:44 ShadowNinja est31: But that takes much more code and adds an indentation level.  Just remove the istable check.
17:45 est31 ok
17:45 ShadowNinja est31: Or at least remove the indentation level by doing "if not istable FATAL_ERROR end ..."
17:45 est31 can you add that as line note
17:45 ShadowNinja Sure.
17:45 ElectronLibre joined #minetest-dev
17:45 est31 thanks
17:47 ShadowNinja lua_pop is kind of pointless if you're calling FATAL_ERROR.
17:47 ShadowNinja And "FATAL ERROR: " is probably redundant.
17:47 est31 I'm not that sure anymore whether I want to keep the FATAL_ERROR the first place
17:48 est31 i think the unfriendly error msg comes from the fact that I have normal lua
17:48 est31 not jit lua
17:48 est31 which has better error handling and so on
17:49 ShadowNinja est31: I notice "int registered_*" and "int table" are identical too.
17:50 est31 oh ok
17:50 ShadowNinja est31: Er, regular Lua generally handles errors better.  We just wrapped everything to handle errors better.
17:50 est31 yeah is the case I guess
17:50 davisonio joined #minetest-dev
17:51 est31 well for me lua gives a very unfriendly error msg
17:51 est31 just a "hey there is some mistake you said me this would be a table, but I got nil"
17:51 est31 and then program terminates
17:51 est31 no stacktrace/bt or whatever
17:52 ShadowNinja est31: Use FATAL_ERROR then.
17:52 ShadowNinja Otherwise LGTM.
17:57 est31 ShadowNinja, I'm not sure whether FATAL_ERROR executes lua callbacks or not
17:58 est31 not that i would think its a good idea if it did
17:58 est31 but still
17:58 ShadowNinja est31: It just prints an error and bails with abort().
17:59 ShadowNinja est31: Maybe "throw LuaError(msg)" would be better so it doesn't kill a client in singleplayer.
17:59 est31 thats best probably
18:00 sofar est31: fyi in my related game PR I added an LBM for seedlings to convert to nodetimers as well
18:00 est31 ok
18:00 sofar that removes a ton of ABM calls
18:07 SaKeLWorld joined #minetest-dev
18:29 Calinou joined #minetest-dev
18:31 nrzkt joined #minetest-dev
18:39 est31 ShadowNinja, added a cleanup commit
18:39 est31 found some other minor stuff in the file as well
18:39 ShadowNinja K.
18:40 nolsen joined #minetest-dev
18:42 est31 +1?
18:43 ShadowNinja est31: Yep.
18:44 ShadowNinja est31: Fine if I merge #3309 without the arg removal and the experimental serialization ID inclusion?
18:44 ShadowBot https://github.com/minetest/minetest/issues/3309 -- AreaStore cleanup by ShadowNinja
18:45 est31 soo... then I have two approvals, even if I didnt count me
18:45 est31 i'll merge the LBM patch then
18:45 est31 or sfan5 do you object to the cleanup commit?
18:46 paramat joined #minetest-dev
18:47 est31 ShadowNinja, okay.
18:53 est31 no reply from sfan
18:53 est31 well its not such a big commit
18:53 est31 dont need his approval, mine and sn's are enough
18:53 est31 just good that the LBM patch has three approvals
18:53 ssieb joined #minetest-dev
18:57 davisonio joined #minetest-dev
18:58 sofar nice
18:58 Megaf joined #minetest-dev
18:59 sfan5 *wait's 7 minutes*
18:59 davisonio joined #minetest-dev
18:59 sfan5 "no reply from sfan"
18:59 sfan5 you're really patient
19:00 Krock xD
19:00 est31 :/
19:00 est31 sorry
19:01 sofar aren't you two like around the corner, anyway?
19:01 est31 ?
19:01 sofar timezone wise, at least
19:02 est31 yeah we are both from germany
19:04 est31 five core devs from germany, two from france, two from usa, one from gb, one from finland
19:04 est31 before BM left we were 50% german :)
19:04 sofar I'm either from The Netherlands or the USA, depending on your viewpoint
19:05 sfan5 that must be the cause for the efficient management of the development process
19:05 sfan5 oh wait
19:06 Megaf "efficient"
19:06 est31 :)
19:06 ShadowNinja sfan5: You agree?
19:06 sofar oiled like german engines?
19:06 Megaf you need to put me in charge of management, I'm Brazilian, imagine what would happen
19:06 sfan5 ShadowNinja: haven't looked at areastore cleanups yet
19:06 sofar scary, but fun!
19:07 est31 I'm going to bed now
19:07 sfan5 wat
19:07 sfan5 at 20:07?
19:07 est31 yes
19:07 ShadowNinja sfan5: Will you?
19:07 est31 i wake up early tomorrow morning
19:07 sfan5 i can take a look at it
19:07 sfan5 how early?
19:07 est31 sfan5, that was my evil plan all time long, thats why i rushed the PR :)
19:07 est31 bye
19:08 sfan5 very early apparently
19:08 sofar wow, something about his bed must be awesome
19:08 sofar does he have dogs?
19:09 sfan5 are you implying that the dogs are in his bed?
19:09 sofar anyway, awesome that LBM's landed. gonna do another check on my nodetimer conversions
19:09 fireglow joined #minetest-dev
19:09 sfan5 ShadowNinja: why areastore -> area_store?
19:09 sofar sfan5: more that he doesn't have them ;)
19:09 ShadowNinja sfan5: Because they're seperate words.
19:10 ud1_ joined #minetest-dev
19:10 sfan5 ShadowNinja: where's my v_3_s_32?
19:11 sfan5 seperate words does not mean that it needs to be seperated
19:11 sfan5 what about L_B_M and A_B_M?
19:11 sfan5 why don't we have those
19:12 paramat any reviews for game#758 ? good new sounds, should we use them for glass doors too, as they are 'modern' sounds and non-wooden sounding?
19:12 ShadowBot https://github.com/minetes​t/minetest_game/issues/758 -- Add sounds for steel doors. by sofar
19:13 ShadowNinja sfan5: Those are acronyms though, not seperate words.
19:13 sfan5 but it's also called ActiveBlockModifier in the code
19:14 Megaf hm. some people use steel doors on my server for the very same reason they dont make any sound
19:14 Megaf I mean, let me rephrase that
19:15 Megaf In my server, some people do use steel doors, for the very reason that they don't produce any sound.
19:15 Megaf Better
19:15 sfan5 ShadowNinja: filenames are basically the class names but lowercase, why break the pattern?
19:15 sofar huh, they don't make sounds?
19:15 sfan5 also
19:15 sofar I'd say that'd be a bug
19:15 sfan5 ShadowNinja: the serialization test should serialize and deserialize, testing for an expected result is not the right way to test serialization imo
19:16 ShadowNinja sfan5: Files are named acording to a low of different conventions.  See, eg, guiChatConsole.
19:17 ShadowNinja lot*
19:17 sfan5 small inconsistences don't mean that you can create new ones
19:17 sfan5 just keep the name
19:17 ShadowNinja I remember we decided on lowercase_underscore a while ago with seperated words.
19:17 sfan5 i don't get what's better about a different name thats inconsistent with others
19:17 sfan5 when?
19:19 ShadowNinja sfan5: Months ago.  I don't remember the exact day.
19:19 paramat also game#895 needs one +1
19:19 ShadowBot https://github.com/minetes​t/minetest_game/issues/895 -- Add steel sign + Update wooden sign texture by kilbith
19:20 sfan5 anyway
19:20 sfan5 the rest of the cleanup is fine
19:20 sfan5 paramat: +1 for game895
19:21 paramat ok
19:21 sofar nobody wants to review sounds?
19:21 sfan5 i would have to stop listening to music for that
19:22 paramat lol
19:22 sofar hell, you can even click the files in your browser
19:22 sofar and firefox plays them
19:22 sofar just "view raw"
19:22 paramat yes
19:23 sfan5 ogg doesn't play in chromium
19:23 ShadowNinja sfan5: Do you consider it acceptable if I leave the rename in?
19:23 sfan5 well uhh
19:23 sfan5 can you just leave it out?
19:23 ShadowNinja Maybe.
19:24 ShadowNinja Eh, I'll have to edit the commit though.
19:24 sfan5 won't you need to edit it anyway?
19:25 ShadowNinja No.  The commit also moves to to util, so I'll have to manually edit that commit.
19:27 ShadowNinja I don't think the name matters that much, and I prefer it with the underscre, so I'd rather just leave it.
19:28 sfan5 I prefer it without the underscore, so I'd rather just leave it (as it was before).
19:31 paramat game#517 is rebased and updated, any comments?
19:31 ShadowBot https://github.com/minetes​t/minetest_game/issues/517 -- Forbidden recursive destruct for beds' parts by LeMagnesium
19:39 fireglow joined #minetest-dev
19:51 misprint joined #minetest-dev
19:57 Icedream joined #minetest-dev
20:12 twoelk joined #minetest-dev
20:13 fireglow joined #minetest-dev
20:33 rubenwardy joined #minetest-dev
20:41 Megaf_ joined #minetest-dev
21:11 casimir joined #minetest-dev
21:29 kaeza joined #minetest-dev
21:36 mangeurdenuage joined #minetest-dev
21:37 paramat left #minetest-dev
21:57 Dragonop joined #minetest-dev
22:09 kaeza #3285
22:09 ShadowBot https://github.com/minetest/minetest/issues/3285 -- Links to documentation within example.conf?
22:10 kaeza eh
22:10 kaeza #3825
22:10 ShadowBot https://github.com/minetest/minetest/issues/3825 -- Allow selecting screenshot format. by kaeza
22:10 kaeza review pls
22:15 ShadowNinja kaeza: gettext dummy file needs update.
22:15 ShadowNinja Also, seems odd to accept a '.' before the name.
22:16 ShadowNinja Period in commit message should be removed too.  Otherwise LGTM.
22:17 kaeza might be able to add a "screenshot_param" setting (for e.g. JPEG quality)
22:17 kaeza or is it overkill?
22:18 kaeza also, it's annoying that adding/editing a setting requires editing 5 or 6 files...
22:19 ShadowNinja JPEG quality would be nice to have.
22:26 sofar but if png is the default already
22:26 sofar then it's redundant, by a margin
22:28 kaeza sofar, not sure what you mean
22:29 sofar png is lossless. if someone really wants a low quality jpg, then they can convert the file manually
22:30 kaeza how about dropping the "manually" part entirely so users that don't care about lossy compression can just save as JPG and be done with it?
22:31 kaeza it's trivial code for the convenience
22:32 kaeza feel free to :-1: though
22:33 sofar if you really want to enhance the screenshot capability, have it automatically upload to imgur.com :)
22:36 kaeza don't give me ideas
22:36 sofar and then xdg-open a browser with the link to it
22:38 rubenwardy it's minimal code, so +1
22:44 nolsen joined #minetest-dev
23:14 loggingbot_ joined #minetest-dev
23:14 Topic for #minetest-dev is now Minetest core development and maintenance. Last release: 0.4.13, Aug 20 2015. Chit-chat goes to #minetest. Consider this instead of /msg celeron55. http://irc.minetest.ru/minetest-dev/ http://dev.minetest.net/
23:19 Dragonop joined #minetest-dev
23:21 twoelk joined #minetest-dev
23:28 kaeza hmm... src/setting_translation_file.cpp references builtin/mainmenu/tab_settings.lua, when it should have said builtin/mainmenu/dlg_advanced_settings.lua ...
23:29 kaeza soo... is `builtin/settingtypes.txt` the "gettext dummy file"?
23:39 kaeza meh. I'll just shelve this shit
23:48 kaeza joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext