Minetest logo

IRC log for #minetest-dev, 2015-09-04

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:01 RealBadAngel joined #minetest-dev
00:10 rickmcfarley joined #minetest-dev
00:10 Siva_Machina joined #minetest-dev
00:23 domtron_ joined #minetest-dev
00:47 kaeza joined #minetest-dev
01:04 Lunatrius joined #minetest-dev
01:12 nanepiwo joined #minetest-dev
01:13 nanepiwo .minetest/games/nane-game/m​ods/default/mapgen.lua:641: attempt to call field 'get_mapgen_params' (a nil value)
01:13 nanepiwo help pls?
01:15 nanepiwo should i edit that line to check if its nil?
01:18 RealBadAngel i dont think we know your code
01:19 RealBadAngel do you have any repo with it?
01:29 nanepiwo http://pastie.org/private/g1rfcfr0ssneg649wrghq
01:29 nanepiwo why is there no final else?
01:35 RealBadAngel nanepiwo, that is complete statement
01:36 nanepiwo yes, but what if mg_params is nil?
01:36 RealBadAngel then put there check for nil
01:37 nanepiwo if blah = nil then break end ?
01:37 nanepiwo * ==
01:37 RealBadAngel something like that
01:37 nanepiwo but then won't my game be broken?
01:38 RealBadAngel sometimes its wise to check if something is not nil in the first place
01:38 nanepiwo ok
01:40 RealBadAngel but here you seems to be calling unknow function
01:40 RealBadAngel get_mapgen_params
01:44 RealBadAngel which line is #641 for you?
01:44 ShadowBot https://github.com/minetest/minetest/issues/641 -- Add special group hanging_node by bas080
01:45 RealBadAngel ShadowBot, very funny :P
01:45 domtron joined #minetest-dev
01:46 damiel joined #minetest-dev
01:48 DFeniks joined #minetest-dev
01:55 CraigyDavi joined #minetest-dev
01:57 nanepiwo I updated mt game to latest git and same error, pointing to https://github.com/minetest/minetest_game/​blob/master/mods/default/mapgen.lua#L1106
01:58 nanepiwo weird thing is, im only having this problem since I ran software updater...
01:59 nanepiwo I think I used to have installed minetest by ppa, I'll try uninstalling that
02:20 Zeitgeist_ joined #minetest-dev
03:08 domtron joined #minetest-dev
03:31 Siva joined #minetest-dev
03:35 T4im joined #minetest-dev
03:55 waressearcher2 will you add enchanting stuff ? and a hearts/armor/hunger/experience bar ?
03:55 waressearcher2 villages ?
03:56 waressearcher2 abandoned castles ?
03:56 waressearcher2 or strongholds
04:28 Anchakor joined #minetest-dev
04:34 Sokomine my mg_villages mod adds villages. maybe you'll enjoy the adventuretest game; it adds what you asked for. it is more about surviving than actual building
04:39 waressearcher2 Sokomine: how long it took you to create that mod ?
04:39 waressearcher2 Sokomine: and what was the most difficult part ?
04:42 Sokomine hm. hard to tell what was the most difficult part...hmmm. understanding enough about mapgen? height adjustment and terrain blending where pretty tricky
04:44 leat joined #minetest-dev
04:45 waressearcher2 Sokomine: so to make mods one should invest quite some time to learn some stuff ?
04:50 hmmmm this is off-topic discussion.  should be in #minetest.
04:55 T4im who maintains the hosting? wikis accessed with TLS throw a 403
04:55 kaeza joined #minetest-dev
05:03 sofar anyone know how I do a default const Settings & in a .h?
05:03 sofar exceeded my C++ skills
05:03 sofar https://github.com/minetest/minetes​t/pull/2198#issuecomment-137649395
05:10 hmmmm oh sofar please try to keep your lines under 80 columns
05:10 sofar hmmmm: I will once it compiles
05:10 hmmmm it's okay if it goes a little bit over, but absolutely nothing more than 90
05:11 sofar chill, I know
05:11 sofar fixing the style up once I get it to work
05:13 sofar that or fall asleep since I've been awake for too many hours
05:13 hmmmm weird
05:13 T4im sleep deprivation and coding might not be the best combination :)
05:13 hmmmm that ought to work
05:14 hmmmm try changing the = "" to = std::string()?
05:15 sofar Settings is a struct g_settings, not a std::string
05:15 hmmmm what?
05:16 sofar euh, my paste was cut off there
05:16 sofar error: default argument missing for parameter 3 of 'std::map<std::basic_string<char>, ModSpec> getModsInPath(std::string, bool, const Settings&)'
05:16 sofar const Settings& isn't a std::string
05:16 hmmmm of course not
05:16 hmmmm i don't see you passing any Settings &s to getModsInPaths
05:17 sofar uncommitted, obviously
05:17 sofar since I can't even get it to compile
05:17 hmmmm erm
05:17 hmmmm I can't really help you if I don't see the code :)
05:17 sofar https://gist.github.com/sofar/ecc412c00903bca43405
05:18 hmmmm of course
05:19 hmmmm optional parameters must all be after required parameters in function declarations
05:19 sofar yep, I get *why* it fails
05:19 hmmmm how else would the compiler possibly be able to disambiguate your code?
05:19 sofar not how to fix it
05:19 hmmmm how to fix:
05:19 hmmmm swap the two parameters
05:19 hmmmm but nevermind that
05:19 sofar well, I understand how to fix it, just not what the exact fix would look like :^)
05:20 hmmmm so correct me if i'm wrong here but
05:20 sofar swapping may not work, I think it gets called with only 1 parameter as well
05:20 hmmmm worldpath/worldmt_settings is only required by getModsInPath if part_of_modpack == true, right?
05:23 sofar looks like it
05:24 hmmmm so then that's bad design
05:24 sofar I'm not exactly thrilled working on this patch set
05:24 hmmmm if you have some custom action in a function that depends on some kind of custom data structure, you don't have two optional parameters
05:24 hmmmm a boolean saying "yes, do this optional thing" and then that additional data describing it
05:25 hmmmm instead, use pointers
05:25 hmmmm I know it's not "The C++ Way" but fuck the C++ way
05:25 hmmmm pointers are extremely useful and you shouldn't be afraid to use them
05:25 sofar I'm a pure C guy...
05:25 hmmmm remove the boolean, make the Settings & into a const Settings *
05:26 hmmmm if worldmt_settings == NULL then it's not part of a modpath
05:26 hmmmm if non null, then it is, and there's your worldmt settings
05:26 sofar hmm yes, that I like
05:27 sofar aight, will look at that later, thanks
05:27 sofar I should probably not code anymore at this time ;^)
05:30 Lunatrius joined #minetest-dev
05:47 Hunterz joined #minetest-dev
05:49 nrzkt joined #minetest-dev
05:51 nrzkt joined #minetest-dev
05:53 nrzkt ~tell est31; seems that the 1.8.2-2 on Archlinux fix the crashes. 0.4.12 from repo works, compiled minetest & minetestserver works
05:53 ShadowBot nrzkt: O.K.
05:54 leat joined #minetest-dev
07:08 Darcidride joined #minetest-dev
07:28 Amaz joined #minetest-dev
07:39 julienrat joined #minetest-dev
07:39 julienrat left #minetest-dev
07:48 leat joined #minetest-dev
07:57 nrzkt joined #minetest-dev
08:00 Yepoleb_ joined #minetest-dev
08:08 diemartin joined #minetest-dev
08:26 leat joined #minetest-dev
09:01 Zeitgeist_ joined #minetest-dev
09:26 leat joined #minetest-dev
09:39 leat joined #minetest-dev
09:42 H-H-H joined #minetest-dev
09:44 rubenwardy joined #minetest-dev
09:49 Zeitgeist_ joined #minetest-dev
09:50 Player_2 joined #minetest-dev
10:42 Megaf svenstaro: [04.09.15-06:53:52] <nrzkt> ~tell est31; seems that the 1.8.2-2 on Archlinux fix the crashes. 0.4.12 from repo works, compiled minetest & minetestserver works
10:42 Megaf Thanks a million for your fix. So, what was wrong?
10:48 leat joined #minetest-dev
11:21 Calinou joined #minetest-dev
11:43 H-H-H joined #minetest-dev
12:04 nrzkt Megaf, which fix ?
12:09 kilbith joined #minetest-dev
12:16 leat joined #minetest-dev
12:16 Megaf nrzkt: it wasnt fixed?
12:16 Megaf you said it was working after smething he did
12:19 nrzkt it's working for me as it seems :)
12:22 Megaf nrzkt: you could have tried clang too
12:25 nrzkt i always compile with clang.
12:25 nrzkt the problem is not related to compiler.
12:49 leat joined #minetest-dev
12:51 kilbith joined #minetest-dev
12:59 leat joined #minetest-dev
13:13 Warr1024 joined #minetest-dev
13:50 leat joined #minetest-dev
14:10 leat joined #minetest-dev
14:15 hmmmm joined #minetest-dev
14:26 Siva joined #minetest-dev
14:40 leat joined #minetest-dev
15:01 nore joined #minetest-dev
15:41 leat joined #minetest-dev
15:42 Siva joined #minetest-dev
15:42 est31 joined #minetest-dev
15:43 est31 nrzkt, it might be related to compiler
15:43 est31 nrzkt, from how I see the bug:
15:43 nrzkt clang 3.6 : crash gcc 5.2 : crash.
15:43 nrzkt yes it's related to compiler.
15:43 nrzkt gg
15:43 est31 1. there is something very poisonous in the irrlicht headers
15:44 nrzkt it's definitively not related to minetest compiler, maybe irrlicht but not mt
15:44 est31 2. this "poison" creates a crash whenever you start a binary that has included these headers
15:45 est31 3. the crash can either happen if the irrlicht binary was compiled with gcc 5.2 or if the minetest binary was compiled with gcc 5.2
15:45 est31 4. as it also happens if minetest gets compiled with gcc, its a bug in the irrlicht headers
15:46 waressearcher2 why not to use version of irrlicht that just works, do you really need to upgrade minetest to the latest irrlicht ?
15:46 waressearcher2 now you spend time figuring out why its incompatible with new irrlicht
15:46 est31 well, we are developers, we have to care
15:47 est31 and some other users do have actual problems with this bug: https://github.com/minetest/minetest​/issues/3130#issuecomment-137659113
15:47 waressearcher2 I mean take other games if some company choose "unreal engine 3" they stick with it even if year later there is "unreal engine 3.5" released
15:48 waressearcher2 they continue development for years even if new version of engine being developed
15:48 est31 minetest doesnt work like a classical game
15:48 waressearcher2 they continue development for years with the same engine version
15:48 est31 also 1.8.2 is a bugfix release
15:48 est31 so it shouldnt mean much
15:49 est31 but there is still a crash
15:49 waressearcher2 but why not to just concentrate on minetest all the time and only once say a year or couple years make upgrade to newer version of irrlicht ?
15:50 est31 well, irrlicht was last updated one year ago
15:50 waressearcher2 wouldn't it be more effective way ?
16:00 luizrpgluiz joined #minetest-dev
16:02 luizrpgluiz joined #minetest-dev
16:08 Hunterz joined #minetest-dev
16:17 CraigyDavi joined #minetest-dev
16:35 rubenwardy joined #minetest-dev
16:41 waressearcher2 I'm not a developer so you know better
16:51 luizrpgluiz waressearcher2: i am a gamer
16:51 luizrpgluiz waressearcher2: i am a simple gamer
16:58 Calinou waressearcher2, we are not a proprietary AAA game :)
16:58 Calinou Irrlicht is dated enough, let's not make it more dated than it is
16:59 Megaf +1
17:32 Zeitgeist_ joined #minetest-dev
17:48 Gael-de-Sailly joined #minetest-dev
18:01 luizrpgluiz left #minetest-dev
18:07 technics joined #minetest-dev
18:40 FR^2 joined #minetest-dev
18:40 rickmcfarley joined #minetest-dev
18:56 Darcidride joined #minetest-dev
19:06 MinetestForFun joined #minetest-dev
19:11 leat joined #minetest-dev
19:18 Gael-de-Sailly joined #minetest-dev
19:21 casimir joined #minetest-dev
19:32 paramat joined #minetest-dev
19:39 paramat hi sfan5 please can you review game#651 ? fire mod is a mess currently needs improvement
19:39 ShadowBot https://github.com/minetes​t/minetest_game/issues/651 -- Fire: Move flame extinguishing to separate faster ABM by paramat
19:40 sfan5 sure
19:41 sfan5 paramat: looks good
19:42 paramat thanks
19:47 neoascetic joined #minetest-dev
19:48 nrzkt joined #minetest-dev
19:52 neoascetic Someone, #3117... please...
19:52 ShadowBot https://github.com/minetest/minetest/issues/3117 -- Fixes building on OSX caused by e4bff8b (refs #2613) by neoascetic
20:01 paramat improvements to waving plants and leaves #3146 tests welcome
20:01 ShadowBot https://github.com/minetest/minetest/issues/3146 -- Shaders: Use triple-frequency waving for leaves and plants by paramat
20:05 H-H-H joined #minetest-dev
20:09 OldCoder joined #minetest-dev
20:10 VanessaE paramat: lgtm.  +1
20:10 paramat thanks
20:10 VanessaE one note:
20:10 VanessaE apples should be made to move around somehow.
20:11 VanessaE but that's out of scope for this PR
20:11 paramat ah yes
20:11 rickmcfarley joined #minetest-dev
20:12 paramat except when they're placed on ground =S
20:12 VanessaE agreed.
20:12 paramat also snow doesn't wave
20:12 VanessaE (and if possible, it should be possible for dreambuilder's meshnode apples to move around too)
20:12 VanessaE oh yes, I didn't think to look at snow
20:12 VanessaE good call
20:12 VanessaE waterlilies too
20:12 VanessaE they need to move up/down with the water motion
20:12 paramat might need a second waving snow
20:12 paramat oh crumbs
20:13 VanessaE sounds like this needs at least two more waving shaders that can be called upon by such nodes.
20:14 VanessaE (inb4 RBA says this is impossible ;) )
20:14 VanessaE anyway, within the intended behavior of the shaders, your improvements look goodf.
20:14 VanessaE -fd
20:14 * VanessaE screams internally
20:14 younishd_ joined #minetest-dev
20:16 johnnyjoy joined #minetest-dev
20:43 paramat left #minetest-dev
20:56 paramat joined #minetest-dev
21:02 leat joined #minetest-dev
21:12 nanepiwo joined #minetest-dev
21:15 paramat left #minetest-dev
21:58 paramat joined #minetest-dev
22:03 leat joined #minetest-dev
22:03 paramat now merging game#651
22:03 ShadowBot https://github.com/minetes​t/minetest_game/issues/651 -- Fire: Move flame extinguishing to separate faster ABM by paramat
22:11 paramat complete
22:13 VanessaE G*d damn it, paramat... stop improving mt_game.  you keep giving me reasons to update dreambuilder's base code again, and I JUST did it after the 0.4.13 release ;)
22:33 Siva joined #minetest-dev
22:39 paramat left #minetest-dev
22:44 Samson1 joined #minetest-dev
23:00 est31 joined #minetest-dev
23:04 rickmcfarley joined #minetest-dev
23:10 Samson1 joined #minetest-dev
23:14 damiel joined #minetest-dev
23:21 Zeitgeist_ joined #minetest-dev
23:40 damiel joined #minetest-dev
23:43 leat joined #minetest-dev
23:47 Zeitgeist_ joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext