| Time |
Nick |
Message |
| 00:00 |
|
shadowzone joined #minetest-dev |
| 00:03 |
|
DFeniks joined #minetest-dev |
| 00:21 |
|
DFeniks joined #minetest-dev |
| 01:00 |
|
zat joined #minetest-dev |
| 01:10 |
|
Warr1024 joined #minetest-dev |
| 01:13 |
|
domtron joined #minetest-dev |
| 01:39 |
|
Wayward_One joined #minetest-dev |
| 01:42 |
|
domtron joined #minetest-dev |
| 01:56 |
|
domtron joined #minetest-dev |
| 02:10 |
|
domtron joined #minetest-dev |
| 02:28 |
|
est31 joined #minetest-dev |
| 03:27 |
|
paramat joined #minetest-dev |
| 03:28 |
paramat |
now pushing #2434 |
| 03:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/2434 -- Biome API: Enable decorations placed on water. Add schematic decoration force place flag by paramat |
| 03:40 |
paramat |
done =) |
| 03:47 |
VanessaE |
what |
| 03:47 |
VanessaE |
what's next in the pipe? :) |
| 03:48 |
paramat |
there's so much to do |
| 03:51 |
paramat |
next: improve mgv7 terrain, finish biomes for v5/v7, make floaty dungeons optional |
| 03:52 |
est31 |
can anyone help me with #2447 ? |
| 03:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/2447 -- Add remote inventory inspection feature by est31 |
| 03:52 |
est31 |
I think i did everything right, but still it doesnt work |
| 03:53 |
paramat |
i'm no good with this deep technical shizzle |
| 04:06 |
paramat |
using the 'force placement' flag, "air" nodes will be force placed, so to prevent a schematic's node being force placed it must be "ignore" or have a probability of 0 |
| 04:06 |
est31 |
:( |
| 04:09 |
paramat |
so for a schematic boat in the water, the air within the hull must be (and is) force placed, the nodes outside the hull must be "ignore" or "air" with probability 0 |
| 04:13 |
|
Zeno` joined #minetest-dev |
| 04:31 |
est31 |
hi Zeno` |
| 04:32 |
est31 |
commented on that android issue |
| 04:41 |
|
domtron_ joined #minetest-dev |
| 04:41 |
|
Hunterz joined #minetest-dev |
| 04:42 |
|
Hunterz1 joined #minetest-dev |
| 04:43 |
Zeno` |
est31, thanks :) |
| 05:23 |
|
Miner_48er joined #minetest-dev |
| 05:23 |
ShadowNinja |
Pushing #2395 in a moment... |
| 05:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/2395 -- Clean up database API and save the local map on an interval by ShadowNinja |
| 05:24 |
ShadowNinja |
( Zeno`, paramat ^ ) |
| 05:28 |
paramat |
i looked but beyond my understanding =) |
| 05:33 |
Zeno` |
can the diff be more misleading... https://github.com/ShadowNinja/minetest/commit/708337dfc2b3871dc6de983e781e4a4a60a1881d#diff-d3d693f90e87270054ddb5c073c76202R52 |
| 05:33 |
Zeno` |
anyway without testing it looks fine |
| 05:35 |
ShadowNinja |
Zeno`: Hehe, blame Git, or GitHub. |
| 05:35 |
Zeno` |
yeah, I know but I was wondering wtf was going on there for a sec :) |
| 05:36 |
ShadowNinja |
Zeno`: O.K. with this now?: https://github.com/minetest/minetest/pull/2404#discussion_r25725499 |
| 05:39 |
Zeno` |
yes, I'm ok with both of the PRs |
| 05:42 |
paramat |
so here's a possible simple fix for floating dungeons, just needs lots of testing https://github.com/paramat/minetest/commits/floatydun |
| 05:47 |
est31 |
Zeno`, about your comment to #2445 : the code finds out whether you are pressing keys that are saved as "command keys" |
| 05:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/2445 -- Keyboard shortcuts for chat commands: adds user interface and code to... by spillz |
| 05:47 |
Zeno` |
est31, pfft.. as if |
| 05:48 |
est31 |
but it really could be more compact |
| 05:48 |
Zeno` |
est31, but only when client is receiving the server media? |
| 05:48 |
Zeno` |
That's not particularly useful is it? |
| 05:49 |
* Zeno` |
looks again |
| 05:49 |
est31 |
ah, that, yes it should be somwhere else |
| 05:49 |
Zeno` |
yeah so my memory was correct :) even if it's moved I think it's a mess |
| 05:49 |
est31 |
I haven't dived deeply into code yet |
| 05:49 |
est31 |
only did format comments |
| 05:50 |
est31 |
there is this huge block that does nothing else than checking the control keys |
| 05:50 |
est31 |
It should be done using some boolean algebra |
| 05:50 |
est31 |
and the coding style bloats it even more |
| 05:51 |
Zeno` |
I knew/know what it was trying to do by the way; I just want(ed) spillz to explain :) |
| 05:52 |
Zeno` |
Yeah, I'm not sure about it. It's certainly not ok to merge right now and even when it's "fixed" I have some reservations |
| 05:52 |
est31 |
why? |
| 05:52 |
est31 |
you dont like the feature itself? |
| 05:53 |
Zeno` |
If it's optimised it might be ok |
| 05:53 |
Zeno` |
I like the idea of the feature |
| 05:53 |
Zeno` |
sort of |
| 05:53 |
Zeno` |
:) |
| 05:54 |
est31 |
it should be moved to guikeychangemenu.cpp |
| 05:54 |
est31 |
thats where all key events are handled |
| 05:55 |
est31 |
or no |
| 05:55 |
est31 |
wrong |
| 05:55 |
est31 |
Game::processKeyboardInput thats where it should be |
| 05:56 |
Zeno` |
I know where it should be, I wrote the functions :) |
| 05:56 |
Zeno` |
(not the content of the functions necessarily... the functions... it used to be all in-line) |
| 05:56 |
est31 |
lol :D |
| 05:57 |
Zeno` |
Anyway, I guess if it's cleaned up it would be ok |
| 05:57 |
Zeno` |
I mean how big can the loop be? :3 |
| 05:57 |
* Zeno` |
counts keys on keyboard |
| 06:04 |
VanessaE |
1..2..skip a few...103..104... |
| 06:11 |
est31 |
wow someone is a bit annoyed... |
| 06:11 |
est31 |
#2445 |
| 06:11 |
ShadowBot |
https://github.com/minetest/minetest/issues/2445 -- Keyboard shortcuts for chat commands: adds user interface and code to... by spillz |
| 06:13 |
|
Megaf joined #minetest-dev |
| 06:27 |
paramat |
#2448 i'll test this over the next day or so |
| 06:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/2448 -- Dungeongen: Optionally set ignore to be untouchable to disable floating dungeons by paramat |
| 06:29 |
Zeno` |
heh |
| 06:50 |
|
BlockMen joined #minetest-dev |
| 06:50 |
|
nrzkt joined #minetest-dev |
| 06:50 |
nrzkt |
Hey :D good job ShadowNinja & paramat :) |
| 06:52 |
nrzkt |
next step ShadowNinja: Async writes on database :) |
| 06:55 |
paramat |
O/ |
| 06:56 |
|
Hunterz joined #minetest-dev |
| 07:00 |
BlockMen |
paramat, do you plan to readd shoe definitions? |
| 07:00 |
BlockMen |
+r |
| 07:04 |
paramat |
hehe |
| 07:04 |
paramat |
no |
| 07:06 |
paramat |
but now (as originally) you can define the shore as a separate biome, with it's own top and filler nodes |
| 07:07 |
|
est31_ joined #minetest-dev |
| 07:09 |
BlockMen |
ah, ok. as long i can define shores idc which way around :) |
| 07:16 |
paramat |
it's now as originally except dust_water is replaced by water_top with it's own depth (for icesheet), and biome is recalculated at every upper surface in a column, for unlimited levels of biomes within a mapchunk (essential to cope with overhangs and floaty bits in mgv5/v7) |
| 07:23 |
|
paramat left #minetest-dev |
| 07:50 |
|
kilbith joined #minetest-dev |
| 08:09 |
est31 |
sfan5, are you there? |
| 08:35 |
|
ImQ009 joined #minetest-dev |
| 08:50 |
|
kilbith joined #minetest-dev |
| 09:01 |
Zeno` |
not sure what github's problem with #2362 is (I rebased it) |
| 09:01 |
ShadowBot |
https://github.com/minetest/minetest/issues/2362 -- Begin assert fix by Zeno- |
| 09:14 |
|
nrzkt joined #minetest-dev |
| 09:22 |
Zeno` |
err, it's ok. I'd missed a merged commit |
| 09:23 |
Zeno` |
I think I got all the replacements right :3 |
| 09:24 |
Zeno` |
Hi nrzkt |
| 09:24 |
Zeno` |
nrzkt, you may do the thorough check :P I'm going to rest for a bit. #2362 |
| 09:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/2362 -- Begin assert fix by Zeno- |
| 09:38 |
ShadowNinja |
nrzkt: https://github.com/ShadowNinja/minetest/commits/PostgreSQL |
| 09:39 |
ShadowNinja |
nrzkt: And why did you close #1063? |
| 09:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/1063 -- Adjustable Day/Night Ratio |
| 09:41 |
ShadowNinja |
nrzkt, Zeno`: Any ideas as to why this is failing like this for Clang?: https://travis-ci.org/minetest/minetest/jobs/53143508 (relevant PR: https://github.com/minetest/minetest/pull/2402) I don't know what I've touched that would cause this. |
| 09:46 |
BlockMen |
ShadowNinja, any comment before i push https://github.com/BlockMen/minetest_game/commit/2a6050e552be1d74097fb2678591aff47ae67c78 ? |
| 09:50 |
|
FR^2 joined #minetest-dev |
| 09:54 |
ShadowNinja |
BlockMen: I'd name it "beds.enable_respawn" or "beds.enable_spawn", but that doesn't really matter. |
| 09:54 |
nrzkt |
Zeno`, ShadowNinja: sorry i was working on my elasticsearch at work. |
| 09:54 |
ShadowNinja |
Otherwise, LGTM. |
| 09:55 |
nrzkt |
ShadowNinja, i can't remember, maybe because we already have a day night ratio in core, no ? |
| 09:56 |
ShadowNinja |
nrzkt: Nope. There's a day/night light ratio, but that's different. |
| 09:56 |
nrzkt |
i don't know what is different in fact :) |
| 09:56 |
BlockMen |
ShadowNinja, you have a special reason in mind to use a global var for that? |
| 09:56 |
ShadowNinja |
BlockMen: Oh, please check that failing build if you think you can help. :-) |
| 09:57 |
ShadowNinja |
BlockMen: I mean that would be the setting name. |
| 09:57 |
ShadowNinja |
Eg, the irc mod uses irc.* |
| 09:58 |
nrzkt |
ShadowNinja: seems good for me, but i think we must rework on save command to improve the perfs |
| 09:58 |
ShadowNinja |
nrzkt: day/night LENGTH ratio Vs. day/night LIGHT ratio. |
| 09:58 |
nrzkt |
oh, i misread then |
| 09:59 |
ShadowNinja |
Anyway, gotta go to bed now, night! |
| 10:00 |
nrzkt |
good night :) |
| 10:00 |
nrzkt |
Zeno`: you are on a good way :) |
| 10:17 |
Zeno` |
hmm? |
| 10:18 |
Zeno` |
ugh |
| 10:19 |
Zeno` |
I have two copies of client.cpp :/ |
| 10:20 |
Zeno` |
err |
| 10:20 |
Zeno` |
that's a bit confusing |
| 10:26 |
|
est31 joined #minetest-dev |
| 10:44 |
est31 |
I know what SN's clang problems are. this line explains it all: https://github.com/minetest/minetest/blob/70074800a207974a0c1383275186cefe6955f297/src/tool.h#L61 |
| 10:44 |
est31 |
:D |
| 10:45 |
Kray |
idgi |
| 10:47 |
BlockMen |
est31, indeed. good catch :D |
| 11:41 |
|
kilbith joined #minetest-dev |
| 12:25 |
|
moala joined #minetest-dev |
| 12:45 |
|
MinetestForFun joined #minetest-dev |
| 12:57 |
|
ElectronLibre joined #minetest-dev |
| 13:16 |
|
SopaXorzTaker joined #minetest-dev |
| 13:34 |
|
Warr1024 joined #minetest-dev |
| 13:57 |
|
Andrei___ joined #minetest-dev |
| 13:57 |
|
monty joined #minetest-dev |
| 13:59 |
|
Andreia_ joined #minetest-dev |
| 14:02 |
|
shadowzone joined #minetest-dev |
| 14:10 |
|
ElectronLibre joined #minetest-dev |
| 14:23 |
|
Lunatrius joined #minetest-dev |
| 14:32 |
|
nrzkt joined #minetest-dev |
| 14:35 |
|
Jordach joined #minetest-dev |
| 14:52 |
|
CraigyDavi joined #minetest-dev |
| 15:22 |
est31 |
damn I can't reproduce the issue travis has with shadowninja's PR |
| 15:22 |
est31 |
I build the code with clang, and everything works |
| 15:22 |
est31 |
this doesnt mean it shouldnt be fixed |
| 15:28 |
|
selat joined #minetest-dev |
| 15:33 |
|
SopaXorzTaker joined #minetest-dev |
| 15:40 |
|
kilbith joined #minetest-dev |
| 15:40 |
|
shadowzone joined #minetest-dev |
| 15:42 |
est31 |
I have a theory, lets wait whether it confirms... |
| 16:02 |
|
BlockMen joined #minetest-dev |
| 16:17 |
|
spillz joined #minetest-dev |
| 16:18 |
|
spillz1 joined #minetest-dev |
| 16:24 |
spillz1 |
Re #2445, let me make clear the reason I closed it. It speaks volumes about the childish community here. |
| 16:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/2445 -- Keyboard shortcuts for chat commands: adds user interface and code to... by spillz |
| 16:27 |
spillz1 |
Instead of pointing out that I'd fckd up the patch and expressing the reservations about logic/design THAT WERE MADE HERE ON IRC INSTEAD, the comments I received on the PR were nitpicks about style and then the socratic "what's all this do?" |
| 16:29 |
spillz1 |
This is all the more galling because as the IRC records show, zeno clearly knew what it did and clearly knew it wouldn't work because zeno was the one who made the incompatible changes. |
| 16:30 |
est31 |
I agree that there were better ways to make a point than the way Zeno did. |
| 16:31 |
est31 |
and about why I only did nitpicks, is because I only read the format and did no serious "deeper" check. |
| 16:35 |
spillz1 |
I understand, but bear in mind how a pull requester will interpret them. One way to do that would be to preface your comments (e.g. "I don't have time to look deeply yet, but here are a few style issues"). But it was really zenos comments the put me over the edge. :) |
| 16:37 |
|
Dartmouth joined #minetest-dev |
| 16:38 |
|
ImQ009 joined #minetest-dev |
| 16:43 |
est31 |
your PR is very large and I know it is easy to get demotivated fast |
| 16:43 |
spillz1 |
Anyway, I moved the screwed up bit to the correct place in my branch and it seems to be working. RE replacing the big block testing modifiers with boolean algebra, whatever makes you guys happy, but I won't be the one making that change. |
| 16:43 |
est31 |
spillz1, I like your feature and it would be really good if your PR could be merged |
| 16:45 |
spillz1 |
It's big but not all that complicated, and most of it is working with the fiddly widget code. BTW, the spacing in the dialog is now screwed up a bit because of whatever changes were made to the dialog after I first made the patch. |
| 16:52 |
|
ElectronLibre joined #minetest-dev |
| 16:56 |
est31 |
spillz1, minetest is right now in a very merge-friendly phase |
| 16:57 |
est31 |
so if you have changes you want to get merged, they don't get rejected "because we don't like to" |
| 17:01 |
|
spillz1 left #minetest-dev |
| 17:07 |
VanessaE |
jeez |
| 17:09 |
|
SopaXorzTaker joined #minetest-dev |
| 17:20 |
|
Hunterz joined #minetest-dev |
| 17:43 |
|
gravgun joined #minetest-dev |
| 17:50 |
|
Jordach_ joined #minetest-dev |
| 17:51 |
|
est31 joined #minetest-dev |
| 17:55 |
|
Krock joined #minetest-dev |
| 18:11 |
ShadowNinja |
BlockMen: Your bed patch has a bug... It won't work. `setting_getbool() or true` is always true. You have to check specifically for nil. |
| 18:12 |
ShadowNinja |
(that's what you get for asking me to review it just before I go to bed :-P) |
| 18:13 |
est31 |
ShadowNinja, seen my comments on your build system patch? |
| 18:26 |
BlockMen |
ShadowNinja, ups, right |
| 18:26 |
BlockMen |
and didnt know you were heading bed before i asked :P |
| 18:26 |
ShadowNinja |
est31: Yep, thanks for the help! |
| 18:30 |
BlockMen |
ShadowNinja, fixed |
| 18:39 |
|
Lunatrius joined #minetest-dev |
| 19:19 |
|
ImQ009 joined #minetest-dev |
| 19:21 |
|
ImQ009_ joined #minetest-dev |
| 19:35 |
|
kilbith joined #minetest-dev |
| 19:56 |
|
SudoAptGetPlay joined #minetest-dev |
| 20:28 |
|
BlockMen left #minetest-dev |
| 20:39 |
Krock |
Quick question: Is it possible with the current Irrlicht functions to create a feature like #2450 ? |
| 20:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/2450 -- Eye-like brightness |
| 20:40 |
Krock |
It would require a "brightness map" of the current view |
| 20:56 |
|
PilzAdam joined #minetest-dev |
| 21:19 |
|
fz72 joined #minetest-dev |
| 21:23 |
|
ElectronLibre joined #minetest-dev |
| 21:32 |
|
b-lenos joined #minetest-dev |
| 21:42 |
|
est31 joined #minetest-dev |
| 21:45 |
|
harrison joined #minetest-dev |
| 21:46 |
|
b-lenos left #minetest-dev |
| 21:46 |
|
b-lenos joined #minetest-dev |
| 22:13 |
|
Miner_48er joined #minetest-dev |
| 22:15 |
|
ElectronLibre left #minetest-dev |
| 22:18 |
|
roniz joined #minetest-dev |
| 22:33 |
|
est31 joined #minetest-dev |
| 22:33 |
|
est31 joined #minetest-dev |
| 22:45 |
|
b-lenos joined #minetest-dev |
| 22:56 |
|
AnotherBrick joined #minetest-dev |
| 23:25 |
|
chchjesus joined #minetest-dev |
