Minetest logo

IRC log for #minetest-dev, 2015-02-18

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:02 shadowzone joined #minetest-dev
00:02 Megal joined #minetest-dev
00:15 Megal_ joined #minetest-dev
00:16 Megal__ joined #minetest-dev
00:25 Wayward_One joined #minetest-dev
01:32 shadowzone joined #minetest-dev
02:42 Megal joined #minetest-dev
03:18 Zeno` joined #minetest-dev
03:42 Megal joined #minetest-dev
04:42 Hunterz joined #minetest-dev
05:01 Miner_48er joined #minetest-dev
06:09 Megaf_ joined #minetest-dev
06:12 guest365 joined #minetest-dev
06:42 Hunterz joined #minetest-dev
07:04 jin_xi joined #minetest-dev
07:27 nore joined #minetest-dev
07:35 nrzkt joined #minetest-dev
07:36 nrzkt thanks for your review ShadowNinja, i'll look at this
07:36 leat joined #minetest-dev
07:41 nore nrzkt: you should look at #2346
07:41 ShadowBot https://github.com/minetest/minetest/issues/2346 -- Android connection.o bug
07:46 nrzkt i'll look at this soon
07:48 kahrl ugh
07:48 kahrl that crap happens all the time
07:48 nrzkt ugh jackman ? :p
07:49 kahrl :P
07:49 kahrl why does android still not use cmake instead of listing all the source files in another makefile by hand
07:49 nrzkt i don't know, but this may be a good improvement
07:51 kahrl having to remember to update the build files of a platform almost nobody can compile for is a huge time waster for everybody
07:52 kahrl even more so if one forgets it and has to be reminded after the fact
08:03 ShadowNinja kahrl: Because that's how sapier did it.  It might have been easier for him that way.  It should definitely be merged into the CMake system though.
08:05 ShadowNinja Android support still uses a lot of hacks, patches, and less-than-perfect methods though.  You need to use a custom patched Irrlicht and generate file lists and things like that.
08:09 selat joined #minetest-dev
08:11 ShadowNinja nrzkt: You should probably add that last fix to the freeze branch.
08:12 nrzkt ShadowNinja: approved for Cmake cleanup
08:12 nrzkt ShadowNinja: #2343 ? (i fixed and rebased it)
08:12 ShadowBot https://github.com/minetest/minetest/issues/2343 -- Fix unused (and so, broken) enable_rollback_recording. by nerzhul
08:12 ShadowNinja R
08:14 ShadowNinja nrzkt: You need to use `not setting...`, otherwise nil will count as true.
08:14 ShadowNinja (and it's better style because it reads better anyways)
08:15 nrzkt then, extract core.setting_getbool to a variable and test if nil or false ? right ?
08:16 nrzkt i'm not familiar with our lua api yet, but i will learn :)
08:16 ShadowNinja nrzkt: No, just `if not core.setting_getbool(...) then`.
08:17 nrzkt i see
08:17 ShadowNinja nrzkt: Also, use chat command return values.
08:17 ShadowNinja return success, msg rather than chat_send(msg) return.
08:18 nrzkt then return false and message was okay ?
08:18 ShadowNinja Aaand off to bed.  Poke me tomorrow and I'll check it again.
08:19 nrzkt c55 wants the release today :s
08:19 ShadowNinja nrzkt: return false, "Rollback recording disabled."
08:19 nrzkt ok doing it, that's all ?
08:19 ShadowNinja nrzkt: Yep.
08:20 ShadowNinja It's already really late here though, so I've got to go.
08:20 nrzkt no problem, with the return fix i can merge ?
08:21 ShadowNinja nrzkt: As long as it's tested probably.  I guess I can wait a minute and check it once more...
08:22 nrzkt ok that's fixed
08:23 ShadowNinja nrzkt: setting == false   ---->>   not setting
08:24 nrzkt erf... sorry, i had fixed it but i do a git reset in my commit to prevent another modification and forget to redo this
08:24 ImQ009 joined #minetest-dev
08:24 ShadowNinja Also broken commit message.
08:24 ShadowNinja If you do that it's fine.
08:25 nrzkt fixed :)
08:27 ShadowNinja All good now, assuming my brain's still functioning decently...zzzZZZ
08:27 nrzkt good night, thanks !
08:36 guest365 joined #minetest-dev
08:42 kilbith joined #minetest-dev
08:55 nore nrzkt, you missed toclientpacket.cpp too :)
08:56 nrzkt yes, i'm fixing it, those files have been removed and i'll add packethandlers
08:56 nrzkt i double checked the new commit, it seems fine. Android pain :(
08:57 nore android build sounds to be quite annoying
08:57 Zeno` joined #minetest-dev
08:58 celeron55 the android build is very easy to make, but maintaining it looks to not be very enjoyable
08:58 celeron55 it automates everything which is good because nobody could be bothered otherwise to actually ever build it
08:59 celeron55 i think getting the source file listing from the main cmake project should be implemented though
09:00 nrzkt celeron55, because we are getting the 0.4.12 release soon, is there any roadmap and objectives we can fix for 0.5 ?
09:00 nrzkt s/fix/set
09:00 nore there's http://dev.minetest.net/TODO
09:01 nrzkt okay, maybe we can set a mandatory version for 0.5 release ready process ? :=)
09:01 celeron55 not really, but for example that page lists things that some of the now-more-inactive devs have come up with previously
09:01 celeron55 none of that nor my plans are specific to 0.5 though
09:02 nrzkt okay
09:02 celeron55 you can propose something and ask for comments
09:02 celeron55 (like anyone else can)
09:02 nore there's the section on "Big protocol changes" that seems to be linked with 0.5
09:03 nrzkt i  talked with Zeno` about settings yesterday, i think they must be reviewed because there is no real core API to interact with properly, it may be reworked.
09:03 nrzkt "Make the client request mapblocks" => what would you mean exactly ? (i haven't studied all packet contents, only packet design and some security designs)
09:05 celeron55 it refers to how the mapblock transfer works now (and always has), which is that the server decides what the client needs and pushes them to the client
09:05 nore I think that would be: the client says what mapblocks it wants
09:05 nore instead of the server deciding that
09:06 celeron55 also it's a bit more complicated thing than you'd initially think as the server can't just respond to the client's requests; it also has to send updates to the mapblocks that the client is supposed to know when their contents is modified, and prioritize them based on the distance to the client
09:07 celeron55 currently it's all integrated to one algorithm
09:11 celeron55 which is sort of an iterative polling-based system
09:12 celeron55 https://github.com/minetest/minetest​/blob/master/src/clientiface.cpp#L62
09:14 celeron55 some kind of a distance-sorted event queue thing would probably be ideal for the updates i guess
09:14 celeron55 or whatevr
09:14 celeron55 +e
09:20 nrzkt maybe, yes
09:20 celeron55 here's buildat's: https://github.com/celeron55/buildat/blob/maste​r/src/lua_bindings/spatial_update_queue.cpp#L33
09:20 nrzkt more struct please :p
09:21 celeron55 buildat doesn't have dynamic world sending though; it just sends everything but it still has to do the updates afterwards
09:22 celeron55 (i don't actually remember if any of that actually was tested to work though, lol)
09:22 nrzkt seems interesting, i think we could use some things. i saw we can do some improvements on GIVE_BLOCKS GOT_BLOCKS packets, but a queue would be interesting too
09:24 celeron55 (do you know what buildat is?)
09:24 nrzkt not really, but i remember you talked about it last month on IRC
09:25 celeron55 oh, that discussion was probably quite informative so you probably know enough
09:26 nrzkt not really, but i remember you talked about it last month on IRC
09:27 nrzkt celeron55, did you agree using tags, starting at 0.4.12 release ?
09:28 celeron55 we have always used tags for releases
09:28 celeron55 or... what, have we not?
09:28 nrzkt oh you are right... i need to clean my glasses
09:28 nrzkt :p
09:28 celeron55 yes we have
09:29 nrzkt do you think #2314 is a blocker ?
09:29 ShadowBot https://github.com/minetest/minetest/issues/2314 -- Fix font_size by BlockMen
09:30 nrzkt we have currently 3 blockers opened. 2 will be solved fast, we only need to review the patch and push it
09:31 celeron55 there seems to be an issue in how the font_size setting is interpreted
09:32 celeron55 that isn't a proper fix for it
09:33 celeron55 actually the problem is not even that
09:34 celeron55 the formspec and font scaling is pretty much totally messed up due to some things done for android which didn't turn out to be good for desktop
09:34 celeron55 i don't even know how to solve it without further regressions
09:35 nrzkt then we may skip it for 0.4.12 and fix it in master later ?
09:36 celeron55 and... sapier gave up on it
09:37 VanessaE celeron55: I guess if you make the height of buttons and single-line text entry widgets depend on the rendered height of the text, and disable auto-scaling of the pause and main menus, that would go a long way toward fixing it.
09:37 VanessaE (but that won't solve the no-DPI-detection on windows)
09:38 celeron55 does anyone have time for eg. trying what VanessaE suggests?
09:38 nrzkt sorry, busy at this time, i need to discuss with est31 to include #2334 for release
09:38 ShadowBot https://github.com/minetest/minetest/issues/2334 -- Add protocol version logic to master server by est31
09:39 nrzkt and also #2037
09:39 ShadowBot https://github.com/minetest/minetest/issues/2037 -- World mod configuring is broken
09:41 celeron55 indeed the main menu does not suck balls on desktop if it's set to fixed size
09:41 FR^2 joined #minetest-dev
09:41 celeron55 (just tested)
09:41 VanessaE quote of the day! :D
09:42 VanessaE sapier's main gripe about android was because of retina displays and the like, I guess.
09:47 celeron55 https://github.com/minetest/minetest/pull/2348
09:47 celeron55 so this would be VanessaE's suggestion
09:48 celeron55 at least it makes the initial experience for most users reasonable
09:48 nrzkt not good :s
09:48 nrzkt i'm not sure, but with default window size it seems strange, no ?
09:49 VanessaE compiling..
09:49 nrzkt i'm not sure, but with default window size it seems strange, no ?
09:49 VanessaE whoa
09:49 nrzkt sorry to the double line. the main menu seems strange, but ingame is correct
09:50 VanessaE he's right that the menu size relative to default window size is odd.
09:50 celeron55 should the fixed size parameter of formspecs be defaulted to be true on desktop always, and false on mobile always?
09:50 VanessaE but the *behavior* is right
09:51 celeron55 i really don't have a good player or modder perspective on this
09:51 celeron55 or android user
09:51 VanessaE celeron55: I would say scaling a regular formspec is probably okay, but certain elements shouldn't scale (hence my mentioning single-line text entry, i.e. the "search" field in Unified Inventory)
09:52 VanessaE on android, scale everything by default.
09:52 celeron55 so would you think that PR makes it good for release and without it it's not good for release?
09:53 VanessaE I'd say so, but can you tweak the overall size of the pause and main menu formspecs a bit?
09:53 VanessaE turn them down by, oh, 10 percent maybe.
09:55 VanessaE 16 percent.
09:55 VanessaE just checked by turning my GUI scaling down
09:55 VanessaE at 84 percent, it just clears the "MINETEST" header in the "Client" tab.
09:55 VanessaE (er, client, settings, etc tabs)
09:59 celeron55 that completely depends on the window size
09:59 celeron55 on full-hd it's far from touching it
09:59 VanessaE I'm basing this in the default size.
09:59 VanessaE 800x600
10:00 celeron55 nobody uses the default size except for testing and for testing it simply does not matter
10:00 VanessaE perhaps.
10:01 VanessaE you're right though, it's fine at other window sizes
10:01 VanessaE and definitely sucks less.
10:01 VanessaE excuse me, "does not suck balls" ™
10:02 nrzkt xD
10:03 nrzkt then celeron55 we could merge and clear this blocker. two blockers remaining, needing a last review
10:03 VanessaE for the sake of the release, I'd probably go ahead and put it through.  Sapier will throw a shit-fit though :)
10:03 celeron55 well sapier already stated he's not going to touch it anymore so he can't complain
10:04 VanessaE fair enough
10:05 celeron55 i think blockmen's real issue is that he has scaled to gui down and the font goes down with it
10:07 VanessaE there's another issue you may want to consider with this scaling, really only affects carbone and dreambuilder:  the hotbar doesn't scale with window size anymore.
10:08 VanessaE (because it doesn't scale, at smaller window sizes it now occupies two rows since it has so many slots in those two games)
10:10 VanessaE #2118 might be it
10:10 ShadowBot https://github.com/minetest/minetest/issues/2118 -- Hotbar is far too big
10:10 VanessaE also #1897
10:10 ShadowBot https://github.com/minetest/minetest/issues/1897 -- Hotbar doesnt scale with window size
10:13 celeron55 the real solution to that is having at least a separate gui and hud scale settings
10:13 VanessaE I suggested that.  My suggestion was rejected quite vocally :P
10:13 celeron55 why was it rejected
10:14 VanessaE I think the logic was that there would simply be too many settings and that there was no reason to do that.
10:14 VanessaE something along those lines.
10:18 nrzkt it's stupid, you cannot use the same GUI on Android an PC/Mac
10:19 VanessaE nrzkt: been saying it for years (in a generic, non-minetest sense).  PC != mobile devices, and trying to shoehorn one paradigm into the other platform almost always fails.
10:19 DFeniks joined #minetest-dev
10:19 nrzkt we could change this later, but atm we need to have working PC and Android , and i think celeron55 you can commit your issue, nobody plays in 800x600 with minetest :)
10:20 VanessaE certainly no one spends a significant amount of time in the main menu at 800x600 anyway :P
10:21 nore but... such a beautiful menu ;)
10:21 VanessaE I wonder if there isn't a cross-platform way to tell the user's OS/window manager to "maximize" on program start? (not fullscreen mind you)
10:22 nore isn't there a way to get screen size, then set window size?
10:22 VanessaE in Linux there is, but that won't work for dual-screen setups that don't use xinerama
10:23 VanessaE (can't speak for windows)
10:23 nore hm..
10:23 guest365 joined #minetest-dev
10:23 nrzkt but maybe we could keep screen size at client exit to launch it with proper size at startup :)
10:24 nrzkt window size*
10:24 VanessaE nrzkt: not a bad idea, but some would argue that that's window manager territory
10:25 VanessaE (and there is a minetest.conf setting of course, so "remembering" it would be trivial)
10:25 nrzkt window manager keep the window position, no size
10:25 nrzkt and for gnome application is launched from mouse size generally (for MT)
10:31 nrzkt nore: can you review #2334 please ?
10:31 ShadowBot https://github.com/minetest/minetest/issues/2334 -- Add protocol version logic to master server by est31
10:33 celeron55 i guess we agree with #2348 then
10:33 ShadowBot https://github.com/minetest/minetest/issues/2348 -- Use fixed size for builtin menus on non-android platforms (?) by celeron55
10:34 VanessaE yeah
10:35 celeron55 pushed
10:36 nrzkt great, one blocked killed
10:36 nrzkt i'm on 2334 tests with PR 3/4 patch
10:36 proller joined #minetest-dev
10:38 celeron55 how does one remove labels on github?
10:38 celeron55 it seems to be broken for me
10:38 nrzkt which label would you want to remove ?
10:39 celeron55 blocker from #2314
10:39 ShadowBot https://github.com/minetest/minetest/issues/2314 -- Fix font_size by BlockMen
10:39 nrzkt done
10:40 fz72 joined #minetest-dev
10:40 kahrl the labels menu at the top tends to be broken for me too, in that case I use the labels menu at the bottom
10:41 celeron55 the bottom one looked like it worked, but didn't actually do anything
10:41 celeron55 this is the remaining blocker then: #2037
10:41 ShadowBot https://github.com/minetest/minetest/issues/2037 -- World mod configuring is broken
10:41 kahrl well weird, the bottom one always works for me
10:41 kahrl oh well
10:41 nrzkt #2334 too
10:42 ShadowBot https://github.com/minetest/minetest/issues/2334 -- Add protocol version logic to master server by est31
10:42 nrzkt but it doesn't works well, servers doesn't register the protocol min and max aren't correctly handled. My protocol v25 client can try to connect to old servers
10:43 celeron55 master server doesn't really have to follow the same release schedule; it can be done asynchonously
10:43 celeron55 the public instance is always kept at master
10:43 nrzkt sfan5 patched it
10:44 celeron55 but... hmm i see, that might be needed
10:44 nrzkt we must use it for 0.4 stable to do a good 0.5 transition
10:45 deltib joined #minetest-dev
10:45 celeron55 how well has 2334 been tested?
10:46 nrzkt i'm testing it atm
10:46 nore I'm reviewing the code meanwhile
10:47 celeron55 in principle it's fine; just need to make sure it doesn't break anything
10:47 nrzkt atm not
10:47 nrzkt the server master list is full
10:47 nrzkt but the filtering for non version registered servers isn't good
10:49 nore what do you mean?
10:49 nrzkt atm all servers haven't this patch, then no server register their supported version to master server. Using the master client with PROTOCOL = 25 i see all servers as compatible and i can try to connect
10:50 celeron55 no registered version should mean it's protocol 24
10:50 nore so perhaps: if no protocol is sent: use protocol_max = 24
10:50 nrzkt i agree
10:50 nrzkt i fix the patch and test it
10:50 nore and protocol_min = ? (need to check)
10:51 nore protocol_min = 13 right now
10:51 nrzkt okay
10:52 nore (except if the server has strict protocol checking, but we can't see that)
10:53 nore but anyway: client will have protocol >= 24 too
10:53 nrzkt then the server will filter itself
10:53 nrzkt and the new clients will have the master server filters
10:54 nore yep, but anyway, I don't think there is any server using protocol < 24 out there
10:54 nore so, just setting protocol to 24 in that case should be enough
10:56 nrzkt ok, they are now greyed out, but we can connect to it
10:58 nore what do you mean?
10:59 nrzkt the servers are shown as invalid (line are in gray), but if i click on connect, the handling doesn't work and let me trying to connect
10:59 nore did you change everywhere?
10:59 nore the best would be a server_compatible function
11:00 nrzkt yes but main_button_handler in multiplayer.lua don't reach the test, i looked at it
11:00 nore instead of repeating the same code 5 times
11:00 nore hm..
11:01 BlockMen joined #minetest-dev
11:01 BlockMen https://github.com/minetest/minete​st/pull/2314#issuecomment-74846583
11:01 nrzkt oh this works, but not if server is a favourite :)
11:01 BlockMen celeron55 ^
11:02 nore yeah, that's what I was thinking too
11:03 nore so there's one more change to make
11:03 nrzkt hmmm this doesn't work one more time, every server i join has the problem....
11:03 nore it stills allows you to connect?
11:03 nrzkt yes. i will search more precisely why
11:04 celeron55 BlockMen: hmm, well from my standpoint nothing has really changed, the font has been too small for agegs
11:04 celeron55 ages*
11:04 celeron55 and i'm on linux so your windows change helps nothing
11:05 BlockMen thats intentional since its only broken on windows since there is no dpi detection on windows implemented
11:05 BlockMen at least SN said that
11:05 celeron55 i'm fine with switching the default to 18 on all platforms
11:05 nrzkt oh i see now
11:05 nrzkt it works when i click on connect, but not on double click
11:06 nore yes, doubleclick is somewhere else in the code
11:06 nore around line 120
11:06 nrzkt ofc
11:06 nrzkt if event.type == "CHG" then
11:06 BlockMen celeron55, then we would still have different dont sizes on different plattforms (with same screen size)
11:06 BlockMen that makes no sense either
11:06 nrzkt no before,
11:06 nrzkt if event.type == "DCL" then
11:06 BlockMen *font
11:06 celeron55 but the same config value should result in the same visual font size if the DPI is the same
11:06 nrzkt i fix it
11:06 nore yep, it's there
11:06 celeron55 if not, that's a problem
11:07 celeron55 and shouldn't be worked around
11:07 BlockMen yes, but since idk the dpi stuff and since it is missing (!) on windows we need wither a workaround or a proper fix
11:07 VanessaE sounds to me like either DPI detection needs to be implemented on windows, or a more reasonable, fake setting needs to be plugged in for that platform.
11:07 BlockMen but that font size is not ok, and i will not accept a release with that tiny font
11:09 celeron55 i have a dpi of 90 on this display on linux and my font on minetest of default size 14 is pretty much the same as blockmen's "current" images
11:09 celeron55 that's a smaller dpi than 96 so the font should be a bit larger
11:09 celeron55 but it's still the same
11:10 celeron55 this is why the size should be changed to be bigger on all platforms and the same value is fine
11:10 kilbith celeron55, size 18 on linux : https://lut.im/9gclV3Xb/iSZjPuWg
11:10 kilbith not acceptable
11:11 celeron55 what's your dpi?
11:11 kilbith 96
11:11 celeron55 xdpyinfo | grep dots
11:11 kilbith jp@r2d2:~$ xdpyinfo | grep dots
11:11 kilbith resolution:    96x96 dots per inch
11:11 celeron55 are you using freetype or not? (cmake . -LH | grep FREETYPE)
11:11 kilbith with freetype yes
11:11 VanessaE kilbith: ironic you should say that 18 isn't acceptable, I have mine set to 17 (with 96 DPI and freetype) because I have sucky vision :)
11:11 celeron55 well what the hell
11:12 celeron55 what is the explanation of this
11:12 celeron55 there has to be one
11:12 VanessaE celeron55: I'd guess that on windows, there's a "fake" DPI setting that's excessively high?
11:12 celeron55 windows isn't an issue
11:12 celeron55 look at what kilbith said
11:13 celeron55 and what i said
11:13 VanessaE well, he says font size 18 isn't acceptable, but 18 ain't the standard size.  it's more like 13 isn't it?
11:13 kilbith 14
11:13 VanessaE right.
11:14 celeron55 http://imgur.com/el1RQCx
11:14 celeron55 mine at font size 18
11:14 celeron55 dpi is 90
11:14 celeron55 latest master
11:14 celeron55 gui_scaling is 1.00
11:14 celeron55 14 is way smaller as you might think
11:15 VanessaE http://digitalaudioconcepts.com/vanessa/extra/Scre​enshot%20-%2002182015%20-%2006%3a18%3a56%20AM.png
11:15 celeron55 i hope this makes the issue rather clear
11:15 BlockMen but that is > than 18 on windows
11:15 VanessaE that's the default size there.
11:15 celeron55 why is 18 on killbith's machine way, WAY larger than 18 on mine?
11:15 celeron55 my 18 would be a good default size; my 14 is too small
11:16 celeron55 and the sizes for me are like what blockmen is getting on windows, but i'm on linux
11:16 celeron55 this is what needs to be explained
11:16 BlockMen celeron55, no your 18 is larger than mine
11:16 celeron55 and this is why we can't just go and change some default values when everyone is getting different results due to no good reason
11:17 VanessaE hm, good question.
11:17 celeron55 BlockMen: just slightly
11:18 VanessaE sapier claimed that some of these differences were rounding errors last time we had this discussion
11:18 celeron55 lol that's not a rounding error
11:18 VanessaE I wouldn't have thought so either :)
11:19 BlockMen celeron55, 1.2 to be precisely ;)
11:19 celeron55 kilbith: how does 17 look for you?
11:20 celeron55 i have to go to not 19, but 20 to get what you see at 18
11:21 kilbith celeron55, https://lut.im/36h07Rhq/1FXKRVM5
11:21 VanessaE 17 (my usual setting):  http://digitalaudioconcepts.com/vanessa/extra/Scre​enshot%20-%2002182015%20-%2006%3a24%3a50%20AM.png
11:21 celeron55 VanessaE: what dpi?
11:21 VanessaE celeron55: 96, gui scaling set to exactly 1.0
11:21 * VanessaE wonders what kilbith's gui_scaling is set to.
11:21 kilbith 1.0
11:22 celeron55 wait actually, this might be due to the dpi difference plus rounding error
11:22 celeron55 it's almost a worst case situation but it is
11:23 celeron55 suggestion: change the default to 16 on linux, 18 on windows
11:24 celeron55 based on everything said in this discussion it would work best
11:24 kilbith the missing point that we should avoid is the unpredictability on font size, not the right size itself
11:24 celeron55 i said that already, but it isn't an option now
11:25 VanessaE for me, 16 looks about like 17 does for kilbith - almost, but not quite, bit of a difference in font weight.
11:25 celeron55 we have to have an image of a certain size font at a certain dpi that every platform has to try to achieve with those values
11:26 VanessaE actually 15 for me is closer to 17 for kilbith.
11:26 celeron55 VanessaE: that's very weird as your dpi is the same as his
11:26 VanessaE what's the default font face the engine uses?
11:27 celeron55 fonts/liberationsans.ttf
11:28 VanessaE ok.  I use dejavu, but it doesn't matter.  that only affects the apparent weight, not the height.
11:29 VanessaE here's 17, leaving the font face at the engine default:  http://digitalaudioconcepts.com/vanessa/extra/Scre​enshot%20-%2002182015%20-%2006%3a33%3a08%20AM.png
11:29 celeron55 can we agree to change the sizes to 16 on linux and 18 on windows, and aim in the future to get windows 16@96dpi size to visually match linux 16@96dpi?
11:29 nore VanessaE: that makes the same as kilbith
11:30 BlockMen celeron55, yes
11:30 VanessaE celeron55: yeah, I could go with that.
11:30 nore it looks ok to me too
11:30 celeron55 (and when that happens, then windows can be changed to use 16 by default)
11:30 VanessaE nore: not quite, still larger than kilbith's but closer.
11:31 BlockMen should i increase the no ttf size aswell?
11:32 VanessaE nore: actually, I think they are just about the same.  so yeah, he and I match now.
11:32 VanessaE the different-sized formspec was throwing me off
11:33 celeron55 BlockMen: i think we can ignore it for now; it's not as important and will result in a slightly different kind of size as well
11:33 celeron55 but if you want to test it enough to be sure, feel free to
11:33 nrzkt nore: nearly finished the modification :)
11:34 nore ah, good :)
11:34 celeron55 BlockMen: or... well
11:34 celeron55 BlockMen: you could change it to 16 too; it can't hurt
11:35 celeron55 wait
11:35 celeron55 the default non-ttf size is 10?
11:35 BlockMen yes
11:35 celeron55 well in that case leave it be; touching that seems absolutely hazardous
11:36 BlockMen and i cant test, mt crashes when i set freetype = false :\
11:36 BlockMen ^ can someone test on linux?
11:36 celeron55 it indeed crashes
11:37 celeron55 i'll build a non-freetype build and see if it crashes in that case
11:37 VanessaE checking...
11:37 VanessaE oh, beat me to it.
11:37 celeron55 doesn't crash
11:38 celeron55 a font size of 11 would probably better match the linux 16
11:38 celeron55 but then again, i have 90dpi and there's rounding errors
11:39 VanessaE no crash here with non-ft
11:40 celeron55 can you check if 11 is more like 16 for your setup
11:40 celeron55 more than 10, i mean
11:40 nrzkt what tab is table_simple_main ?
11:41 nrzkt because there is a check there too, but i don't think this is useful
11:42 VanessaE celeron55: non-ft, size 11:  http://digitalaudioconcepts.com/vanessa/extra/Scre​enshot%20-%2002182015%20-%2006%3a46%3a22%20AM.png
11:42 nrzkt tab_simple_main sorry
11:42 celeron55 nrzkt: it's the android first tab
11:42 celeron55 VanessaE: oh, so 10 is better on yours
11:43 celeron55 BlockMen: it must be left at 10
11:43 VanessaE 10 is pretty dinky on mine
11:43 celeron55 it's a bit dinky but 11 has a wrong style
11:43 VanessaE http://digitalaudioconcepts.com/vanessa/extra/Scre​enshot%20-%2002182015%20-%2006%3a47%3a52%20AM.png
11:43 celeron55 that's what 11 looks for me
11:44 nrzkt celeron55: oh, it's not shown on linux builds then ?
11:44 celeron55 nrzkt: no
11:44 nrzkt okay, thanks
11:44 celeron55 see mainmenu/init.lua:55
11:44 VanessaE and here's freetype, size 16:  http://digitalaudioconcepts.com/vanessa/extra/Scre​enshot%20-%2002182015%20-%2006%3a49%3a00%20AM.png
11:45 BlockMen should i push then #2341 as is now?
11:45 ShadowBot https://github.com/minetest/minetest/issues/2341 -- map seed is still broken
11:45 kilbith size 16 for me : https://lut.im/gtjcd04K/l0wgCEje
11:45 BlockMen oh, wrong number :D
11:46 BlockMen #2314
11:46 ShadowBot https://github.com/minetest/minetest/issues/2314 -- Fix font_size by BlockMen
11:46 VanessaE kilbith: matches me.  at least freetype agrees :P
11:46 kilbith ie. too skinny
11:46 VanessaE you mean the weight is too light
11:46 celeron55 lol, what about 15 then?
11:47 celeron55 damned pixels making fonts weird at that size
11:47 celeron55 either too thin or too bold
11:47 kilbith 15 is good... https://lut.im/vTgW7oEC/trGB8frl
11:47 celeron55 can we agree on 15?
11:48 VanessaE celeron55: 15 is to small for my eyes, but I think most people won't have trouble with it.
11:48 VanessaE so go with 15.
11:48 VanessaE it's already larger than the existing size anyway :)
11:48 VanessaE one thing that would help is if we had some control over the font hinting
11:49 VanessaE the too-light-or-too-bold would be much less of a problem then
11:49 celeron55 BlockMen: go with 15; this is final and you can push it then
11:49 nrzkt i go to lunch, i propose the #2334 after
11:49 ShadowBot https://github.com/minetest/minetest/issues/2334 -- Add protocol version logic to master server by est31
11:50 celeron55 VanessaE: we bundle a ttf implementation for irrlicht so it might be doable
11:51 celeron55 it already contains some hinting options that aren't used
11:51 VanessaE right, I forgot that's how it was done
11:51 celeron55 someone can look into it if they want to
11:54 BlockMen celeron55, done
11:54 VanessaE (he looked into it? ;) )
11:54 BlockMen to freeze aswell i guess
11:55 celeron55 let's push these later to freeze as i didn't push mine yet either
11:56 VanessaE just a rough guess, it acts a lot like it's defaulting to "full" hinting.  if that could be set to "slight", or taken from the user's desktop setting, it would probably be enough.
11:56 celeron55 what exactly do we need to push there... the android build of 0.4.12 is fine, right? that doesn't go in
11:56 celeron55 so my fixed size commit goes in, and then the font size stuff
11:58 VanessaE there's one test that should be done before official release, if possible - could someone prepare an -rc build or something and throw it at MichaelEh?
11:58 celeron55 pushed it
11:58 fz72 celeron55: #2342 and #2345
11:58 ShadowBot https://github.com/minetest/minetest/issues/2342 -- Fix map_seed by fz72
11:58 ShadowBot https://github.com/minetest/minetest/issues/2345 -- Add modname convention checking by est31
11:58 VanessaE (his obscure crash is the reason hmmmm added that mini crashdump feature)
11:58 celeron55 BlockMen: you can push to freeze now
11:59 crazyR joined #minetest-dev
11:59 crazyR joined #minetest-dev
12:00 BlockMen done
12:01 celeron55 2342 is still a problem in 0.4.12, right?
12:02 celeron55 i'll push it to freeze
12:03 celeron55 so now #2334 and #2345 have to be handled still i think
12:03 ShadowBot https://github.com/minetest/minetest/issues/2334 -- Add protocol version logic to master server by est31
12:03 ShadowBot https://github.com/minetest/minetest/issues/2345 -- Add modname convention checking by est31
12:03 BlockMen btw freeze, is there made a decision yet about the freezing in future releases? i still would like to freeze master in the future and push things to (e.g.) "dev-0.5", which gets merged after freeze is over
12:05 celeron55 yes i think we'll go that way in the future
12:05 celeron55 this was a bit of a shoddy decision but the end result will only be inferior cosmetically
12:07 BlockMen ok, good
12:12 celeron55 updated this: http://dev.minetest.net/Git_Gu​idelines#Upstream_branch_rules
12:13 nore "in the baster branch"? ;)
12:13 celeron55 fixed
12:14 celeron55 also fixed another mistyping
12:14 Megal joined #minetest-dev
12:15 kahrl hmm
12:15 kahrl is dpi detection on windows really that difficult that we rather use a workaround with different default font sizes?
12:16 VanessaE kahrl: apparently there are several different calls to use, depending on windows version.
12:16 kahrl VanessaE: really?
12:17 kahrl isn't GetDeviceCaps(screen, LOGPIXELSY) enough?
12:17 VanessaE that's the impression I got previously but I'm no win coder.
12:17 kahrl well there's the issue that SetProcessDPIAware needs to be called for vista and later
12:17 kahrl but that's all I think
12:18 ElectronLibre joined #minetest-dev
12:18 BlockMen kahrl, you have an idea about this? https://forum.minetest.net/v​iewtopic.php?f=6&amp;t=10862
12:18 kahrl BlockMen: no
12:18 kahrl it happens on none of the machines I tried
12:19 BlockMen :(
12:19 kahrl there's a PR about it but I don't think it properly fixes it
12:20 kahrl oh, it one of yours ;)
12:20 kahrl it's
12:20 BlockMen it just removes these multi lightings, but its still not "sharp"
12:21 kahrl yeah that's what I guessed
12:21 BlockMen thats why i asked, because you rewrote the wieldmehs
12:21 kahrl I think it's some kind of rounding error on certain graphics cards
12:22 kahrl difficult to fix
12:22 kahrl we could just revert the whole thing but RBA won't be very happy about that
12:23 BlockMen isnt the shader thing commented out anyway?
12:23 kahrl yeah but iirc he wants to reenable it soon
12:23 kahrl once he comes back
12:25 BlockMen hmm, seems to be opengl related. with directx it works fine
12:27 selat joined #minetest-dev
12:33 VanessaE time to head to bed.
12:33 VanessaE night.
12:54 nrzkt celeron55 i'm on #2334, i provide a patched version now
12:54 ShadowBot https://github.com/minetest/minetest/issues/2334 -- Add protocol version logic to master server by est31
12:57 sfan5 something with gui scaling is broken in master again
12:57 nrzkt celeron55, nore: please review #2349 (2334 review)
12:57 ShadowBot https://github.com/minetest/minetest/issues/2349 -- Add protocol version logic to master server (#2334 rewrite) by nerzhul
12:57 sfan5 http://meow.minetest.net/i/c7a5779021645012.png
12:58 sfan5 (non-freetype)
12:58 nrzkt it's "normal", look at IRC logs please
12:58 nrzkt and the last 3 commits on master :)
12:58 celeron55 nrzkt: the first thing that now comes to mind is that the commit message is a bit off; it should say "to server list" or something 8)
12:58 nrzkt yes, i can rework that, it's the original version :)
12:59 sfan5 the menu not being completly visible is a feature? nevermind then
12:59 celeron55 sfan5: what are your settings
12:59 celeron55 gui_scaling?
12:59 sfan5 defaultsettings.cpp
12:59 sfan5 i cloned the repo and built without freetype
13:00 celeron55 what's your screen dpi?
13:00 celeron55 xdpyinfo | grep dots
13:00 sfan5 resolution:    96x96 dots per inch
13:01 celeron55 this is very weird, there must be something causing it
13:01 PilzAdam joined #minetest-dev
13:01 sfan5 this whole font/formspec scaling thing doesn't work consistently at all
13:01 celeron55 wait
13:02 celeron55 no, it's working exactly like for others that have a 96dpi screen
13:02 celeron55 i think this is not a blocking issue; important parts of the menu show up, and the user is likely to enlarge the window anyway
13:03 celeron55 the formspec surely should clamp to the window size though if it attempts to be larger otherwise
13:03 sfan5 /tmp/mt/src/camera.cpp:499:26: warning: using integer absolute value function 'abs' when argument is of floating point type
13:03 sfan5 huh
13:03 sfan5 someone should probably look at that
13:03 nrzkt celeron55: updated commit message
13:04 celeron55 sfan5: good catch; the effect seems to be a minor bug
13:04 sfan5 thank clang :)
13:05 celeron55 actually, it doesn't cause a bug because the end result is compared with 10
13:05 celeron55 so it only makes a 10% difference at maximum when being negative 8)
13:05 sfan5 *** Error in `./minetest': double free or corruption (fasttop): 0x00007f711bfcb820 ***
13:05 sfan5 hm
13:06 celeron55 a very small bug, no wonder nobody noticed
13:06 sfan5 i hope this is my video driver
13:06 sfan5 oh
13:06 sfan5 this is the Logbuf crash
13:06 sfan5 i think i opened an issue for that
13:06 sfan5 no idea how it happens
13:07 nore <sfan5> *** Error in `./minetest': double free or corruption (fasttop): 0x00007f711bfcb820 *** <-- that happens to me too, quite randomly
13:07 swaaws joined #minetest-dev
13:07 sfan5 it happend to me three times exactly after (re)compiling
13:07 sfan5 (right now, today)
13:08 nrzkt use gdb with minetest ?
13:08 sfan5 nrzkt: https://github.com/minetest/minetest/issues/1447
13:09 nrzkt erf
13:12 Zeno` joined #minetest-dev
13:16 sfan5 oh
13:16 sfan5 i love this consistency
13:17 sfan5 minetest.settings_getbool but <object Settings>:get_bool
13:17 sfan5 and Settings doesn't even have setbool while minetest.settings_setbool exists
13:20 nrzkt yes, settings must be reworked :(
13:23 celeron55 the rework must include a split to two versions too
13:23 celeron55 one for the protocols and file formats and one for the actual configuration
13:23 ElectronLibre joined #minetest-dev
13:25 celeron55 (i guess many already knew that but... anyway)
13:26 celeron55 it doesn't build directly when applied to freeze-0.4.12
13:26 celeron55 i mean, #2349
13:26 ShadowBot https://github.com/minetest/minetest/issues/2349 -- Add protocol version logic to master server (#2334 rewrite) by nerzhul
13:27 kahrl about the wield items issue... I wonder if it can be fixed by simply avoiding numbers that lead to numerical errors
13:27 celeron55 okay it's just #include "network/networkprotocol.h" -> #include "clientserver.h"
13:27 kahrl to anyone who experiences them: does this help? https://gist.github.com/kahrl/2d56e964c607b9aef34c
13:29 kahrl (probably not :/ but it's worth a try)
13:30 sfan5 hm
13:30 sfan5 https://github.com/minetest/minetest/issues/138
13:30 nrzkt #2349 was ok for you celeron55 ?
13:30 ShadowBot https://github.com/minetest/minetest/issues/2349 -- Add protocol version logic to master server (#2334 rewrite) by nerzhul
13:31 sfan5 can't that be closed because mods can do that?
13:31 sfan5 "Health bars above player names #138"
13:31 ShadowBot https://github.com/minetest/minetest/issues/138 -- Health bars above player names
13:31 nrzkt sfan5: agree
13:31 sfan5 i guess we can reopen it if we decide that it is still of imporance
13:31 sfan5 importance*
13:33 proller joined #minetest-dev
13:34 celeron55 nrzkt: if you checked the server and version 25 functionality, it's good
13:34 celeron55 i checked that a 0.4.12 client will work with it
13:34 everamzah joined #minetest-dev
13:34 nrzkt i retest it a last time
13:35 nrzkt i'm compiling my proto_25 version
13:35 BlockMen kahrl, nope. still glitchy
13:37 kahrl frustrating
13:37 proller joined #minetest-dev
13:37 kahrl other than reverting the entire thing, I'm out of ideas
13:39 roniz joined #minetest-dev
13:40 BlockMen if anyone else has some idea, it seems to be related to OpenGL version. 3.x seems the only version to work fine
13:40 BlockMen kahrl, its not high prio, so we can leave it for the moment i guess?
13:41 kahrl yeah
13:41 * BlockMen will open issue for it
13:41 kahrl since it's in 0.4.11 already it's not really a regression
13:41 kahrl isn't there one already?
13:41 nrzkt celeron55: i adjust 2349 with some nore suggestions
13:42 kahrl I guess not
13:43 kahrl #2035 has some off topic discussion related to it
13:43 ShadowBot https://github.com/minetest/minetest/issues/2035 -- Slabs are drawn through wall (graphic bug)
13:47 kahrl unrelated... is it just me or have the unit tests become a lot slower since today?
13:48 kahrl I saw some refactoring of test.cpp in the network layer rewrites, did it cause that?
13:48 nrzkt i don't think, because it only change the packet read/write no sockets
13:52 BlockMen when and why has hmmm left minetest?
13:57 celeron55 BlockMen: i'm not sure if he has, but he might have; also, it's somewhat hard to understand
13:59 celeron55 but it's a sure thing that he doesn't like it when someone new like nrzkt comes in and is allowed to rework things
14:03 BlockMen hmm, ic. hope he did not quit one and for all (if he did) :\
14:05 Zeno` He's no longer in the member list for minetest
14:06 Zeno` i.e. https://github.com/orgs/minetest/people
14:06 celeron55 he must have removed himself from it
14:06 celeron55 well at least it's clear then
14:07 proller joined #minetest-dev
14:10 Zeno` something is wrong with unit tests
14:11 nrzkt in master ?
14:17 Zeno` yeah
14:17 Zeno` it's taking > 5 seconds to run them
14:17 nrzkt server, client, both ? since when ?
14:18 Zeno` I'd have to bisect
14:18 Zeno` but both
14:18 Zeno` first run is fine...
14:18 Zeno` 0.5s
14:18 Zeno` then run again and it's 5s
14:22 proller joined #minetest-dev
14:24 Zeno` 5eb0eda626942882fa9ac4e040da51c644a2bbbd is fine
14:25 Zeno` same time (~0.5s) every time I run time ~/minetest/bin/minetestserver --enable-unittests     (I added an exit(0); at the end of unit tests)
14:26 Zeno` so, something between HEAD and that commit :)
14:28 nrzkt unit tests have been modified just after :)
14:28 celeron55 i noticed that too
14:29 celeron55 the tests should be moved to a separate executable anyway
14:29 leat joined #minetest-dev
14:29 celeron55 them being invoked from where they are is really a historical thing with no current reasons
14:30 Zeno` There should not be a 10x difference between first and second run though :/
14:30 nrzkt or we could disable them by default and invoke enable-unit test when we are doing a compilation with travis/jenkins ?
14:31 Zeno` or even a 10x difference at all
14:31 celeron55 meh, a separate executable is cleanest :P
14:31 Zeno` to me a 10x difference indicates something wrong
14:31 kahrl ed04e8e9e4 is the culprit according to bisect
14:31 nrzkt if you want, we only need a main.cpp which is test.cpp in fact
14:31 Zeno` considering the changes are minor
14:32 Zeno` kahrl, ed04e8e9e4??
14:33 Zeno` are you sure?
14:33 kahrl well bisect resulted in that one
14:33 Zeno` I'm too sick to profile this properly, but... I do think something is wrong
14:33 celeron55 well considering everything, that is quite likely
14:34 nrzkt how can this be possible there ? we only change the buffering , i could not take 5 seconds to buffer a 1 byte packet
14:35 Zeno` nrzkt, *shrug*. The difference is very definitely 10x though
14:35 Zeno` If I wasn't sitting here in misery feeling sorry for myself I'd gather some callgrind data heh
14:36 leat joined #minetest-dev
14:37 nrzkt that's very strange. an output stream between each test proove that is this test ?? i haven't experience this performance issue
14:38 nrzkt celeron55: #2349 is ready for merge into feature freeze, reviewed by nore
14:38 ShadowBot https://github.com/minetest/minetest/issues/2349 -- Add protocol version logic to master server (#2334 rewrite) by nerzhul
14:40 shadowzone joined #minetest-dev
14:40 Zeno` Well, I experience it (I just add an exit(0); at the end of the unit tests and use time)
14:40 Zeno` seems kahrl experiences it also
14:41 Zeno` so is the 10x degradation just in the unit tests or elsewhere also?
14:41 nrzkt errr celeron55: don't merge... there is a color issue, i haven't see it properly
14:43 Wayward_One_ joined #minetest-dev
14:45 kahrl https://github.com/minetest/minete​st/blob/master/src/test.cpp#L2049
14:46 kahrl this loop took 4766 ms in one test I just ran
14:47 nrzkt then the client takes many time to receive the datas
14:47 kahrl (I added some dstream debugging to measure that)
14:51 shadowzone joined #minetest-dev
15:01 SopaXorzTaker joined #minetest-dev
15:02 nrzkt kahrl do you have some new informations . i cannot reproduce the problem
15:04 kahrl nope
15:08 nrzkt nore: merging #2349, ok?
15:08 ShadowBot https://github.com/minetest/minetest/issues/2349 -- Add protocol version logic to master server (#2334 rewrite) by nerzhul
15:08 nore yep
15:11 MattJ joined #minetest-dev
15:17 celeron55 it's actually a good thing if the unit tests run at every startup of a debug build because they will catch a lot of stupid problems, but they cannot be slower than something like 500ms in total for that
15:17 celeron55 i mean, if they don't run like that, then we have to find out a way to make people run them explicitly
15:18 celeron55 and they almost surely will get neglected
15:18 nrzkt celeron55: i merged 2349 into master and i will merge it into feature freeze after a test
15:18 rubenwardy joined #minetest-dev
15:18 celeron55 ok
15:23 nore nrzkt: you closed the wrong pull request: #2345 instead of #2334
15:23 ShadowBot https://github.com/minetest/minetest/issues/2345 -- Add modname convention checking by est31
15:23 ShadowBot https://github.com/minetest/minetest/issues/2334 -- Add protocol version logic to master server by est31
15:24 nrzkt oops... i fix it, thanks :)
15:24 nrzkt not checking three PR from same author at same  time <= remember
15:25 nrzkt okay, now there is only one blocker
15:26 shadowzone So, am I do assume that the release is getting closer?
15:27 nrzkt right :)
15:27 shadowzone Yay!
15:27 shadowzone btw, I tried out the android version, there isn't a button to close inventory.
15:27 nore do you think we could release today if last blocker is fixed?
15:27 nore shadowzone: doubleclick outside inventory
15:28 shadowzone Oh, thank you
15:34 Zeno` I'm sorry. I have to ask again... is the increased time spent in unit tests because of the unit test or because of an issue somewhere else?
15:34 Zeno` I'll profile it tomorrow I guess
15:34 younishd joined #minetest-dev
15:35 nrzkt i looked at the calls and i don't see where is this possible to have a so huge amount of time on receive, function is same
15:36 Zeno` but the difference is, indeed, there
15:37 Zeno` nrzkt, what OS are you currently testing on?
15:38 nrzkt Archlinux
15:42 nrzkt i do a complete make clean of the project to be sure
15:42 nrzkt maybe something stayed somewhere because of branch switching...
15:44 celeron55 cmake always does a good job at rebuilding changed things, i don't know of any instance when it has failed it
15:48 nrzkt ok
15:48 nrzkt i can reproduce
15:48 nrzkt the problem is present with Debug build and not release build
15:51 Zeno` I experience with release build
15:52 nrzkt i always have the problem with Debug and never with Release... very strange
15:52 electrodude512 joined #minetest-dev
15:53 nore I fixed the problems in #2345: https://gist.github.com/No​vatux/f8e5ba3335711aec7e26
15:53 ShadowBot https://github.com/minetest/minetest/issues/2345 -- Add modname convention checking by est31
15:54 nore should I merge that?
15:54 nrzkt seems good for me
15:54 kahrl nrzkt: just to make sure: are you running the release build with --enable-unittests?
16:01 celeron55 nore: i think you may merge it; you should also push it to the freeze branch
16:01 nore ok
16:02 celeron55 after this i think we have the stablest version of minetest in a long time in our hands
16:02 nrzkt yes kahrl
16:03 fz72 joined #minetest-dev
16:05 nrzkt 0.4.12 ? :D
16:05 celeron55 yes i mean 0.4.12
16:05 nrzkt hura !
16:06 celeron55 i mean it's not bug free, but all things considered it deserves the stable status
16:07 nore ok, pushed
16:07 celeron55 the only problem is that the freeze branch gets too little testing; we will be better off with freezing master and developing in a separate branch in future freezes
16:08 nrzkt you mean invert feature freeze and master ? that could be strange, because master is devel version
16:09 kahrl it doesn't need to be
16:10 celeron55 it will behave better with our merge model too
16:13 celeron55 in such a model master is always the thing that we want people to be testing the most; i.e. in normal development it's the development head, but in freeze it's the frozen branch that needs all bugs to be killed
16:13 nrzkt that could make sense
16:14 celeron55 it's not a lot of effort for developers to switch the branch they do things on, but for users it's too much
16:14 nrzkt o
16:15 SopaXorzTaker joined #minetest-dev
16:18 fz72 before release 0.4.12 someone should look at the stable ppa, the 0.4.12 release has Buildtype=DEBUG
16:25 fz72 the same problem with the old minetest-c55(0.4.10) package
16:31 MinetestForFun joined #minetest-dev
16:33 roniz joined #minetest-dev
16:35 SudoAptGetPlay joined #minetest-dev
16:46 luizrpgluiz joined #minetest-dev
16:47 sebastia joined #minetest-dev
16:48 alexxs joined #minetest-dev
16:57 ImQ009 joined #minetest-dev
17:02 luizrpgluiz left #minetest-dev
17:03 Krock joined #minetest-dev
17:05 Hunterz joined #minetest-dev
17:17 Calinou joined #minetest-dev
17:27 SudoAptGetPlay Hi guys what's still a blocker for 0.4.12 release ?
17:28 Krock the time :3
17:28 johnnyjoy joined #minetest-dev
17:28 SudoAptGetPlay :D
17:30 Ritchie joined #minetest-dev
17:31 shadowzone joined #minetest-dev
17:33 celeron55 fz72: are you knowledgeable of launchpad?
17:33 fz72 no that's the problem
17:33 celeron55 i would prefer if i wouldn't have to go there and change things because i don't have any idea about anything
17:34 celeron55 we need to outsource the launchpad builds, it's not interesting to minetest upstream developers and doesn't need to be
17:34 fz72 me too I looked at it after the release of 0.4.11 but I didn't find the issue
17:34 celeron55 can someone go on some ubuntu channel and beg for someone to take over it
17:35 fz72 what do you mean with outsource?
17:35 celeron55 i mean, like, someone outside of the core team should do the launchpad builds independently
17:35 celeron55 it's just an annoyance that we have to do it
17:35 celeron55 our policy is to not do distro specific things and somehow this ended up as our task regardless
17:36 fz72 ok thanks
17:36 celeron55 i... guess we could just stop updating it and wait for someone to come and ask what's up, and tell him to take it as the one with the question is obviously interested in maintaining it 8)
17:39 celeron55 holy fuck #ubuntu has 1814 users
17:41 celeron55 i don't think that's a good place to ask though; we should make a secondary announcement about this after the release is announced
17:42 Calinou #bitcoin has 1204 only, it used to have more than #ubuntu
17:44 celeron55 can someone confirm that freeze-0.4.12 still builds for windows?
17:45 celeron55 android might be broken but we don't have the resources to handle it now; windows is important though
17:45 fz72 what about #launchpad?
17:46 celeron55 hmm... i don't see why it wouldn't build after latest commits; i will do the branch juggling for the release now
17:47 celeron55 i need to know one thing before doing this though
17:47 celeron55 should the version bump commit be pushed to stable-0.4 once freeze-0.4.12 has been merged on it, or should it be pushed to freeze-0.4.12 before merging it to stable-0.4?
17:48 celeron55 what does this even mean regarding to the tag and deletion of freeze-0.4.12 afterwards
17:48 celeron55 and the future merging of master to stable-0.4
17:49 ShadowNinja I'd bump on freeze-, then merge.
17:49 kilbith celeron55, PilzAdam is knownledgable on Launchpad
17:50 celeron55 kilbith: no he isn't; you can ask him to confirm :P
17:50 PilzAdam no, he isn't
17:50 kilbith he did update the last 12.04 builds iirc
17:50 PilzAdam my job is to press the big green "Build" button when we release
17:51 PilzAdam and then big red exclamation marks start to pop up
17:51 celeron55 that just about also describes my knowledge level of launchpad
17:51 PilzAdam and then I cry a bit and ask other people to help me
17:57 nrzkt joined #minetest-dev
17:59 nrzkt celeron55: have you find somebody for windows build ?
18:00 Robert_Zenz joined #minetest-dev
18:00 celeron55 i don't worry about that, it doesn't have to happen immediately
18:01 nrzkt i launch a build for win32 on jenkins
18:01 nrzkt http://jenkins.unix-experience.fr/​job/minetest-windows-x86_release/*
18:01 nrzkt without the * :)
18:02 nrzkt at the end you will see it thank works properly
18:02 celeron55 0.4.12 is now on stable-0.4
18:03 celeron55 we actually have one option now to consider; the option is rebasing master on freeze-0.4.12 to get linear history at next release
18:03 nrzkt i think some things will break
18:03 celeron55 the obvious con is that people will have to force-pull; the obvious pro is that then stable-0.4 will have linear history at next release
18:03 celeron55 (force-pull master)
18:04 ShadowNinja celeron55: Just use a merge.
18:04 Calinou you should make your Jenkins public, nrzkt
18:04 ShadowNinja It's there to be used after all.
18:04 Calinou would help us immensely to have automatic daily builds
18:04 celeron55 ShadowNinja: yes, that's what will happen if this option is not used now
18:04 Miner_48er joined #minetest-dev
18:04 celeron55 i think this option won't be used
18:04 nrzkt Calinou: why do you my jenkins to be public ?
18:05 Calinou automatic daily builds, usable by everyone
18:05 Calinou probably won't cost you too much bandwidth
18:05 guest365 joined #minetest-dev
18:05 nrzkt i'm not the project owner. No my server has 1Gbps of bandwidth but there is 8 other freebsd jails, my minetest server, a mumble and all my web and mail infrastructure with a LDAP directory :)
18:06 celeron55 can you implement automatic uploading of the build if i provide a main distribution host for it?
18:06 celeron55 if bandwidth is the issue
18:06 celeron55 if not then that doesn't matter
18:07 nrzkt no bandwidth issue :) CPU issue maybe if the jenkins ocmpiles with all cores, but i limit him to 2 cores, 6 others cores are for my own usage and we don't need so many compilations
18:07 nrzkt but if you want we could do an upload to external server for daily builds yes
18:08 celeron55 okay whatever, i'm not interested in getting that set up right now anyway; but a public daily build is definitely something to consider in the future
18:08 nrzkt at this time i can compile for : win32, FreeBSD 10 to 8, and linux (based on Centos 6 FreeBSD kernel compat)
18:09 celeron55 in any case: the release is now there; assuming nobody finds a problem in the next half an hour, it's what people can build their builds from
18:09 celeron55 and somebody should also post news on the forum once we have an official-worthy windows build on our hands
18:10 celeron55 oh also, we need a minetest_game 0.4.12 tag
18:10 celeron55 sfan5? nore?
18:10 nrzkt git was tagged ?
18:10 celeron55 yes, the tag is there
18:10 nrzkt ok i send the PR to FreeBSD ports team
18:11 sfan5 were realeasing right now
18:11 sfan5 ?
18:11 celeron55 ok
18:11 celeron55 i mean, yes we are; minetest 0.4.12 is now in stable-0.4
18:11 sfan5 i guess i should keep an eye on this chat more often
18:11 celeron55 i assume you have a stable version of _game available
18:11 sfan5 nore: is minetest_game tagged?
18:12 sfan5 HEAD of minetest_game should work
18:12 sfan5 (work = be stable)
18:12 celeron55 you have to tag it and merge in minetest_game's stable-0.4
18:12 rubenwardy joined #minetest-dev
18:12 celeron55 i can do it if you ask me to do it
18:13 sfan5 I'll do it
18:14 nrzkt strange the tagged archive has lost 1.3MB
18:14 compunerd joined #minetest-dev
18:15 sfan5 a9ac480..03c00a8  stable-0.4 -> stable-0.4
18:15 sfan5 * [new tag]         0.4.12 -> 0.4.12
18:15 sfan5 done
18:17 celeron55 i would like to do one request informally now that 0.4.12 is done and i will move back to working on stuff outside minetest
18:18 sfan5 celeron55: public daily builds can be made on any vps (for any ubuntu version) and for win32 and win64
18:18 sfan5 using the scripts travis uses
18:19 nrzkt what are the most importants points of 0.4.12 release ?
18:19 sfan5 hm
18:20 sfan5 do we have a complete changelog?
18:21 celeron55 we don't; Calinou: do you have time for updating the changelog like you've done previously?
18:21 Calinou I need to keep track of all changes
18:21 Calinou I'll use gitg to view Git log and see what I'll add
18:22 celeron55 this seems like quite a regular sized release based on the log length
18:24 celeron55 anyway the request for 0.4.12+1 is: could we please have a proper system in the menu for viewing descriptions about games and possibly support the required world resets for wuzzy's tutorial game so that we can finally include multiple games with the releases in a way that regular users will understand?
18:25 celeron55 this has had to be hold up for rather long already and it's hanging on those few missing engine features
18:26 nrzkt network rework will be part of 0.4.12+1 or not ?
18:26 sfan5 -- *** Will build version 0.4.12 ***
18:26 sfan5 hey it actually worked on the first try
18:26 celeron55 nrzkt: so far there's no reason not to; but it will of course be decided dynamically as development progresses
18:27 celeron55 i.e. yes, it can be aimed for
18:28 nrzkt okay. atm PR 3/4 has been reviewed and need some improvements. It only breaks the network protocol, not the network layer. For the network layer i only need to resolve big packet send/receive issue and add some sleep into my client threads to reduce the cpu usage on loops
18:29 sfan5 #define CMAKE_VERSION_GITHASH "0.4.12-dirty"
18:29 sfan5 f
18:29 nrzkt i rewrited the socket layer (except address class), and the clientiface interface to split it in three parts, because some parts aren't part of the new clientsession system
18:29 sfan5 it always does this
18:29 ShadowNinja nrzkt: Do you use a polling loop?
18:29 ShadowNinja (check for data, wait, repeat)
18:30 nrzkt no i'm using threads with socket reads, i studied polling but not testing it yet. I need to look at each option
18:30 ShadowNinja Good, using select() or similar is better.
18:30 nrzkt each client has its own thread and received packet on a client is set into the global server queue
18:31 nrzkt and socket sending doesn't uses a queue, server send it itself using the opened socket
18:33 nrzkt but i'm not working on it atm, i need to review patch 3/4 and found some bottlenecks in core with callgrind using TNT to test it :)
18:33 celeron55 sleep sounds like a wrong thing; you should be using timeouts
18:33 nrzkt timeouts based on what ?
18:34 celeron55 probably select()
18:34 nrzkt oh then i need to review the design, but it's not very difficult
18:34 celeron55 if you want to keep the existing structure you can just select() in each individual receiving thread i guess
18:35 est31 joined #minetest-dev
18:35 celeron55 not a big deal
18:35 nrzkt i need to test all options for maximum performance, and i also need to resolve the packet spliting issue for large packets :)
18:36 Krock2 joined #minetest-dev
18:37 ShadowNinja nrzkt: It would be better to have one thread listen on all sockets.
18:37 sfan5 uploading win(32|64) binaries now
18:37 nrzkt if we use select, i think so
18:44 ShadowNinja nrzkt: For speed, epoll (Linux), or kqueue (BSD), should be used for more than a few sockets.  There are libraries like libevent that handle this in a cross-platform way (I'm reading http://daniel.haxx.se/docs/poll-vs-select.html ).
18:46 sfan5 uploaded the builds: https://github.com/minetest/minetest/rel​eases/tag/untagged-dfa1112e150764ff79de
18:46 est31 404 4 me
18:47 BlockMen est31, since its not published yet ;)
18:47 sfan5 you're not a dev you can't see that
18:48 est31 Ok
18:48 celeron55 ShadowNinja: well frankly select is plenty fast for minetest's purposes
18:49 celeron55 and portable
18:49 celeron55 none of the others are
18:49 celeron55 it's 404 for me too
18:50 BlockMen because i removed the missing msvc :P
18:50 BlockMen *text
18:51 BlockMen so the hash changed
18:51 nrzkt FreeBSD : https://bugs.freebsd.org/bug​zilla/show_bug.cgi?id=197797
18:52 sfan5 BlockMen: your zip file should be named minetest-0.4.12-win32-msvc.zip
18:53 BlockMen why? who cares?
18:53 BlockMen no user profits of that info
18:58 celeron55 well, if sfan5 removed it from his, then nobody would know which one is which
19:00 celeron55 can i have permission to host the main windows builds for this release? i would like to count the downloads and github doesn't give those statistics
19:00 MinetestForFun joined #minetest-dev
19:00 sfan5 sure
19:00 celeron55 i do have a stable server with plenty of bandwidth in europe so it's probably not that terrible for users
19:01 BlockMen celeron55, if you want to
19:01 MinetestForFun joined #minetest-dev
19:01 celeron55 altough... just some javascript to count the clicks on the website would probably be enough for tracking
19:02 celeron55 i really want to get an update on my idea of how many downloads these get
19:02 ShadowNinja celeron55: Sounds good -- as long as we get to see those stats.  :-)
19:02 celeron55 last time i was able to see it years ago
19:02 nrzkt celeron55 you can provide a download link on minetest.net which counts and refers to github :)
19:02 ShadowNinja celeron55: Are you using nginx?
19:02 BlockMen is anything missing or can i post it on forums when you done your hosting, celeron55?
19:03 celeron55 nrzkt: i don't like those because you can't right click and copy address to wget/curl
19:03 celeron55 ShadowNinja: yes
19:03 nrzkt if you use a proper 302 it works very well
19:03 ShadowNinja celeron55: If so, you can set up a special access log in a location block and just pass the log through a python script to generate graphs or something/
19:04 celeron55 you can test download from the server here (it's the experimental android package i made which is very large; i'll remove it some day): http://packages.8dromeda.net/minetest/
19:04 nrzkt or you can simple parse your logs :p
19:04 ShadowNinja You should probably tweak the log format though, nginx's default isn't great.
19:04 sfan5 a redirect would allow you to count the downloads and would retain the security of githubs https
19:05 celeron55 hmmh... well i guess i could just do a redirect
19:05 est31 how is it secure when http://minetest.net can point to another link?
19:05 celeron55 it'll be just this release anyway, maybe next time next year :P
19:05 ShadowNinja location /minetest/ { access_log /var/log/nginx/minetest_downloads.log; }
19:05 est31 everything needs to be https, weakest link matters
19:06 est31 (if that is important)
19:06 ShadowNinja est31: minetest.net is no-TLS.
19:06 ShadowNinja (/SSL)
19:06 sfan5 actually thats correct
19:06 celeron55 i wonder if github would give the stats if we asked
19:07 nrzkt it's not a problem to redirect HTTP to HTTPS links with proper 302, but the other ways is unsecure
19:07 ShadowNinja Maybe, if they record them.
19:07 celeron55 i'm sure they record them; all data is valuable these days
19:07 celeron55 github is a business
19:08 ShadowNinja celeron55: Well, in a format that can be turned into something that they can give you easily.
19:08 ShadowNinja I'm sure they have logs, but they might not use them for dl stats.
19:09 celeron55 it's sad because previously their upload functionality (that they removed and later replaced with the releases) had visible stats
19:09 nrzkt celeron55: maybe only for business accounts ?
19:10 OldCoder joined #minetest-dev
19:10 est31 http://stackoverflow.com/questions/17971​193/track-number-of-download-of-a-releas​e-binaries-on-github/19486509#19486509
19:12 est31 curl -i  https://api.github.com/repos​/minetest/minetest/releases -H "Accept: application/vnd.github.manifold-preview+json"
19:12 est31 ^this does it
19:13 celeron55 looks to be working
19:13 celeron55 okay so i don't need to do anything
19:14 electrodude512 joined #minetest-dev
19:15 est31 minetest-0.4.11-win32-mingw.zip downloaded 19626 times and minetest-0.4.11-win64-mingw.zip 13564 times
19:16 Calinou total: 33,190
19:17 BlockMen sfan5, did you rename the zips?
19:17 Calinou 41 % of 64-bit downloads
19:17 celeron55 0.4.11 has about 35k downloads, 0.4.10 has 130k, 0.4.9 has 167k, 0.4.8 has 40k
19:17 sfan5 BlockMen: yes
19:17 BlockMen lol
19:17 celeron55 just quickly browsed through it and summed up rough numbers
19:17 BlockMen good job, confuse the users
19:17 Calinou you could add on minetest.net: “More than 40,000 downloads for 0.4.11” :p
19:18 celeron55 BlockMen, sfan5: please stop being silly, this helps nobody
19:18 Calinou or “more than X downloads last year”
19:18 celeron55 i'm not going to publicly brag with these, it's not really appropriate
19:20 celeron55 anyhow, that's the rough size of the windows userbase
19:20 celeron55 it's not huge for a free program but it surely exists
19:21 nrzkt you need to add linux and freebsd downloads too :)
19:22 celeron55 those are much harder to count
19:23 nrzkt for freebsd you count the release tag on github
19:24 selat joined #minetest-dev
19:26 cib0 joined #minetest-dev
19:26 celeron55 0.4.11 has about ~20k/month, 0.4.10 has ~24k/month, 0.4.9 has ~33k/month, 0.4.8 has ~30k/month (can't be bothered with accurate numbers, these are like +-30%)
19:27 celeron55 i can definitely see a slowly decreasing trend though
19:28 celeron55 (0.4.8 was released 24 Nov 2013)
19:32 celeron55 also i have nobody to blame because the releases haven't been that impressive from a regular player's standpoint lately; the engine is fine, but minetest_game isn't doing it anymore
19:33 nrzkt joined #minetest-dev
19:33 rubenwardy I agree. Subgames that come with Minetest need to utilise the engine more and show it off
19:34 kilbith VoXus could be an excellent showcase
19:34 ShadowNinja celeron55: Do you have stats for the website?  Google trends isn't very detailed.
19:35 celeron55 ShadowNinja: not good ones, especially as i recently moved the site to another host
19:35 nrzkt rubenwardy: what would you mean ? i will work with community into that after networking merge finish, that and improvements. I think you'll need more high level APIs for some complexe things
19:36 ShadowNinja celeron55: Would you add Google analytics code if I set it up?  (there's a simple dokuwiki plugin for it)
19:36 celeron55 i wonder if people would be fine with google analytics; it's free and would give good long-term stats without any effort from my part
19:36 paramat joined #minetest-dev
19:37 est31 can we use piwik instead?
19:37 rubenwardy They wouldn't be
19:37 rubenwardy ^^
19:37 celeron55 google analytics is a bit shady in my opinion
19:37 rubenwardy Yes, Piwik is good
19:37 rubenwardy Showing off mesh nodes, particles, entities, vehicles, physics (set_player_physics), etc
19:37 nrzkt google analytics for an opensource project :(.
19:37 rubenwardy (nrkt)
19:37 ShadowNinja I looked at Piwik, but it was PHP, so I stopped there.
19:37 rubenwardy Yeah, don't do that. Use Piwik, if you can
19:38 celeron55 ShadowNinja: well, dokuwiki is PHP too so... lol
19:39 ShadowNinja celeron55: Yeah, I try to avoid PHP, but it's pretty popular despite how bad it is.
19:39 rubenwardy PHP is okay as long as you don't need to program in it
19:39 * est31 doesnt contribute to flamewar
19:40 ShadowNinja piwik.org's down :-(
19:40 est31 noot for me
19:40 celeron55 this works at least http://developer.piwik.org/gui​des/tracking-javascript-guide
19:40 nrzkt PHP > java :p
19:41 celeron55 oh well, in any case i won't set it up now; i'm open to other suggestions though
19:41 celeron55 but the mission is getting long-term statistics of dokuwiki visitors
19:41 nrzkt for dokuwiki it's native, no ? you needs the page reads or more ?
19:42 celeron55 this is a native piwik plugin: https://www.dokuwiki.org/plugin:piwik
19:42 celeron55 whatever "native" means :P
19:42 paramat since hmmmm is not around please could someone review and possibly merge https://github.com/minetest/minetest/pull/2267 ? it's to make custom/future noiseparams in mgv7 more useful
19:42 nrzkt oh sorry :) piwik is a plugin for dokuwiki, i thought it was an alternative to dokuwiki
19:43 celeron55 oh... one thing
19:43 celeron55 i won't use mysql and piwik only supports mysql
19:43 celeron55 postgresl is fine
19:43 celeron55 +q
19:43 nrzkt paramat: your fix seems to be fine, but it won't generate some plate zones ?
19:43 nrzkt +1 for pgsql
19:44 celeron55 mysql is the PHP of databases and in my opinion it's basically deprecated by postgresql
19:45 nrzkt s/plate/flat/
19:46 nrzkt but i agree with your commit. I could not merge it this evening. if nobody do it, i'll do it tomorrow
19:47 ShadowNinja celeron55: Maybe I'll set it up on one of my servers, but it will probably be fast as molasses.
19:48 Calinou use MariaDB if you don't like MySQL
19:48 celeron55 it uses the same broken design
19:53 celeron55 i added paramat to the core team on github; prepare for destruc... i mean, i did that and he'll probably take the mapgen maintainer's place
19:54 celeron55 now i go elsewhere ->
19:55 paramat nrzkt no, my PR won't change current default terrain. also, mountains rise out of the 2D noise terrain, so when mount height noise is held at zero they simply disappear leaving the smooth rolling 2D noise terrain
19:55 paramat heh
19:55 VanessaE oh boy....
19:56 paramat only while hmmmm is gone though, i miss him and hope he returns
19:56 VanessaE paramat: so, paragen for the default mapgen v7 setup in 0.5.0? :P
19:57 est31 as hmmm is gone can sb review #2225 pls? nrzkt has already sb else?
19:57 ShadowBot https://github.com/minetest/minetest/issues/2225 -- Fix for getCraftRecipes implementation is very slow by gregorycu
19:57 nrzkt i don't talk about current terrain, but future terrain :) no problem paramat
19:57 * paramat feels a little lost without his senpai
19:58 nrzkt i need to test it for performances, can someone tell me how can i will test it easily ?
19:59 est31 2225 ?
20:00 VanessaE run dreambuilder, see how long it takes to start up.
20:00 VanessaE then yank unified inventory out of it and compare.
20:01 VanessaE nrzkt: ^^
20:01 est31 this gist extracts the relevant parts : https://gist.github.com/est31/f4ad8d4403f29ca230e3
20:02 VanessaE I've never taken notice of any difference, but unified inventory has a craft guide and well there's thousands of recipes to reads into it thanks to that game.
20:02 VanessaE -s
20:02 blaze joined #minetest-dev
20:10 nrzkt on creative the problem is also relevant or only in adventure ?
20:11 VanessaE s/adventure/survival/; I'd guess the mode doesn't matter?
20:12 est31 how can I reproduce that
20:12 est31 because I cant
20:12 ShadowNinja Apparently my glibc is too old to run mariadb.
20:23 est31 and for the php discussion: minetest still uses a php based forum
20:25 dzho joined #minetest-dev
20:26 ShadowNinja There's a postgresql fork of piwik, but it's a year old.  https://github.com/piwik/piwik/issues/500
20:27 ShadowNinja est31: Yes, tell me when you find some good full-featured forum software that has a fairly large community and isn't PHP.
20:28 est31 what about nodebb? demo: http://bitbangers.co.uk/
20:29 est31 quite nice topic urls: http://bitbangers.co.uk/topic/100
20:30 ShadowNinja est31: Maybe, I'll have to look into it.
20:34 ElectronLibre_ joined #minetest-dev
20:40 ShadowNinja Might be O.K., providing the moderation features are good.
20:43 paramat okay i guess i'll merge #2267 later once i learn how to
20:43 ShadowBot https://github.com/minetest/minetest/issues/2267 -- Mgv7: Add lower limit of zero to mountain height noise by paramat
20:45 Calinou thanks a lot for increasing default font size
20:57 ShadowNinja Seems like there are no good open-source non-mysql analytics options.
20:58 ShadowNinja I'm no fan of proprietary software, but Google analytics works, has a lot of features, and is easy.
21:00 jan64 joined #minetest-dev
21:00 est31 Main issue is not that its not open source, the problem is that google gets data
21:05 Calinou ShadowNinja, please don't present it here as excusable
21:05 Calinou use Piwik
21:05 Calinou use MySQL
21:05 Calinou or just don't use analytics…
21:05 Calinou you don't need to ANAL your users all the time
21:05 Calinou especially for non-commercial projects
21:06 * est31 visits arte.tv to find out whether they still use analytics
21:06 est31 yes :(
21:07 Calinou it can be blocked, but it doesn't mean usage of GA is acceptable
21:07 Calinou http://github.com/gorhill/uBlock
21:07 twoelk joined #minetest-dev
21:11 ShadowNinja *sigh*
21:13 Miner_48er joined #minetest-dev
21:20 BlockMen whats the state of the changelog?
21:21 nore I'm not sure it has been updated
21:21 VanessaE it has not been.
21:22 VanessaE Unless someone's got a draft they haven't committed to the page yet.
21:25 roniz joined #minetest-dev
21:27 nrzkt Calinou ?
21:27 Calinou VanessaE, I will work on it when I have time (in 1 or 2 days)
21:28 BlockMen so will we release anyway today?
21:28 Calinou feel free to
21:28 Calinou changelog is not essential
21:28 VanessaE Calinou: check with shadowzone also.  somehow she volunteered/got elected to do the changelog (!)
21:28 Calinou oh
21:29 VanessaE (I'm not sure she's actually qualified for that task, but who knows?)
21:29 swaaws joined #minetest-dev
21:29 BlockMen nore, ShadowNinja: releasing now ok?
21:30 nore yep
21:30 VanessaE BlockMen: I'm still waiting for a reply from MichaelEh about that -rc build.  Can we at least agree to additional bugfixes in the 0.4.x branch if they're needed?
21:31 ShadowNinja BlockMen: We've already released.
21:31 BlockMen VanessaE, i dont think we should delay release because of one user
21:31 BlockMen ShadowNinja, then i will post it on forums
21:31 VanessaE BlockMen: no, don't delay.  I mean additional point releases afterward.
21:31 VanessaE ShadowNinja: 0.4.12 builds are not linked to minetest.net/download
21:32 BlockMen VanessaE, AFAIK we dont do that
21:32 VanessaE BlockMen: we've done it before?
21:32 BlockMen we did? when?
21:32 nrzkt c55 has declared the release and we don't delay it
21:32 VanessaE BlockMen: way back early on
21:33 VanessaE I can't remember the version, but there was an extra point release right after it, within a week or two if I remember right
21:33 BlockMen oh, the draft on github is not released aswell
21:33 VanessaE 0.4.x.1 or something like that.
21:33 * BlockMen does that
21:34 BlockMen ok, released on github and forum
21:34 Amaz joined #minetest-dev
21:35 sfan5 VanessaE: github says 0.4.0 and 0.4.1 were both released on the same day
21:36 sfan5 you probably mean those
21:36 VanessaE sfan5: yep, that was probably it
21:36 VanessaE also whatever that "-d1" release was from around that time
21:38 sfan5 huh
21:38 sfan5 https://github.com/minetest/m​inetest/releases/tag/0.4.8.0
21:38 sfan5 https://github.com/minetest/minetest/commi​t/3bb4c797f615c46204a18358a559b148c9a8a2a5
21:38 sfan5 what is that and why is there a tag?
21:39 VanessaE probably to allow fm to use 4-part version numbers :P
21:39 sfan5 what? no
21:39 sfan5 https://github.com/minetes​t/minetest/commits/0.4.8.0
21:39 Miner_48er joined #minetest-dev
21:39 VanessaE I'm kidding.
21:39 sfan5 looks like an early version of freeminer
21:40 sfan5 that - for some reason - is in minetest/minetest
21:40 nore wtf??
21:40 sfan5 https://github.com/minetest/minetest/commi​t/8cebce8d372400aa67a9328b05a80f3e0ac77e8e
21:40 sfan5 i kinda like that commit
21:40 sfan5 put everything into a try-catch
21:41 sfan5 when there is an error just print "Fatal error" and continue
21:41 VanessaE sfan5: sounds like your "check engine" light. :P
21:41 est31 current behaviour isnt good either
21:41 est31 server should at least say good bye to clients
21:41 sfan5 VanessaE: the problem is that a game server is not like a car
21:42 BlockMen website updated aswell
21:42 sfan5 anyway, I'll delete the 0.4.8.0 tag
21:42 VanessaE agreed (on both)
21:42 sfan5 done
21:45 sfan5 do we delete the freeze-0.4.12 branch now?
21:45 est31 no why
21:45 est31 that would be deleting code
21:45 sfan5 I also wonder what purpose stable-0.2 serves
21:46 nore there are things in master that are not in freeze-0.4.12
21:46 sfan5 est31: the stable-0.4 branch contains the same as freeze-0.4.12
21:46 VanessaE I believe the official word on that was to merge it as appropriate and tag it for the 0.4-stable branch or something
21:46 est31 ah ok
21:46 nore so it has to stay
21:46 est31 then its ok
21:46 BlockMen paramat, http://dev.minetest.net/Git_Guidelines
21:46 paramat i just merged 2267 to master branch, now on the commits page it shows 2 entries, i did somethiing wrong?
21:47 Calinou weren't we supposed to use semver from now on?
21:47 * paramat reads
21:47 sfan5 BlockMen: maintainers may make(?) changes in their maintened subsystemd
21:47 sfan5 systems*
21:47 sfan5 w/o needing other people to agree
21:47 est31 systemd lol
21:47 sfan5 :D
21:48 BlockMen sfan5, i was meaning this: Use rebase, not merge, to get linear history.
21:48 sfan5 paramat: there is a "Merge bla bla bla" commit, so .. exactly that ^
21:48 BlockMen so we dont mess the history with "merged pull ..."
21:48 celeron55 remove those commits before someone pulls them
21:48 sfan5 VanessaE: the stable-0.4 branches and freeze-0.4.12 are identical
21:49 est31 yea but 0.4.12 should be tagged at least my opinion
21:49 celeron55 well i removed them now
21:49 sfan5 f92540e..7993a40  freeze-0.4.12 -> origin/freeze-0.4.12
21:49 sfan5 3f83ca2..7993a40  stable-0.4 -> origin/stable-0.4
21:49 sfan5 ^ VanessaE
21:49 sfan5 est31: 0.4.12 is also tagged
21:49 paramat sorry
21:50 celeron55 paramat: this didn't actually surprise at all, i should have said the most important rules but i didn't so whatever
21:50 est31 then its ok
21:50 paramat okay =)
21:50 sfan5 celeron55: do we delete the freeze branch now that we've released?
21:51 celeron55 yes
21:51 sfan5 ok
21:51 sfan5 - [deleted]         freeze-0.4.12
21:51 paramat thanks for removing my dodgy commits
21:52 celeron55 i use this short script for merging pull requests: http://fpaste.org/187251/42429632/
21:52 celeron55 doing that by hand is easy too but i'm the laziest person on this planet
21:52 sfan5 you bothered to create a script for 2 commands?
21:53 VanessaE sfan5: ok
21:53 celeron55 sfan5: it's a 2-line script that will save me one line for each pull request; profit!
21:54 sfan5 obligatory relevant xkcd: http://xkcd.com/1205/
21:55 * paramat reads script
21:55 est31 same as referenced in http://dev.minetest.net/Git_Guidelines#Notes
21:55 celeron55 sfan5: yes according to this table, this was completely reasonable
21:57 sfan5 i guess i have nothing to say against your 2-line script then ;)
21:58 BlockMen suddenly i realized i need at least 10 times longer for same tasks with git :\
21:58 paramat so merging must be done in terminal by command line using those commands? and in which directory?
21:58 sfan5 in a clone of upstream
22:00 sfan5 git clone git@github.com:minetest/minetest.git; cd minetest; wget <pull url>.patch; git am somefile.patch; git push
22:00 celeron55 paramat: basically, check that you have a fresh and clean master branch of minetest at your current directory, and then do that
22:00 sfan5 the patch url would be https://github.com/minetes​t/minetest/pull/1234.patch for pull #1234
22:00 ShadowBot https://github.com/minetest/minetest/issues/1234 -- Client side caching of mapblocks
22:00 celeron55 then you will have appended the PR's commits locally and can check it and push if it's good
22:01 paramat thanks!
22:01 celeron55 if it ends up being not good, "git reset --hard HEAD^" will remove latest commit locally (completely permanent delete)
22:01 celeron55 make sure you have a good git viewer program like gitk
22:01 BlockMen btw git, do we rebase master onto stable now?
22:01 BlockMen if not, do we have to do it next release then?
22:01 celeron55 BlockMen: it was decided that it won't be rebased
22:02 kilbith celeron55, versionning ain't bumped on master
22:02 celeron55 and that at next release stable-0.4 will have a merge commit
22:02 BlockMen celeron55, ok
22:03 celeron55 kilbith: oh, oops...
22:03 celeron55 someone can do that
22:09 Miner_48er joined #minetest-dev
22:09 est31 merge commit for stable-0.*4* ??
22:09 est31 not stable-0.5 then?
22:11 nrzkt don't know
22:11 nrzkt which file to modify celeron ?
22:13 ShadowNinja celeron55: Piwik set up @ stats.inchra.net.  Site ID is 1.
22:13 celeron55 nrzkt: cherry-picking the commit from stable-0.4 is your best bet
22:14 est31 but a line should be commented back in
22:14 est31 as suggested here : https://github.com/minetest/minetest/commi​t/7993a403f2c17a215e4895ba1848aaf69bb61980​#diff-af3b638bc2a3e6c650974192a53c7291L21
22:15 nrzkt right :) i don't know about check pick command but i try it
22:15 est31 or not, not knowing process too well just saw that ocmment
22:15 est31 comment*
22:15 celeron55 oh, well, cherry-pick and edit that out from the commit or something
22:20 Calinou ShadowNinja, thanks
22:21 ShadowNinja YW.
22:23 shadowzone joined #minetest-dev
22:32 alexxs joined #minetest-dev
22:37 Amaz joined #minetest-dev
22:38 paramat left #minetest-dev
22:39 proller joined #minetest-dev
22:52 ElectronLibre left #minetest-dev
23:04 kilbith celeron55, up-to-date with master : https://lut.im/gCPvGdNw/4Ix00JFJ
23:04 Amaz I can confirm.
23:04 kilbith same on 0.4.12-stable
23:04 kilbith and GUI_scaling at 1.0
23:04 VanessaE I already mentioned that earlier.
23:05 kilbith terrible :(
23:05 VanessaE the formspec needs scaled down to about 84 percent of its current size.  the decision was made not to bother because no one plays at 800x600.
23:06 kilbith in that state, the formspec is static in all resolutions
23:07 Amaz I play at 800x600... :P
23:07 kilbith me too
23:07 kilbith even at 1280x800 windows, the formspec is way too large and goes over the header
23:09 celeron55 the size simply needs to be clamped to the maximum that fits the window
23:09 celeron55 in all other window sizes than too small ones, it behaves about right on desktop now
23:10 celeron55 but please don't hilight me unless really necessary
23:10 kilbith not everybody likes to play at max. resolution (we lost some FPS moreover)
23:11 VanessaE kilbith: that's because the header scales with window width (it should scale with the smaller of the two dimensions, and clamp to the available space)
23:12 * est31 has onboard gfx and plays at 800x600 so that he can monitor chat channels & so on. never fullscreen
23:15 kilbith yes, it's a problem with the header then...
23:15 celeron55 anyway just so that most people know: i won't touch minetest in a week now; don't hilight me unless it's something really important that nobody else can do
23:17 BlockMen left #minetest-dev
23:24 proller joined #minetest-dev
23:36 shadowzone joined #minetest-dev
23:37 shadowzone Shouldn't someone change the topic?
23:40 est31 ~topic #minetest-dev
23:40 ShadowBot est31: FEATURE FREEZE FOR 0.4.12 IN EFFECT.  Release date: soon™ | Minetest core development and maintenance. Chit-chat goes to #minetest. Consider this instead of /msg celeron55. http://irc.minetest.ru/minetest-dev/ http://dev.minetest.net/
23:40 est31 ~topic #minetest
23:40 ShadowBot est31: Welcome to #minetest, the official channel of Minetest | Version: 0.4.12 (2015-02-18) | Responses may take a while, so be patient. | Rules: http://wiki.minetest.net/IRC#Rules | Development: #minetest-dev | Server list: http://minetest.net/servers | IRC logs: http://irc.minetest.ru/minetest/
23:40 est31 yea :/
23:52 harrison joined #minetest-dev
23:52 harrison joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext