Time Nick Message 05:42 gregorycu Anyone know much about Lua VoxelManip? 05:45 * gregorycu looks in hmmmmm 's general director 05:45 gregorycu direction 08:35 nrzkt ShadowNinja, nore ? 08:35 nore yes? 08:35 nrzkt ok for #2317 ? 08:35 ShadowBot https://github.com/minetest/minetest/issues/2317 -- Add an option to disallow guest connection (disabled by default) by nerzhul 08:39 nore it looks good 08:39 nrzkt thanks, i merge it 08:39 nore just a question: why == false 08:39 nore and not ! 08:39 nore ? 08:39 nrzkt i prefer == false for faster code reading 08:40 nore hm... I personally find it ugly 08:40 nore I don't know if we have guidelines about this 08:40 gregorycu Could be worse 08:40 gregorycu Could be == true 08:40 nrzkt you talk about : if (string_allowed(playername, PLAYERNAME_ALLOWED_CHARS) == false) { 08:40 nrzkt ? 08:40 gregorycu (Which I have seen) 08:40 nore yep 08:40 nrzkt it's not my code there, i just fixed the space :) 08:41 gregorycu It's funny, for me, the ! means I invert the thing as I read it 08:41 nore yeah, I saw that, but you can fix that while you're at it :) 08:41 gregorycu So I read it as "string not allowed" as opposed to "string allowed equals false" 08:42 nrzkt i don't see many code with ! operator, generally it's == false, then i kept the same coding style 08:42 gregorycu lol, really? 08:42 gregorycu Is most of the code you see your own? 08:44 nore ok, it looks like we haven't style guidelines about this 08:44 nrzkt ofc nore :) 08:44 gregorycu Why ofc? 08:47 nore grepping the code gives about 10x more ! than == false 08:47 nore 2000 vs 200 08:54 nrzkt okay nore, i think we must have a guideline for this, i'll talk with celeron55 about this 08:55 nore but anyway: as soon as that is sorted out, you can merge it 08:56 celeron55 well we will obviously say the guideline is ! 08:57 nrzkt oh, celeron55, you are there :D. What is the guideline ? code 2000 vs 200 or not ? 09:00 celeron55 the one that is used the most already 09:00 sfan5 nrzkt: regarding the PR from yesterday: I don't think it's necessary to have guest-checking in the core 09:00 nrzkt okay, then i'll use the ! operator. 09:01 hmmmm ... 09:01 hmmmm this is so stupid 09:01 hmmmm the guidelines should just tell you what not to do 09:01 nrzkt we must have a unified coding style hmmmm. 09:02 hmmmm and on that note i'm out 09:03 nrzkt lol.... hmmmm, the refusator :p 09:05 celeron55 his the point is, this does not actually matter and i kind of agree 09:07 nrzkt then for checking == false, what must i do ? ! or == false ? please tell me for future code 09:07 celeron55 meaning this should never even be discussed and both should always be accepted based on trusting whoever happens to make the code to have a brain 09:08 celeron55 you can use the fact that ! is used the most as a guideline 09:08 sfan5 all other code uses !expr so you should use !expr 09:08 celeron55 like i already said 09:11 nrzkt then i go to the weight :p 09:42 gregorycu I see 100 open bugs, I think we need to have better priorities than talking about == false vs ! 09:43 gregorycu :) 09:43 nrzkt i looked at all but i cannot solve all 09:43 gregorycu Sure you can 09:44 gregorycu Have some faith in yourself 09:47 gregorycu #1193 looks strange, I wonder if I can fix that 09:47 ShadowBot https://github.com/minetest/minetest/issues/1193 -- Issues with fog. 10:00 nore oh, btw: is the bug with the debug menu that the top texture is always shown and not the pointed texture known? 16:00 rubenwardy #2299 16:00 ShadowBot https://github.com/minetest/minetest/issues/2299 -- Fix minetest.item_eats replace_with_item, fixes #2292 by rubenwardy 16:00 rubenwardy updated 16:07 luizrpgluiz would be possible to fix the bad alock 16:38 nrzkt i made a huge performance improvement in getFacePositions, please review #2321 16:38 ShadowBot https://github.com/minetest/minetest/issues/2321 -- Performance Improvement: Use a factory which caches result for getFacePositions. by nerzhul 16:39 nrzkt the operation gains comes is divided by 1000 16:39 nrzkt and only for my test, i could be greater for real servers because i depend of mods 16:40 est31 nrzkt, comments on #2225 ? is style ok now? 16:40 ShadowBot https://github.com/minetest/minetest/issues/2225 -- Fix for getCraftRecipes implementation is very slow by gregorycu 16:42 nrzkt style is ok, but i cannot review this part of the code i haven't studied it 16:44 est31 ok, can you add that as comment? 16:46 nrzkt done 16:46 est31 great 16:47 est31 Isn't a factory something else, some OOP stuff? 16:47 nrzkt oop ? 16:47 est31 object oriented programming 16:48 est31 factories are a common concept in java 16:48 nrzkt the name is factory because this build the result we need here :) 16:49 est31 yea I know just ppl can think its something like this: http://en.wikipedia.org/wiki/Factory_method_pattern 16:50 est31 perhaps name it FacePositionCache? 16:50 nrzkt maybe, yes 16:51 nrzkt wtf... i see 1.3M calls to InventoryList::addItem on my empty server... it seems there is something strange here 16:51 est31 O_o 16:53 nrzkt i think there is something to study. It's caused bu l_add_item function (1807 calls) 16:54 * est31 should get back to lua side profiling too. VE's server with minetest technic has 70% avg cpu with just me idling doing nothing 17:43 nrzkt #2321 reviewed another time, the second improvement is an exponential improvement when the lua is called 17:44 ShadowBot https://github.com/minetest/minetest/issues/2321 -- Performance Improvement: Use a factory which caches result for getFacePositions. by nerzhul 18:24 rubenwardy #2323 18:24 ShadowBot https://github.com/minetest/minetest/issues/2323 -- Video-making Options 18:44 nrzkt thanks for the issue but it's not time for this :( 18:45 rubenwardy I'd be willing to attempt most of it, I just don't know about spline paths, in particular placing them and then following them 18:45 rubenwardy I'll do smooth movement now 19:29 rubenwardy Would "VolatileRunFlags" be the best place for the settings #2323 19:29 ShadowBot https://github.com/minetest/minetest/issues/2323 -- Video-making Options 19:30 rubenwardy oops 19:30 rubenwardy #2325 19:30 ShadowBot https://github.com/minetest/minetest/issues/2325 -- Add camera smoothing by rubenwardy 19:35 rubenwardy No, it should be in the same place as fast_move and fly 19:45 rubenwardy Okay, fast_move and free_move aren't cached, so it should be fine.