Minetest logo

IRC log for #minetest-dev, 2015-02-15

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:15 Player_2 joined #minetest-dev
00:21 DFeniks joined #minetest-dev
00:26 gregorycu_ joined #minetest-dev
00:58 celeron55 joined #minetest-dev
01:21 domtron_ joined #minetest-dev
01:30 est31___ joined #minetest-dev
02:14 est31 joined #minetest-dev
02:26 domtron_ joined #minetest-dev
02:49 hmmmmm joined #minetest-dev
04:06 sofar joined #minetest-dev
04:56 ShadowNinja joined #minetest-dev
05:14 alexxs joined #minetest-dev
05:41 gregorycu joined #minetest-dev
05:42 gregorycu Anyone know much about Lua VoxelManip?
05:45 * gregorycu looks in hmmmmm 's general director
05:45 gregorycu direction
06:15 Miner_48er joined #minetest-dev
06:31 est31 joined #minetest-dev
07:07 hmmmm joined #minetest-dev
07:08 Hunterz joined #minetest-dev
07:20 Krock joined #minetest-dev
07:24 JakubVanek joined #minetest-dev
07:27 chchjesus joined #minetest-dev
07:57 nore joined #minetest-dev
08:06 ImQ009 joined #minetest-dev
08:10 JakubVanek_ joined #minetest-dev
08:13 JakubVanek_ joined #minetest-dev
08:20 est31_ joined #minetest-dev
08:20 est31_ joined #minetest-dev
08:23 ImQ009 joined #minetest-dev
08:30 Amaz joined #minetest-dev
08:33 nrzkt joined #minetest-dev
08:34 decimalguy joined #minetest-dev
08:35 nrzkt ShadowNinja, nore ?
08:35 nore yes?
08:35 nrzkt ok for #2317 ?
08:35 ShadowBot https://github.com/minetest/minetest/issues/2317 -- Add an option to disallow guest connection (disabled by default) by nerzhul
08:37 gregorycu joined #minetest-dev
08:39 nore it looks good
08:39 nrzkt thanks, i merge it
08:39 nore just a question: why == false
08:39 nore and not !
08:39 nore ?
08:39 nrzkt i prefer == false for faster code reading
08:40 nore hm... I personally find it ugly
08:40 nore I don't know if we have guidelines about this
08:40 gregorycu Could be worse
08:40 gregorycu Could be == true
08:40 nrzkt you talk about : if (string_allowed(playername, PLAYERNAME_ALLOWED_CHARS) == false) {
08:40 nrzkt ?
08:40 gregorycu (Which I have seen)
08:40 nore yep
08:40 nrzkt it's not my code there, i just fixed the space :)
08:41 gregorycu It's funny, for me, the ! means I invert the thing as I read it
08:41 nore yeah, I saw that, but you can fix that while you're at it :)
08:41 gregorycu So I read it as "string not allowed" as opposed to "string allowed equals false"
08:42 nrzkt i don't see many code with ! operator, generally it's == false, then i kept the same coding style
08:42 gregorycu lol, really?
08:42 gregorycu Is most of the code you see your own?
08:44 nore ok, it looks like we haven't style guidelines about this
08:44 nrzkt ofc nore :)
08:44 gregorycu Why ofc?
08:44 est31 joined #minetest-dev
08:47 nore grepping the code gives about 10x more ! than == false
08:47 nore 2000 vs 200
08:51 kilbith joined #minetest-dev
08:54 nrzkt okay nore, i think we must have a guideline for this, i'll talk with celeron55 about this
08:55 nore but anyway: as soon as that is sorted out, you can merge it
08:56 celeron55 well we will obviously say the guideline is !
08:57 nrzkt oh, celeron55, you are there :D. What is the guideline ? code 2000 vs 200 or not ?
09:00 celeron55 the one that is used the most already
09:00 sfan5 nrzkt: regarding the PR from yesterday: I don't think it's necessary to have guest-checking in the core
09:00 nrzkt okay, then i'll use the ! operator.
09:01 hmmmm ...
09:01 hmmmm this is so stupid
09:01 hmmmm the guidelines should just tell you what not to do
09:01 nrzkt we must have a unified coding style hmmmm.
09:02 hmmmm and on that note i'm out
09:02 hmmmm left #minetest-dev
09:03 nrzkt lol.... hmmmm, the refusator :p
09:05 celeron55 his the point is, this does not actually matter and i kind of agree
09:07 nrzkt then for checking == false, what must i do ? ! or == false ? please tell me for future code
09:07 celeron55 meaning this should never even be discussed and both should always be accepted based on trusting whoever happens to make the code to have a brain
09:08 gregorycu_ joined #minetest-dev
09:08 celeron55 you can use the fact that ! is used the most as a guideline
09:08 sfan5 all other code uses !expr so you should use !expr
09:08 celeron55 like i already said
09:10 gregorycu__ joined #minetest-dev
09:11 nrzkt then i go to the weight :p
09:37 Taoki joined #minetest-dev
09:41 gregorycu joined #minetest-dev
09:42 gregorycu I see 100 open bugs, I think we need to have better priorities than talking about == false vs !
09:43 gregorycu :)
09:43 nrzkt i looked at all but i cannot solve all
09:43 gregorycu Sure you can
09:44 gregorycu Have some faith in yourself
09:47 gregorycu #1193 looks strange, I wonder if I can fix that
09:47 ShadowBot https://github.com/minetest/minetest/issues/1193 -- Issues with fog.
10:00 nore oh, btw: is the bug with the debug menu that the top texture is always shown and not the pointed texture known?
10:29 ShadowNinja joined #minetest-dev
10:43 Aaron1011 joined #minetest-dev
10:46 Calinou joined #minetest-dev
10:57 ElectronLibre joined #minetest-dev
11:07 roniz joined #minetest-dev
12:17 jin_xi joined #minetest-dev
12:24 SopaXorzTaker joined #minetest-dev
12:56 Calinou joined #minetest-dev
13:10 est31 joined #minetest-dev
13:29 proller joined #minetest-dev
14:24 rubenwardy joined #minetest-dev
14:47 rubenwardy joined #minetest-dev
15:00 Hiradur joined #minetest-dev
15:38 decimalguy left #minetest-dev
15:55 roniz joined #minetest-dev
16:00 rubenwardy #2299
16:00 ShadowBot https://github.com/minetest/minetest/issues/2299 -- Fix minetest.item_eats replace_with_item, fixes #2292 by rubenwardy
16:00 rubenwardy updated
16:06 luizrpgluiz joined #minetest-dev
16:07 luizrpgluiz would be possible to fix the bad alock
16:13 JakubVanek joined #minetest-dev
16:15 Player_2 joined #minetest-dev
16:26 Krock joined #minetest-dev
16:38 nrzkt i made a huge performance improvement in getFacePositions, please review #2321
16:38 ShadowBot https://github.com/minetest/minetest/issues/2321 -- Performance Improvement: Use a factory which caches result for getFacePositions. by nerzhul
16:39 nrzkt the operation gains comes is divided by 1000
16:39 nrzkt and only for my test, i could be greater for real servers because i depend of mods
16:40 est31 nrzkt, comments on #2225 ? is style ok now?
16:40 ShadowBot https://github.com/minetest/minetest/issues/2225 -- Fix for getCraftRecipes implementation is very slow by gregorycu
16:42 nrzkt style is ok, but i cannot review this part of the code i haven't studied it
16:44 est31 ok, can you add that as comment?
16:46 nrzkt done
16:46 est31 great
16:47 est31 Isn't a factory something else, some OOP stuff?
16:47 nrzkt oop ?
16:47 est31 object oriented programming
16:48 est31 factories are a common concept in java
16:48 nrzkt the name is factory because this build the result we need here :)
16:49 est31 yea I know just ppl can think its something like this: http://en.wikipedia.org/wi​ki/Factory_method_pattern
16:50 est31 perhaps name it FacePositionCache?
16:50 nrzkt maybe, yes
16:51 nrzkt wtf... i see 1.3M calls to InventoryList::addItem on my empty server... it seems there is something strange here
16:51 est31 O_o
16:53 nrzkt i think there is something to study. It's caused bu l_add_item function (1807 calls)
16:54 * est31 should get back to lua side profiling too. VE's server with minetest technic has 70% avg cpu with just me idling doing nothing
16:57 disablec1 joined #minetest-dev
17:17 leat joined #minetest-dev
17:40 roniz joined #minetest-dev
17:43 nrzkt #2321 reviewed another time, the second improvement is an exponential improvement when the lua is called
17:44 ShadowBot https://github.com/minetest/minetest/issues/2321 -- Performance Improvement: Use a factory which caches result for getFacePositions. by nerzhul
17:49 est31 joined #minetest-dev
18:24 rubenwardy #2323
18:24 ShadowBot https://github.com/minetest/minetest/issues/2323 -- Video-making Options
18:44 nrzkt thanks for the issue but it's not time for this :(
18:45 rubenwardy I'd be willing to attempt most of it, I just don't know about spline paths, in particular placing them and then following them
18:45 rubenwardy I'll do smooth movement now
18:49 ImQ009 joined #minetest-dev
18:52 Miner_48er joined #minetest-dev
18:56 swaaws joined #minetest-dev
19:27 ElectronLibre joined #minetest-dev
19:29 rubenwardy Would "VolatileRunFlags" be the best place for the settings #2323
19:29 ShadowBot https://github.com/minetest/minetest/issues/2323 -- Video-making Options
19:30 rubenwardy oops
19:30 rubenwardy #2325
19:30 ShadowBot https://github.com/minetest/minetest/issues/2325 -- Add camera smoothing by rubenwardy
19:35 rubenwardy No, it should be in the same place as fast_move and fly
19:45 rubenwardy Okay, fast_move and free_move aren't cached, so it should be fine.
20:04 crazyR joined #minetest-dev
20:17 DFeniks joined #minetest-dev
20:19 est31 joined #minetest-dev
20:29 MinetestForFun joined #minetest-dev
20:40 sapier1 joined #minetest-dev
20:42 Hiradur joined #minetest-dev
20:51 shadowzone joined #minetest-dev
21:18 ElectronLibre_ joined #minetest-dev
22:07 est31 joined #minetest-dev
22:44 crazyR joined #minetest-dev
22:57 OldCoder joined #minetest-dev
23:11 JakubVanek joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext