Time Nick Message 02:45 TheKingDoof later 03:40 RealBadAngel https://github.com/minetest/minetest/pull/1754/ 03:40 RealBadAngel ^bunch of bugfixes for meshnodes 03:41 RealBadAngel ShadowNinja, that solves most of the issues you had (excluding those with blender ;) ) 03:45 ShadowNinja RealBadAngel: Seems good, although i'd add a `if def.drawtype == "mesh" and not def.mesh then error("Missing mesh for mesh drawtype!") end` somewhere on the server side so the modder knows what the error is. 03:46 RealBadAngel getMesh reports the error 03:47 RealBadAngel 18:55:08: ERROR[main]: Client::getMesh(): Mesh not found: "3d_torch_wall.x" -- Segmentation fault (core dumped) 03:47 RealBadAngel now it just wont crash 03:47 ShadowNinja Ah, O.K., fine then. 03:48 RealBadAngel btw, add paramtype = "light", 03:49 RealBadAngel otherwise torch is pitch black 03:49 Zeno` 02:20 Zeno` ShadowNinja, is the change keys dialog not closing with escape like all the other dialogs intended or a bug? 03:49 ShadowNinja RealBadAngel: Yep, figured that out already. 03:50 ShadowNinja Zeno`: Sounds like a bug. 03:50 Zeno` Ok, I'll have a look at it later. I wondered because it's the only menu with Cancel / Save buttons as well 03:50 Zeno` So it may have been a decision, I don't know 03:50 Zeno` But it is kind of annoying 04:01 VanessaE RealBadAngel: do any of those fixes include stopping a segfault if a mesh is missing at start? 04:01 RealBadAngel yes 04:01 VanessaE ok 04:01 VanessaE I only just noticed that crash about 15 mins ago. 04:02 VanessaE oh hell you just said it 04:02 VanessaE I swear I must be blind. 04:02 RealBadAngel hehe 04:09 RealBadAngel kahrl, here? 04:25 VanessaE RBA's patch works for me. model coords -0.5 to +0.5 produce node-sized objects, comparable to nodebox coords, lighting glitches seem to be fixed as well 04:26 VanessaE that would be a no. 04:27 RealBadAngel lol 05:11 * VanessaE sighs 06:05 OldCoder "Sapier, thy wit is a rapier. Sometime, my Sapier will come..." 06:05 * OldCoder has been waiting for Sapier for weeks 06:43 kilbith OldCoder : PM 06:48 OldCoder kilbith, kk 08:27 Zeno` I'll probably make PR tonight: https://github.com/Zeno-/minetest/tree/refactor_the_game 09:28 kilbith nore: could you give your feedbacks about these textures please ? https://github.com/minetest/minetest_game/pulls 09:39 nore kilbith, btw: why do you have 3 accounts for pull requests? 09:39 ninnghazad better chances? 09:39 ninnghazad like, 3 tickets 09:39 nore no, it's 3 different pull requests 09:39 nore you can do 3 different ones with one account 09:41 ninnghazad maybe forgot to branch his fork like me =) 09:49 kilbith nore: because I still not understand how to submit a new pull request without considering the previous commits 09:50 nore do you use Linux? 09:50 kilbith yes 09:50 nore ok, then you first need to create a branch up-to-date with master 09:50 nore for that, do: 09:51 kilbith git checkout -b [new_branch] right ? 09:51 nore git remote add upstream https://github.com/minetest/minetest_game 09:51 kilbith I take note 09:51 Zeno` Zeno- wants to merge 23 commits into LOL 09:52 nore and then, git fetch upstream master:upstream 09:52 nore (or upstream:master, I don't remember) 09:52 nore only one will work though 09:52 nore then: git checkout upstream 09:52 nore git checkout -b new_branch 09:52 nore then do your changes 09:52 kilbith ok great ! 09:53 kilbith will try that next time 09:53 nore and when you're done: git push -u origin new_branch 09:53 nore (where origin is your git repo) 09:53 kilbith thanks 09:54 nore np 09:55 kilbith about the glass fragments, they don't represents a broken bottle 09:55 kilbith just some random glass fragments 09:56 nore well, the new textures looked like a broken bottle 09:56 kilbith it's much symbolic than the pile of unseeable micro-fragments 09:56 nore actually, looking again, they are not that 09:57 nore hm... ok, you're right 09:57 kilbith the current may be confused with another thing 09:58 kilbith I'm wondering what should do I with the ladder... let that as it, or make it lighter 09:59 nore Zeno`: you make so many changes that github doesn't want to show them :) 10:01 Zeno` yeah, changed 3000 lines :( 10:01 Zeno` But there was no way to avoid that :) 10:07 Zeno` oops better get rid of changes to test.cpp 10:09 Zeno` I think they should be commented out (or at least not default) but that's another story 11:00 iqualfragile I need a place in the minetest code that is called every frame, only on client side and where the following information is avaviable: position, facing direction and servername&port, preferrably servername as dns name if possible 11:09 Zeno` iqualfragile, if you can wait then that place would be here: https://github.com/Zeno-/minetest/blob/refactor_the_game/src/game.cpp#L2017 11:09 Zeno` hopefully the PR gets accepted at some point. the main reason for refactoring is to make additions like yours easier 11:10 iqualfragile Zeno`: yes, i can wait 11:10 iqualfragile i want to add mumble positional audio support 11:10 Zeno` well, need to see what the core devs say about my PR first 11:10 Zeno` iqualfragile, I know... I read that this morning :) 11:15 Zeno` iqualfragile, in the old game.cpp, somewhere between lines 1731 and 3493 11:15 iqualfragile oh, just 1500 lines to read through! 11:15 iqualfragile or did you mean anywhere? 11:16 Zeno` yeah.. somewhere in there 11:16 Zeno` I'm not sure... probably after sounds have been updated 11:17 Zeno` In the new version I would say just before https://github.com/Zeno-/minetest/blob/refactor_the_game/src/game.cpp#L2029 11:17 Zeno` or maybe after updateFrame() 11:17 Zeno` anyway ;) 11:21 Zeno` iqualfragile, before you do too much maybe it would be wise to ask the core devs what they think of "public domain" 11:21 iqualfragile Zeno`: why? 11:22 Zeno` I just read somewhere that there was an issue with "public domain". But, it may not be a problem. What's the LICENSE of the library overall? 11:23 Zeno` The main license seems fine anyway... I don't know how you intend to link it though 11:24 Zeno` oh, they've gone 11:24 Zeno` or is it some kind of module? hmmm 11:30 Zeno` iqualfragile, I did check and it looks fine but you may want feedback anyhow 11:31 DrPhilB Bit hit-and-run I'm afraid: you guys aware of current HEAD client segfaulting pretty reliably? e5652cb seems OK, so I'm guessing ae375cc is duff. Got a couple backtraces if you need them but it's happening almost instantly on connect for me, sometimes I get far enough to open a door, so should be easy to reproduce. 11:35 Zeno` DrPhilB, I think RBA fixed it with his latest PR 11:35 Zeno` oh wait 11:36 Zeno` ae375cc shouldn't be doing it... are you sure e5652cb is ok? 11:38 DrPhilB I have not observed the crash with e5652 11:38 DrPhilB Running it now 11:39 Zeno` you could open an issue report if you have github, or I guess paste a link to backtraces here 11:40 Zeno` The only thing I do know is: https://github.com/minetest/minetest/pull/1754 which does address some segfault 11:40 DrPhilB I'll file an issue report in a bit, then 11:42 Zeno` Can you show backtrace before then? :) 11:42 DrPhilB Sure, let me just pastebin it 11:42 jin_xi vanessa e reported something here, maybe the same issue? https://forum.minetest.net/viewtopic.php?f=9&t=10428 11:43 DrPhilB http://pastebin.com/x9MyBXPc 11:44 DrPhilB Sounds like it, jin_xi 11:45 Zeno` jin_xi, that issue, then, is fixed by #1754 I believe 11:45 ShadowBot https://github.com/minetest/minetest/issues/1754 -- Recalculate normals for cached meshes. by RealBadAngel 11:46 Zeno` yeah, I'd say that's it DrPhilB 11:47 DrPhilB Cool 11:50 Zeno` weird that I haven't experienced it 11:50 Zeno` perhaps I have no cached whatever-it's-caching 11:51 Zeno` not* 11:51 DrPhilB Maybe. Tons of stairs and stuff around me. 12:09 niebieski Hey guys, I'm looking forward helping out so someone on the forums told me to come here. 12:16 Zeno` hi niebieski 12:16 niebieski Hey, Zeno. 12:19 Zeno` most people are asleep; they should wake up soon I guess 12:21 niebieski Alright then. 12:22 Zeno` What are you working on? 12:24 niebieski I'm not working on anything currently. 12:24 Zeno` ok :) 12:27 paramat nore, please could you look at my pull request for fixing boats mod? https://github.com/minetest/minetest_game/pull/328 i have approval from sfan5 and have re-added turn inversion on request from blockmen 12:28 nore well, the code looks good 12:28 nore didn't test it, but if you say it works, I'll trust you :) 12:29 paramat thanks! i've tested and tuned it for hours 12:29 Zeno` this mem leak is what I reported yesterday and it *seems* that adding stuff to the dtor to cleanup doesn't help 12:29 Zeno` currently my client is using 1.2GB O.o 12:30 Zeno` RealBadAngel *poke* 12:31 paramat i'm still a newbie at pull requests so may need some guidance on 'squashing' and 'rebasing' my commits 12:32 Zeno` paramat, I think they'll ask you to squash if they want you to 12:32 Zeno` rebase is easy 12:32 Zeno` update your master branch 12:32 Zeno` checkout your working branch 12:32 Zeno` git rebase master 12:33 Zeno` if you're new to git I suggest making a backup of the minetest directory first 12:34 Zeno` If it was me I wouldn't squash your work 12:34 paramat thanks 12:34 Zeno` Safer to make a whole new branch and cherry pick the commits in your mgv5 branch if they ask you to squash. That way you can keep your commit history as well 12:35 Zeno` but rebase should not be an issue 12:36 Megaf_ ( ͡° ͜ʖ ͡°) 12:37 Megaf_ (ノಠ益ಠ)ノ彡┻━┻ 12:37 Zeno` Oh also, after rebasing you will need to force push 12:38 Megaf_ !server Megaf 12:38 ShadowBot Megaf_: server [--{name,address,players,ping,port} ] 12:38 Megaf_ what? 12:38 PenguinDad Megaf_: wrong channel I guess 12:39 Megaf_ oh 12:39 Megaf_ sorry folks 12:39 paramat okay. i won't rebase or squash until asked 14:23 paramat mgv5 is now working correctly with new noise functions, by using a temporary hack. the bug is the noise 'scale' parameter being ignored set to 1, this made the terrain very low and smooth and changed the shape of caves. now caves look right using the original cave threshold of 0.125 14:24 Zeno` How can it be ignored? 14:24 Zeno` It's not a float/int error is it? 14:25 paramat id like to fix the noise scale bug and perhaps get this into 0.4.11 =} 14:25 paramat yes probably a silly mistake by a c++ newbie 14:25 Zeno` comment the line where the hack is 14:26 paramat the hacks are to multiply the noise in the code 14:26 Zeno` If they're a hack they should be commented though :) 14:27 paramat ah i see 14:27 paramat okay 14:27 Zeno` Otherwise how can others find what the hack actually is? :p 14:29 paramat https://github.com/paramat/minetest/commits/mgv5 14:32 Zeno` But... errr... what's the hack? 14:34 paramat stuff like 'if(40 * n_ground * f < y - h) {' where i multiply the noise value 14:35 paramat so fairly harmless, but of course it's hardcoded and can't be edited in minetest.conf by a player 14:35 Zeno` so that should be preceded by something like // FIXME: multiplying by 40 because... 14:35 Zeno` it's not harmless, because if you are not here the "hack"/workaround is not obvious at all 14:36 paramat now doing 14:36 Zeno` ok ;) 14:37 Zeno` I'm not saying this to call you out or anything... it's just needed :) 14:41 proller paramat, but nobody edit noise params in mapgen.. 14:41 paramat heh i did it now before i forgot. i need to rewrite some param code and try again ... 14:41 proller in config ^ 14:42 paramat they should do it more 14:42 paramat that remiinds me it would be good to fix chunk glitch at y = 47 in mgv6 14:42 paramat mgv5 goes above 47 with no problem 14:51 niebieski I get errors frequently of "invalid something listener" and the server respawns me because I exceeded world limits. 14:55 Amaz proller, I do :P 15:52 niebieski Guys, this TODO list http://dev.minetest.net/TODO#TODO_in_minetest_game, is done or not ? I'm thinking about doing the hurt sounds. 15:52 niebieski zat, hey. :) 15:54 Zeno` I don't think it's done 15:55 Zeno` certainly there is no PR saying that hurt sounds is done 16:20 niebieski I just found a not bad sound. :D 16:29 zat1 niebieski: lol hey 16:30 RealBadAngel hmmm, nore, anything against my bugfixes? 16:30 nore sorry, didn't look at them 16:31 nore well, it looks good 16:32 RealBadAngel ok 16:32 RealBadAngel those are small fixes anyway 18:31 niebieski Guys please tell me what you think of this http://five.vv.si/minetest.html 18:31 niebieski I want to submit this as the hurt sound. 18:31 sfan5 404 18:32 niebieski Ops, http://fife.vv.si/minetest.html 18:32 sfan5 that sounds like a guy screaming 18:32 sfan5 not that good for a hurt sound 18:34 niebieski Hmmm. 18:34 niebieski I think it's similar to MC's hurt sound. 18:36 Amaz MT != MC/MC clone 18:37 kahrl sounds more like a weird sneeze to me 18:37 niebieski Alright then. 18:48 niebieski I feel like I want to submit it. xD 21:09 RealBadAngel https://github.com/minetest/minetest/pull/1759 21:09 RealBadAngel fix for broken plantlike drawtype