Time Nick Message 00:46 ShadowNinja Comments on #751? 00:48 ShadowNinja And what do you think about changing minetest.get_player_ip(name) to player:get_player_ip()? 00:53 Sokomine db-based rollback finally merged? that's excellent news for all servers, moderators and players! 00:54 Sokomine and bad news for griefers i guess :-) 00:54 VanessaE woohoo! 00:54 * VanessaE removes one more item from her patch list 00:54 Sokomine now we need to get server owners to update. this is really worth it! 00:55 * Sokomine shortly allows hershelf to dream that redcrab will update (please forgive the spamming for now :-)) 03:19 RealBadAngel i started to get weird errors with mesh update thread 03:20 RealBadAngel it looks completely random 03:21 RealBadAngel for example: ERROR[MeshUpdateThread]: Waiting for texture default_water_source_animated.png^[verticalframe:40:0 timed out. 03:21 RealBadAngel sometimes it reports shader source is timed out 03:21 RealBadAngel or any other texture 03:23 RealBadAngel btw, i do get them only on windows build 03:23 RealBadAngel and the reported texture is back there on next refresh 03:27 RealBadAngel another example: 03:27 RealBadAngel 08:37:16: ERROR[MeshUpdateThread]: Waiting for shader solids_shader timed out. 03:27 RealBadAngel 08:37:17: ERROR[MeshUpdateThread]: Waiting for texture default_dirt_normal.png timed out. 03:27 RealBadAngel in a few seconds i could see that the shader was back there 03:28 RealBadAngel any ideas? 08:32 VanessaE for proller: http://xkcd.com/1296/ 08:32 VanessaE :D 09:59 VanessaE is anyone awake in here? 10:00 thexyz ye 10:00 thexyz s 10:00 VanessaE ok. Trying to work someone through a client crash, might need to forward reports here. 10:00 thexyz but you shouldn't be asking to ask 10:00 VanessaE I know but I tend to find myself talking to air at this time of night :) 10:01 thexyz can't help with this now sorry 10:01 VanessaE s;ok 10:01 VanessaE as long as it goes into the logs 10:01 VanessaE I'll file an issue if there's enough info (which I doubt. This guy's not too good with computers, it appears) 10:14 VanessaE ok finally got a piece of info from the guy... 10:14 VanessaE it's worst when he's running, particularly trying to get back to the spawn, which as you know is pretty mesh heavy 10:15 VanessaE I think he's getting bit by some variation of that old mesh generation crash 10:37 VanessaE and..I was right. 10:37 VanessaE http://pastebin.com/U8YUyPf5 10:37 VanessaE paste from the guy's repeated crashes. 10:38 VanessaE (I realize that is about as slim on info as it gets, but it's all he had) 10:40 VanessaE this is 0.4.8 for Windows 7, obtained from minetest.net. 10:41 VanessaE (32 bit build) 10:43 VanessaE the system in question has (if he gave me the right info), 8GB of system RAM, several hundred gigs of free disk space, apparently Intel integrated gfx 10:44 VanessaE an I just remembered, he was complaining about fps sagging associated with these crashes 10:52 RealBadAngel the errors reported by me earlier were also about [MeshUpdateThread] and windows 12:57 proller Buildcraft deleted from play market 13:03 bas080 mmdb. Needs ability to depends on mods that have not yet been registered. https://forum.minetest.net/viewtopic.php?id=7854 13:04 bas080 Plus why can i not reply on that page? 13:06 iqualfragile bas080: read the full post, especialy the "Place to report bugs" part 13:07 iqualfragile and (to answer your feature request) i do not think it would make sense to change it that way because the dependency relations will be used by the client to automaticly install any missing mods which are on the mmdb 13:07 iqualfragile that is the only reason this field even exists 13:08 iqualfragile (and maybee later on notifying users that some mod they depend on has been updated) 13:08 iqualfragile so adding mods which do not yet exist in the mmdb to a mods dependencies does not make sense 13:47 thexyz celeron55: did you report buildcraft to google or something? 14:01 sfan5 14:25 thexyz WELCOME TO THE FUTURE https://github.com/minetest/minetest/blob/master/src/rollback.cpp#L432 14:26 thexyz where we're saving 4 bytes of memory by using VLA in C++ 14:26 thexyz I'm afraid we can only have VLA in C99 14:28 thexyz ShadowNinja: ^ 14:29 thexyz kahrl: what's the status of httpfetch2? does it work? if so, what features it lacks/why is it not in yet? 15:03 BlockMen celeron55, here the new mockups: https://dl.dropboxusercontent.com/s/5zg8pgdtoq9z54r/main2_2.png and https://dl.dropboxusercontent.com/s/xzag726q3nwcbct/sub2_2.png 15:03 BlockMen (without bg texture: https://dl.dropboxusercontent.com/s/ed0lkby2ss4xwi6/main2_4.png and https://dl.dropboxusercontent.com/s/3gdtoaspau2bly5/sub2_4.png) 15:04 BlockMen IMO that is a minimum frame a website needs to look fine (and i prefer the bg textured one) 15:52 celeron55 thexyz: i haven't reported it to anyone 15:53 thexyz celeron55: I see 15:53 thexyz it got removed if you don't know yet 15:53 celeron55 probably someone reported it and google actually cared 15:54 celeron55 or is there a chance that the devs just pulled it out themselves? 15:54 celeron55 they could've thought it just isn't worth it 16:07 ShadowNinja thexyz: Hmmm, seems that isn't in the C++ standard. I'll push a fix. 16:07 thexyz just replace it with 21 16:11 ShadowNinja Any other VLAs in there? 16:13 ShadowNinja That looks like the only one. 16:22 celeron55 anyone feel free to vote between blockmen's stuff and current minetest.net 16:22 ShadowNinja Hmmm, that's actually supposed to be 22. Maybe he thought sizes started at 0. 16:22 ShadowNinja celeron55: I vote for BlockMen's design. 16:36 Jordach i vote for BlockMen's textured 16:42 thexyz ShadowNinja: no, it compiles fine after the change 16:42 thexyz really? 22? 16:43 thexyz lol 16:52 ShadowNinja thexyz: With 21: warning: array subscript is above array bounds [-Warray-bounds] And I counted it and came up with 22. 16:53 thexyz I see, that's cool 18:40 sapier RealBadAngel those error messages are replacement for minetest crash ;-) 18:51 celeron55 there occasionally are some totally random people clicking some button on launchpad to request joining to the launchpad minetest team 18:52 celeron55 i've ignored all of them thus far but i got one once again just now; does someone want to try to figure out if some of these actually know what they're doing? 18:54 celeron55 this last one has 71 launchpad "karma" which seems high (maybe?) 19:40 NakedFury merge them 19:46 NakedFury now you know what xyz feels like 19:46 thexyz john_minetest: and then your access will be revoked and all your commits reverted 19:46 thexyz because "that's not how we do things" 19:47 PilzAdam AFAIK there are not many bugfixes open 19:47 PilzAdam most of the "old things" are features 19:50 sapier bugfix is always priorized against feature addons 19:51 sapier yes but the added VERSION_PATCH_ORIGIN is controversial 19:53 sapier some core dev's mentioned they're not happy with so much new variables so I'm just gonna wait until someone has an idea how to fix it in a better way 19:54 sapier there's the git text appended to VERSION_PATCH but within windows file version information only numbers are accepted so this orig value is just it's plain value 19:57 sapier I don't even understand the description ;-) 19:58 sapier can you explain to me? 20:02 sapier ok then let's find out what this does ;-) 20:04 sapier yes but here aren't any nodes placed 20:07 sapier ok this adds an additional check if the drop isn't air and isn't liquid 20:07 sapier now it dshall not be something you can build uppon too 20:11 sapier right now buildable_to nodes don't stop fall in any case with this fix they will do 20:12 sapier ok the actuall falling isn't involved true 20:13 sapier if I understand correct e.g. if gravel falls on gravel it'll stop 20:13 sapier atm the gravel fallen onto is replaced by a gravel falling node 20:14 sapier in case the lower gravel was (wrong) placed uppon a air node it'd fall down too 20:14 sapier but I'm not exactly sure about this ... why don't ppl describe what they (intend to) fix 20:14 Exio4 some features are "locked down" because random shit that people would agree is against guidelines, is too hacky, doesn't work that well, is WIP/POC 20:15 Exio4 or so :P\ 20:16 sapier most things are just locked down because there aren't at least two core devs interested enough at that particular feature to review ;-) ... I no this isn't very satisfying but I guess it's just plain truth 20:16 sapier -no +know 20:16 Exio4 my zoom-like feature is hacky, and my "replace actual chatbox with the console" is blocked because copy-paste support 20:16 Exio4 just for saying some examples 20:16 sapier copy-paste support? 20:16 Exio4 devs are voluntary, they aren't getting paid 20:17 sapier john we have our own lifes too ;-) 20:17 PilzAdam john_minetest, if you pay me for that, sure 20:17 Exio4 john_minetest: they don't do anything, sure, because that is why they are coredevs.. 20:17 sapier but voluntary means "interesting things first" 20:17 PilzAdam Exio4, I actually would like to see the chat console thing getting merged 20:18 Exio4 I know, but the console doesn't support copy paste and testing it under linux is a pain-in-the-ass 20:18 sapier would that chat console thing address chat text overlaying formspec too? 20:18 PilzAdam Exio4, copy and paste doesnt work in the chat window either, so nothing would change 20:18 sapier that's wrong john 20:18 Exio4 it works on windows 20:19 sapier when did you look at commit history last time? 20:19 Exio4 sapier: https://github.com/minetest/minetest/pull/751 20:19 PilzAdam even if nothing is commited, people still work on stuff 20:20 PilzAdam see the log of this channel 20:20 sapier we had >80 not long ago ... ok ok lots of them have been gone by a non good reason ... 20:20 PilzAdam its fact that people like to code their own things instead of fixing / testing other peoples code 20:21 Exio4 fixing / testing other people's code is harder than writing it :P 20:21 PilzAdam so its up to the people who created a pull request to come here and get at least one dev interested in the feature 20:21 sapier speaking about fixing / testing is async ready for merge? 20:22 PilzAdam sapier, has anything changed since I last tested? 20:22 sapier I want to prepare kahrls httpfetch things for merge too 20:22 sapier I intend to replace some engine/minetest usages by tbl in one of the lua scripts but nothing important 20:23 sapier wait it's completed so I can push it to my branch to see 20:24 PilzAdam john_minetest, if you want you can test sapier:asynchronous_events_2 20:25 sapier oops I thought 846 was already merged 20:25 sapier that's most likely the pug with worlds your recently rediscovered PilzAdam 20:25 sapier -pub+bug 20:25 PilzAdam sapier, no 20:26 PilzAdam that bug was related to processing key events (or so), its fixed in formspec_table 20:26 PilzAdam john_minetest, test the modstore and public server list 20:26 sapier ohh ok messed up with another similar fix ... but still 846 should be merged 20:27 sapier john you shouldn't have a stall menu in modmanager while downloading 20:27 PilzAdam sapier, is the bug kahrl mentioned fixed? 20:28 sapier PilzAdam I'm gonna recheck that one, no idea 20:28 PilzAdam oh, thats the remote_port / port split we discussed a while ago 20:29 PilzAdam there is an _ missing in minetest.conf.example:34 20:30 PilzAdam IIRC it was consensus to be merged 20:31 sapier I remember this way too but there have been things I needed to fix and after that it wasn't reviewd again ... but let me first check the comment 20:31 PilzAdam (this is an example where the one who opened the pull request did not advertise it enough) 20:32 sapier noone did by now john 20:32 sapier no it should be implemented 20:33 sapier I'm convinced modstore will grow soon and you don't really want to brows 100 pages if you already know the mod you want to install 20:35 sapier I intend to merge modstore and texture tab to a single store tab 20:35 sapier need to do some changes along with it but not quite sure how this is gonna be exactly 20:35 PilzAdam dont forget the game store 20:36 sapier of course ALL variants of stores get included ;-) 20:37 sapier maybe this holidays ... at least for texture packs mmdb needs to be improved too 20:37 sapier PilzAdam where is a space missing in minetest.conf? 20:37 PilzAdam not space, underscore 20:37 sapier oh 20:37 PilzAdam its remote_port, not remote port 20:40 sapier ok I fixed this and squashed the commits do you agree to merge? 20:41 PilzAdam yes 20:42 sapier ok then I'm gonna merge in a view minutes unless someone shouts stop until then 20:52 VanessaE what about the MeshUpdateThread crashing? 20:52 VanessaE no one commented on this 20:52 PilzAdam VanessaE, # of issue? 20:52 VanessaE RBA had it happen to him, now at least one user on my server is having it repeatedly. 20:53 emptty Hello there 20:53 VanessaE PilzAdam: see -dev logs, ending about 10 hours ago 20:53 emptty I'm trying to package 0.4.8 for debian, and I'm getting troubles 20:53 VanessaE there's not enough info to file an issue number 20:53 VanessaE but apparently this is a common crash now 20:53 sapier what troubles emptty? 20:53 emptty I'm activating freetype in my package, and this is what causes problems 20:54 emptty Is freetype the recomended way of life 20:54 PilzAdam emptty, yes, I recommend to use freetype if possible 20:54 sapier I read about rba's error but not about a crash? 20:54 PilzAdam what problems do you get? 20:54 emptty The problem may well be on my side (ft2build.h: No such file or directory) 20:55 emptty I just wanted to check whether freetype was actually a good idea 20:55 emptty I'll dig further 20:55 sapier I assume you have freetype dev package installed? 20:55 emptty yes, I do 20:55 sapier what debian version? 20:56 emptty and I passed the path to the include files to cmake with -DFREETYPE_INCLUDE_DIRS=/usr/share/freetype2 20:56 emptty fresh unstable chroot 20:56 sapier VanessaE I don't see any crash in logs? 20:56 sapier I do have debian to and usually don't need to pass it let me check if freetype is enabled for me ;-) 20:57 VanessaE sapier: http://irc.minetest.ru/minetest-dev/2013-11-28#i_3459021 20:58 PilzAdam emptty, you have to set FREETYPE_INCLUDE_DIR_freetype2 and FREETYPE_INCLUDE_DIR_ft2build 20:58 sapier that's not a crash VanessaE 20:58 VanessaE sapier: yes, it is. 20:58 VanessaE repeated crashes on the user's machine 20:58 VanessaE that's all the data I was able to get from him 20:58 VanessaE (see the pastebin linl) 20:58 VanessaE link*) 20:59 PilzAdam VanessaE, which minetest version is that? 20:59 VanessaE PilzAdam: 0.4.8-release 20:59 PilzAdam also who was this "user"? 20:59 VanessaE his nick is chandler 21:00 emptty PilzAdam: and I have to set the directories to /usr/include instead of /usr/share. Stupid copy/paste error, sorry 21:00 sapier RBA's error message is what is now shown instead of corrupting memory 21:00 VanessaE some guy in the US mountain time zone is about all I know about him :) 21:00 sapier that's been your crash VanessaE ;-) 21:00 VanessaE sapier: in chandler's case, the client crashes outright. 21:01 VanessaE I'm not seeing those crashes myself anymore 21:01 sapier I guess the root cause wor delay we didn't investigate any further now hits 21:01 VanessaE else you would have a hell of a lot more data to go on than that ^^^^^ 21:01 VanessaE :) 21:02 sapier1 yes VanessaE we fixed a bad bug but maybe there is another one that made the one we fixed occur .. remember it's been in there for years without anyone notice 21:02 PilzAdam john_minetest, font_size in minetest.conf 21:03 sapier1 :-) 21:03 VanessaE sapier1: yep I knpw 21:03 VanessaE know* 21:03 PilzAdam its mentioned in minetest.conf.example 21:03 VanessaE this guy has intel integrated gfx, so while he didn't say so, it's a sure bet this is a laptop and therefore software rendering somewhere in the video pipeline. 21:04 sapier1 John minetest did you just volonteer to write a user manual for minetest? *smile* 21:04 VanessaE (unless they're doing real 3d accel these days in integrated gfx) 21:04 VanessaE john_minetest: https://forum.minetest.net/viewtopic.php?id=4436 problem. solved. 21:05 sapier1 ok I'm pushing the server/client port split now 21:05 PilzAdam john_minetest, do you use freetype? 21:06 PilzAdam freetype needs to be compiled in 21:06 PilzAdam its recommended to use it 21:07 PilzAdam -DENABLE_FREETYPE=1 21:07 PilzAdam (you can find these settings in 'cmake . -LH') 21:07 PilzAdam also it should print it to the Esc menu in-game 21:08 sapier1 what the ... did I do anything wrong? github just autoclosed the pull request? 21:09 PilzAdam isnt that good? 21:09 sapier1 I don't know it's first time I see this behaviour 21:09 PilzAdam it auto-closes it when you push the same commit, i.e. when you not have to rebase it 21:09 sapier1 ok that's an explanation I did rebase this on my original branch prior merging to master 21:12 exoplanet hi is the debian maintainer here? 21:12 PilzAdam emptty is here 21:12 sapier VannessaE are we sure that guy does have enough memory? 21:12 exoplanet thanks PilzAdam 21:12 VanessaE sapier: it's always done that with my projects, often without adding anything that implies a merge took plase. 21:12 VanessaE place. 21:13 VanessaE sapier: he claimed 8GB. I'd say that's sufficient. 21:13 emptty exoplanet: how could I help you? 21:13 sapier yes but there are lots of more errors above the crash ... I guess root cause is somewhere within the missing lines 21:14 sapier but if he's got 8GB I'd assume another memory corruption issue 21:15 sapier john_minetest whats result of your async branch tests? 21:15 VanessaE you mean those 'dummy' messages? I get those too, not sure which mod is ultimately the cause, but they don't result in crashes for me 21:15 VanessaE (and actually, I haven't seen those in some time, either) 21:16 sapier did you try insane things too? e.g. enter leave quickly fast button clicks or tab switches? 21:16 sapier this line is strange: "2:24:09: ERROR[main]: No world selected and no address provided. Nothing to do." 21:17 exoplanet emptty~ when can we expect 0.4.8 in unstable? are there technical reasons why it isn't in the repo or is it just a lack of time on your side? 21:17 sapier exo plz read log he's just working at it 21:18 sapier ... I don't know but I m not surprised :-) 21:19 sapier john could you provide logs or even better gdb trace of all threads? 21:20 sapier best would be gdb trace of an -O0 build ;-) 21:21 emptty exoplanet: the main technical reason is that upstream (the guys of this chan) patched their internal version of jthread while I was trying to not dupplicate this code as it is already packaged 21:22 emptty exoplanet: that's the classical game between packagers and upstream authors. The latter want to make it easy for all users, the former want to make it clean on their particular platform 21:22 sapier ok guess that should be fixable 21:22 thexyz emptty: do you have any suggestion on how to resolve this issue? 21:23 emptty exoplanet: there is an opened bug against the debian package where I gave updates of my work every two days, if you want to follow the packaging effort 21:23 PilzAdam emptty, we are about to modify jthread even more 21:23 emptty exoplanet: the package is almost there, btw 21:23 emptty thexyz: I think that your changes are very good and should be pushed to jthread's upstream 21:24 exoplanet thanks for the explanation emptty. and thanks for your work. :) 21:24 emptty thexyz: I didn't do that myself right now, because as you can see, I have quite a great pressure from the users to get 0.4.8 into the archive 21:24 sapier everytime or just sporadic? 21:24 PilzAdam emptty, this, to be more precise: https://github.com/minetest/minetest/pull/1003/files 21:24 emptty PilzAdam: yeah, I found it. This change is good 21:25 PilzAdam I think its quite a funny coincidence that john_minetest is currently testing this 21:25 thexyz I see; I'm afraid jthread is no longer actively developed 21:25 sapier you keep on adding download requests if you switch that fast 21:26 sapier I'm gonna fix the crash and show a error message to user to slow down ;-) 21:26 thexyz or maybe there's just nothing to develop 21:26 emptty thexyz: I may consider discussing with debian's maintainer of jthread to see whether he can push it to his own upstream, but I have somehow the feeling that jthread's upstream is dead. Am I right? 21:26 thexyz emptty: I'm not sure 21:27 PilzAdam exoplanet, why isnt there a article about Minetest at the ubuntuusers wiki yet? 21:28 sapier moddetails are fetched asynchronously I guess there is some corner case where data isn't available (yet) 21:29 sapier I'm gonna check presence of details prior trying to access 21:29 sfan5 PilzAdam: http://wiki.ubuntuusers.de/Spiele/Minetest 21:30 PilzAdam sfan5, huh? why doesnt the search function work then? 21:30 exoplanet PilzAdam~ the search is "not as good" the dev team is on it. 21:31 emptty for the reccord, I just discovered that 3 mods were added to debian recently 21:31 sapier mods? 21:31 emptty moreblocks moreores pipeworks 21:32 emptty as separate packages 21:32 emptty I should cleanup and upload my package of mobf 21:32 emptty and I seem to understand that someone is working on mesecon 21:32 PilzAdam emptty, we have an in-game "modstore" now, that allows to download mods 21:32 PilzAdam so the packages are obsolete, I guess 21:32 emptty PilzAdam: cool, I didn't knew 21:33 emptty note that the package is shared between users 21:33 PilzAdam john_minetest, no, mmdb is not really usable for me currently 21:33 sapier but always same john? 21:33 sapier ok 21:34 PilzAdam emptty, what you could do is seperate minetest_game into a different package, this way it would be possible for other games that use the Minetest engine to be published as packages too 21:35 emptty does any other game exist yet? 21:35 PilzAdam https://forum.minetest.net/viewforum.php?id=15 21:36 sapier ok pushed a fix john plz test 21:36 exoplanet emptty~ at some point i wanted to package mods, but someone explained that it's not a good idea… 21:37 emptty I personnaly am *very* reluctant in installing something on my machine that is not installed by the package manager 21:38 emptty I think that modstore and mod packages are not competing. Both have advantages 21:39 sapier argh not what was intended to happen 21:40 PilzAdam emptty, I personally would like if people would understand that Minetest an engine, and what they usually refer to when saying "Minetest" is actually just on of the games for it (minetest_game) 21:40 sapier wait the 137 isn't fixed 21:40 PilzAdam +is 21:41 exoplanet i would like if minetest would be an ecosystem like linux is just a kernel :) 21:41 PilzAdam exoplanet, you should add that to the wiki article 21:42 sapier ok now 21:44 sapier what? 21:44 sapier what are you doing? :-) 21:48 exoplanet PilzAdam~ the part that minetest is "just" a engine? Can i have a source for that? :) (not that someone reverts the changes (unlikely but could happen) 21:49 sapier ok john you discovered a really strange effect 21:49 PilzAdam exoplanet, I guess this is enough for now (?) https://github.com/minetest/minetest/blob/master/README.txt#L11 21:51 sapier if you click buttons fast after each other only last one is shown 21:51 exoplanet great. hope nobody has the idea to discus if the article is about minetest_game :D 21:51 sapier but both are installed :-) 21:52 PilzAdam exoplanet, we have the same problem with the minetest wiki, its about minetest_game currently, since its the largest game currently; but in the future we need a proper system to handle multiple games 21:53 PilzAdam john_cephalopoda, we currently have the structure that each node has a single page 21:54 quasar http://wiki.ubuntuusers.de/Minetest works now. (redirect) 21:59 emptty PilzAdam: a long time ago, you guys were speaking of finding a new name for minetest_game. That would help differenciating both, too 22:00 sapier john no it isn't but by now there isn't a better one ;-) 22:00 emptty john_minetest: from my POV, it's really really good. each time I come here, I'm surprised by the quality of the community 22:01 emptty yeah, they call that "free software" :) 22:01 pitriss john_minetest: I think dev model is really good.. 22:02 PilzAdam john_minetest, how big is it? 22:02 pitriss john_minetest: and I'm satisfied with result and with what pullrequests are accepted.. 22:05 pitriss john_minetest: maybe.. But on other hand if some pull request is not critical, and it is good idea with some issues, then there is no point to close them.. 22:05 sapier john_minetest can you try latest version again? 22:07 sapier try latest I'm not sure what was at 142 :-) 22:08 sapier it's lua only you don't need to compile ;-) 22:08 pitriss john_minetest: I'm not core dev, i can't code in c++ so, I really don't know what is lying in pullrequests queue and why it was not merged.. I can't judge that..:) 22:09 PilzAdam john_minetest, a "fix"? what is broken? 22:10 PilzAdam its rather an inconsistency than a bug 22:10 emptty for the record, I'm currently pushing 0.4.8 to the debian servers 22:10 emptty (it compiled fine) 22:10 sapier I'm not sure if this really fixes anything it might just change behaviour 22:10 PilzAdam emptty, great! 22:11 sapier debian and minetest 0.4.8 :-) great 22:11 PilzAdam john_minetest, yes, its actually good to be merged; it needs testing, though 22:11 sapier we don't pull just to close ... tztztz 22:12 emptty john_minetest: maybe you could pick an example of one change that is good and not pulled yet, and back the change by testing and cleaning it? 22:12 PilzAdam john_minetest, the reason why it wasnt merged yet is 1) its not a bugfix 2) the author didnt advertise it enough to get the attention of a core dev 22:12 VanessaE PilzAdam: it's becoming nigh on impossible to do that these datys 22:12 VanessaE days* 22:12 sapier keep on trying :-) by now every new tester did find something different :-) ... so maybe now a new tester is required :-) 22:13 VanessaE (to advertise a feature enough to get someone interested) 22:13 PilzAdam john_minetest, you just did that with #875 22:13 sapier for this special case the autor didn't even describe his change 22:14 sapier at least not in a way you understand what he intends to do :-) 22:14 PilzAdam sapier, I have no problems understanding the title... 22:14 sapier and it will be pulled .... SOME DAY ;-) 22:15 sapier ok PA explain to me ;-) 22:15 PilzAdam when a falling node falls on a not walkable node (e.g. rail) then it drops this node 22:15 PilzAdam the pull requests makes the node not drop when its buildable_to (e.g. grass) 22:16 sapier so buildable_to nodes will just vanish? 22:17 PilzAdam yes, same behaviour as when placing a node while pointing at the buldable_to node 22:17 sapier thanks now I understand what this is intended to do 22:17 sapier what happens? 22:18 PilzAdam sapier, feel free to test and merge it then :-p 22:19 sapier with current version??? 22:21 sapier 142 is a emty line ... plz update again 22:22 sapier https://github.com/sapier/minetest/blob/89a7d134748abe05362c83e6c76fe28f93112388/builtin/modstore.lua L 142 there is none? 22:22 sapier you restarted minetest? 22:24 sapier then this isn't latest version 22:24 sapier no? 22:25 sapier no I looked at line 142 ... maybe github proxy? 22:26 sapier https://gist.github.com/sapier/7698929 22:26 sapier this is how it's supposed to be 22:27 sapier thats 143+144 for me 22:28 sapier eclipse shows exactly same line numbers ;-) 22:31 sapier kwrite too 22:31 sapier nano too ... guess github is either unsynchronized or wrong 22:31 emptty ask head or tail, and you'll be set 22:33 emptty head -n 141 the_file | tail -n 2 22:33 sapier same result 22:33 sapier 142 is an empty line 22:34 emptty you may have two \r laying in the file that desync github line counting, maybe? 22:34 sapier everything I see is consistent but it doesn't seem to match what johns sees