Time  Nick          Message
00:04 ShadowNinja   proller: Done.
00:05 proller       age, more..., disableable cols
00:05 ShadowNinja   proller: embeded XSS won't work anymore, assuming the server sends numbers where numbers are expected and the like.
00:06 ShadowNinja   proller: Age and ping are disableable.
00:06 ShadowNinja   Uptime/age that is.
00:06 proller       in my version all cols disableable ;)
00:07 ShadowNinja   I can add that.
00:07 proller       can you port all features?
00:08 PilzAdam      ShadowNinja, dont cut random ports off
00:09 ShadowNinja   PilzAdam: Hmmm? if the port is 30000 it isn't shown.
00:10 PilzAdam      thats stupid
00:10 PilzAdam      just always show the port
00:10 proller       nooo
00:11 proller       stupid is show 30000
00:11 PilzAdam      we have discussed it a while ago, and decided to show port 30000
00:11 PilzAdam      (we being proller, c55 and me)
00:12 proller       http://minetest.net:80/
00:12 ShadowNinja   Alright.
00:13 PilzAdam      also what is up with the "Version, Gameid, MapGen" column?
00:13 PilzAdam      why arent that 3 columns?
00:13 ShadowNinja   Because it is already far too wide.
00:14 PilzAdam      make description shorter then
00:16 proller       also make column for every flag
00:16 PilzAdam      yea, and tick it instead of writing it out
00:16 proller       and split ip and 30000
00:17 PilzAdam      uptime can be removed, though
00:18 proller       (its joke)
00:18 proller       age - not
00:23 ShadowNinja   I limited the address to 25 characters and added the full address to a tooltip. (I also added … if it was too long)
00:24 proller       30000 30000 30000 30000 30000 30000
00:24 proller       fuuuu
00:24 proller       do not cut port
00:24 proller       only ip
00:24 ShadowNinja   I agree with proller on the port removal.
00:24 ShadowNinja   Ok.
00:26 proller       and more.. - http://minetest.setun.net:8000
00:27 proller       if (++count > master.limit && master.limit) break;
00:27 proller       if (master.clients_min && s.clients < master.clients_min) continue;
00:28 ShadowNinja   Hmmm, that might involve using a custom loop in the template...
00:30 proller       and! make loading of servers.js from list.js
00:35 ShadowNinja   proller: There is no nice way to do that, see: http://stackoverflow.com/questions/950087/how-to-include-a-javascript-file-in-another-javascript-file
00:35 ShadowNinja   I made the font size a little smaller.
00:36 proller       http://api.jquery.com/jQuery.getScript/
00:37 proller       also up jquery version
00:38 proller       to 1.10.2
00:47 ShadowNinja   How long should the description be limited to?
00:49 ShadowNinja   Just using <script> seems cleaner.
00:51 ShadowNinja   Somewhere betweem 32 and 64 seems good.
01:05 ShadowNinja   Name is also limited to 25 chars now.
01:06 ShadowNinja   Branch updated.
01:12 ShadowNinja   Now only age has to be fixed. Do you have any ideas proller?
01:14 ShadowNinja   Hah, looking at the old one it looks HUGE in comparison.
01:14 ShadowNinja   (Length limits and a smaller font)
01:59 kahrl         [fyi] httpfetch has been rebased, new branch is at: https://github.com/kahrl/minetest/commits/httpfetch2
02:37 ShadowNinja   kahrl: Thoughts on shadowninja.minetest.net/serverlist?
02:37 ShadowNinja   I made it much smaller, and it uses a template now.
02:39 ShadowNinja   zat: I'm waiting for my server to ping out because I started a rollback, any progress on your patch?
02:40 ShadowNinja   Oh, it didn't ping out. :-) But it won't be long before I have to mv it.
02:43 kahrl         ShadowNinja: seems good to me
02:44 kahrl         I usually don't find Ping too useful on server lists, since that's not my ping
02:47 ShadowNinja   kahrl: It indicates server lag (I think)?
02:47 zat           ShadowNinja: I can progress it tomorrow.
02:48 zat           And patch... I would not call a patch 900 lines of clean code.
02:48 kahrl         not sure server lag and ping are correlated that much (I mean, a bit they are for sure)
02:48 zat           lol
02:48 ShadowNinja   zat: patch/diff/change/fork/branch/whatever.
02:48 kahrl         since pings are processed in the connection thread and not in the thread that runs Server::AsyncRunStep
02:49 zat           ;)
02:49 ShadowNinja   Well maybe they should be removed.
06:49 proller       maybe add simple  ping packet with processing in AsyncRunStep ?
09:59 nore          sapier, could you check https://github.com/minetest/minetest/pull/874 please?
10:26 sapier        nore is your branch up to date?
10:26 nore          I rebased it a few days ago
10:27 nore          but it looks like I will have to update it again
10:27 sapier        ok then I need to check master I'm waiting 40s for a local mobf game to start up ... that used to be 1-2s
10:29 sapier        874 doesn't seem to break anything and looks reasonable and usefull to me I'm for merging it
10:30 sapier        I tested using mobfs settings gui as well as mobf trader inventory and main menu
10:49 nore          sapier, so is it ok for merge?
10:52 nore          I'm for merging it <-- I had not seen that, so I will merge it
11:10 PilzAdam      https://github.com/minetest/minetest/commit/0b788892898013cd430c48b98e21a3fd111c3c7f <- why is that not documented in lua-api.txt?
11:13 nore          oops, sorry, I hadn't thought of that and neither did sapier...
11:13 nore          I'm going to add a comment in lua_api
11:14 nore          PilzAdam, would a line "if fields.quit = true, then the formspec is being closed"  be ok?
11:15 PilzAdam      in which line?
11:16 nore          2123
11:16 nore          sry, 2124
11:17 PilzAdam      what about 1141?
11:18 PilzAdam      and add a node that "quit" is not a valid name for fields
11:18 nore          hadn't seen that
11:19 thexyz        fields.quit?
11:19 thexyz        this is a bad idea, I think
11:20 thexyz        we should do what smart people did and prefix it with, say, _ and also specify in docs that identifiers starting with _ are reserved
11:21 nore          thexyz, the fields which are key_ are already forbidden
11:22 nore          but that should perhaps be done too...
11:22 thexyz        eh
11:22 thexyz        I'm too slow then
11:23 thexyz        I think we should fix this
11:23 nore          PilzAdam, is that ok: https://gist.github.com/Novatux/7289183
11:23 thexyz        and allow fields starting with key_
11:23 thexyz        because it's bullshit
11:24 thexyz        okay, you've decided to ignore my suggestion
11:24 nore          yes...
11:24 thexyz        fine
11:24 nore          (not about ignoring the suggestion, the previous one)
11:24 nore          (the "it's bullshit")
11:24 thexyz        n-not like I care anyway
11:24 nore          but I agree, it should be changed
11:25 nore          however, I reckon that we first need to add the doc about the last commit
11:25 nore          and then, fix that
11:25 nore          (I don't have much time now, have to go soon)
11:25 thexyz        only to remove the doc later? I don't see any point in doing that
11:26 nore          thexyz, I mean, change it and not remove it
11:26 thexyz        whatever, do what you want
11:26 nore          I don't know... PilzAdam, what do you think we should do?
11:26 PilzAdam      nore, no, its not ok, do what thexyz said and fix the docs after that
11:27 nore          ok
11:27 nore          about the key_ things, I don't know where they are though
11:30 nore          gtg, I can't fix that now
11:31 thexyz        sapier: can you fix "key_" prefix to be "_key_" instead? that way we can just specify in docs that formspec elements names that start with _ are prohibited
11:31 thexyz        also, any objections to that?
11:49 sapier        once I fixed the i18n things ;-) had to rewrite something in order to add celerons comments ... as always using different compiler switches results in compile errors at the architecture you didn't write it first
13:49 EvergreenTree I'm sorry about bothering you with this, but can someone check pull request #197 on minetest_game?
15:36 ShadowNinja   proller: I improved my serverlist. It now has hover lists for mods and clients(Same method that you used).
15:37 proller       30000 30000 30000 30000 30000 30000
15:37 ShadowNinja   thexyz: Have you seen it? http://shadowninja.minetest.net/serverlist It uses a doT.js template.
15:37 proller       all is underlined
15:37 ShadowNinja   proller: Yes, not my decision.
15:37 proller       underline only links and hovers
15:38 ShadowNinja   proller: Because they have tooltips, I will work on only adding it to ones that were actually shortened.
15:38 proller       yes, show only where needed
15:40 proller       do not show second value in uptime, its useless 15d 20h 37m
15:40 pitriss       ShadowNinja: you have broken links..
15:41 pitriss       ShadowNinja: i clicked on antons servers link and it has your adress prepending correct one
15:41 ShadowNinja   pitriss: Hmmm, yes. Thanks for pointing that out.
15:41 pitriss       yw
15:41 proller       show tooltips as dotted underline, links as solid
15:42 pitriss       proller +1
15:42 ShadowNinja   proller: Your css says that, but I don't think that is a valid css atribute...
15:44 proller       do not show clients tooltip if list empty
15:44 proller       and mods too
15:45 proller       and show template, want too look
15:53 ShadowNinja   proller: https://gist.github.com/ShadowNinja/7283108
15:54 proller       its better than was?
15:56 proller       {{??}}
15:56 proller       and still not all features here
15:57 ShadowNinja   proller: What about {{??}}
15:58 proller       nothing, its very intuitive
16:13 proller       VanessaE, others null driver now broken, client cant join
16:16 ShadowNinja   The a bountysource link should be added somewhere, otherwise nobody will know that it exists. Perhaps on the Donate/Support page?
16:21 proller       https://github.com/minetest/minetest/pull/979/files
16:24 ShadowNinja   Yes, that will conflict.
16:25 ShadowNinja   Do you know of a CSS selector to senect a element that contains a element of a certain class? (select <td>s that have a class="hover_list" in them)
16:25 ShadowNinja   select*
16:26 sapier        https://github.com/minetest/minetest/pull/971 ok another day of work ... I hope it's ready for merge now plz verify
16:27 proller       td .hover_list
16:27 proller       with space
16:27 proller       oh, no
16:27 proller       without
16:28 proller       td.hover_list   = <td class="hover_list">
16:28 proller       td .hover_list   = <td><div class="hover_list">
16:31 ShadowNinja   proller: No, I want to select a td that contains a element with the hover_list class.
16:32 proller       td .hover_lis
16:33 ShadowNinja   Select <td> in <td><div class="hover_list">. "td .hover_list" selects the div element
16:35 proller       http://www.w3.org/TR/CSS2/selector.html
16:35 proller       maybe E + F but..
16:36 proller       http://www.w3.org/TR/css3-selectors/
16:36 proller       90% its impossible
16:37 ShadowNinja   I need something like :parent.
16:38 proller       none
16:39 sapier        what about i18n support for serverlist? *diabolic smile*
16:40 ShadowNinja   sapier: Possible for the headers, not for anything else. So it's pretty pointless.
16:41 sapier        just because it's not possible for everything we still added it to minetest ;-) but it wasn't a real suggestion :-) I just want some others to feel the pain I had to feel when getting msvc i18n working ;-)
16:42 nore          sapier, what is i18n precisely?
16:43 sapier        translation of texts according to users prefered language ... browsers usually send that information
16:51 proller       https://github.com/minetest/minetest/pull/980
16:51 proller       ^ trivial
16:52 sapier        remove the newline in client.cpp ;-)
16:52 proller       already
16:52 nore          does 2||1 return 2 or 3?
16:52 PilzAdam      put spaces arround ||
16:52 sapier        argh PA was faster ;-)
16:53 sapier        yet I'm not sure if this is correct actually || is a bool evaluation
16:53 nore          and 715/716 of nodedef.cpp: (aspect_w*aspect_h)||1 might be better
16:54 nore          instead of (aspect_w||1)*(aspect_h)||1
16:54 PilzAdam      proller, can you point to the c++ specification that your usage of || is correct?
16:54 sapier        I'm not sure this is at all correct
16:54 kaeza         nore, || returns either 1 or 0
16:54 sapier        it's lua code not c++
16:55 proller       oops
16:55 proller       or not oops..
16:55 proller       correct is ?:
16:55 sapier        yes
16:55 proller       but it not supported by win
16:56 nore          kaeza, so both of my guesses were wrong...
16:56 sapier        tile.animation_frame_count ?  tile.animation_frame_count : 1
16:56 sapier        is standard c so it should be supported in windows too
16:56 PilzAdam      or just assert(frame_count)
16:57 sapier        actually PA is right what you're doing is error hiding
16:59 nore          about assert errors, it could actually be good to have a real error message... (and not just the client crashing, people may not know what it is)
17:00 sapier        nore a correct assert results in a pretty usefull error message
17:01 proller       https://github.com/minetest/minetest/pull/980/files
17:01 ShadowNinja   proller: Have you heard of "git commit --amend"?
17:01 proller       no
17:01 nore          yes, but I mean sometimes there are crashes with "Assertion '0' failed"
17:02 sapier        thats an example for a assert not done correct ;-)
17:03 proller       f5
17:03 PilzAdam      if there is an assert(0); in Minetest then there is usually an errorstream << "" in front of it
17:03 sapier        assert(0) is crap everyone can do a assert("This is a usefull error message" == 0) instead
17:03 proller       0 is correct in null video driver
17:04 nore          sapier: grep -R "assert(0)"|wc -> 51 lines
17:04 proller       maybe not load textures when null?
17:04 sapier        a lot of things to fix nore ;-)
17:04 nore          a few are commented though
17:05 PilzAdam      as I said, its not bad if Minetest logs it before doing assert(0);
17:05 ShadowNinja   https://github.com/ShadowNinja/minetest/compare/template_serverlist
17:05 sapier        no of course not bad but it's even better to add it within assert()
17:06 proller       ShadowNinja, why you place scripts first?
17:07 ShadowNinja   proller: Scripts first?
17:07 proller       ShadowNinja, and please, make all features from my list
17:07 proller       before <div id="server_list"></div>
17:08 ShadowNinja   proller: I already have, at least as far as I know.
17:08 proller       not all
17:08 ShadowNinja   What have I missed?
17:08 proller       read list.js, every line have sense
17:08 proller       if (!master.no_total && r.total && r.total_max)
17:09 proller       if (r.list.length) {
17:09 proller       you make it looks like, but all hidden features is missing
17:12 ShadowNinja   doT.js adds "if (server)" to the compiled template.
17:13 proller       remove 30000 port and leave first value of uptime
17:14 proller       remove hovers on 13/15 14 where no client list
17:14 pitriss       I think keeping port 30000 is better
17:15 proller       https://github.com/minetest/minetest/pull/980/files
17:16 ShadowNinja   proller: I already removed hovers for empty lists.
17:17 proller       http://shadowninja.minetest.net/serverlist/
17:17 proller       all underlined
17:17 thexyz        ShadowNinja: it's better than what we have now but still lacks design, how about adding some?
17:18 proller       thexyz, still not better
17:18 proller       need more work
17:18 thexyz        okay, it's not better
17:27 ShadowNinja   Hmmm, you managed to only underline ones with lists...
17:28 proller       WARNING: active block modifiers took 507ms (longer than 200ms) -  on arm with defaults mod
17:29 PilzAdam      you mean minetest_game with no mods?
17:32 proller       yes
17:32 proller       up to 1s for abms
17:32 ShadowNinja   There, only text with hover boxes is underlined now.
17:32 nore          proller, did saplings grow?
17:32 nore          IIRC, it is the longest ABM
17:33 proller       its math with falling in mengersponge
17:33 proller       also random input cant respawn
17:33 proller       no trees in math
17:34 nore          did you test with the ABM timing patch? (maybe it should be included upstream, with a flag...)
17:34 proller       where is patch?
17:35 proller       maybe make option for auto respawn?
17:35 nore          https://forum.minetest.net/viewtopic.php?id=7355
17:37 proller       there need to stop abm processing if time> step and return on next call to interrupted point
17:38 nore          proller, doing those timing calculations needs time...
17:39 nore          anyway, what causes the ABMs to take so long on that server?
17:39 proller       some time checks here - https://github.com/minetest/minetest/pull/895/files
17:39 proller       samsung galaxy s2 cpu 8)
17:53 proller       https://github.com/minetest/minetest/pull/980/files - now with autorespawn!
18:13 sapier        hmm peacful_mobs?
18:13 sapier        as long as mobs aren't included that's completely useless and if they are this shouldn't be engine issue
18:14 sapier        proller why do you add a variable for this anyway?
18:15 proller       because i want no death screen too?
18:16 sapier        there's nothing about death screen in environment.cpp L1287...
18:21 proller       where?
18:22 proller       Server: Maximum lag peaked to 49.0998 s
18:22 sapier        895 environment.cpp L 1287 + 1294 what's that change good for?
18:24 sapier        I don't question it reducing lag, I didn't have time to check I assume you don't lie to me
18:29 proller       on slow cpu these queues always overloaded
18:29 proller       and produce more load with every step
18:29 sapier        proller I'm not talking about queues ;-)
18:30 proller       ups
18:30 sapier        I'm talking about:
18:30 sapier        bool only_peaceful_mobs = g_settings->getBool("only_peaceful_mobs");
18:30 sapier        if(only_peaceful_mobs){
18:30 sapier        why? ;-)
18:30 proller       to not ask settings in every iteration
18:31 proller       g_settings->get not too fast to call it 100xxx times
18:31 sapier        ok good reason :-) didn' realize the loop around it
18:49 sapier        can someone tell me what mingw version is supposed to work with buildbot script? ;-P
18:53 Jordach       proller, what's the address for sky
18:53 sfan5         any version is supposed to work
18:53 sfan5         ^ sapier
18:53 Jordach       whoops
18:53 Jordach       wrong channel
18:53 sapier        so nobody really tested
18:53 proller       h4.setun.net:30100
18:54 sfan5         sapier: it works for me with "gcc version 4.2.1-sjlj (mingw32-2)"
18:55 sapier        quite outdated
18:55 sapier        ok found main issue ... unzip and wget missing in base installation
18:56 sapier        ok certificates missing too ...
19:07 proller       wget --no-check-certificate
19:23 sapier        isn't part of script ;-) but obviously should be
19:24 sapier        argh next missing thing is 7zip ... buildbot has more dependencys then actual build ! ;-P
20:06 sapier        proller did my last mobf fix work for you?
20:06 proller       seems yes
20:06 sapier        good
20:07 sapier        ok got buildbot working ... actualy it's not a mingw build but msys build, next thing is there's a hardcoded i586 compiler selected
20:08 sapier        imho buildbot is broken in respect of general usability it only works for a very very special system setuo
20:08 EvergreenTree #197 on minetest_game is rebased and ready to merge
20:12 ShadowNinja   EvergreenTree: I have it ready locally, no need to touch it anymore.
20:13 EvergreenTree Okay, that's fine
20:13 ShadowNinja   But if another core dev could agree with it...
20:13 EvergreenTree It's rebased though, if you want to merge it
20:15 ShadowNinja   As soon as you suficiently annoy someone else. ;-P
20:16 proller       INFO[ServerThread]: timers took 5092ms
20:16 sapier        wow
20:16 sapier        how did you do that proller?
20:17 proller       m_env->getMap().timerUpdate
20:17 sapier        some mod running havoc?
20:17 EvergreenTree ShadowNinja, Didn't mean to annoy anyone, sorry
20:17 proller       mobf + mobs + all abm 1s 1chance
20:17 proller       + 10 bots
20:18 sapier        mobf doesn't use timers
20:18 ShadowNinja   EvergreenTree: You have it wrong, the idea is to annoy people to agree to it, rather than ignoring it. :-)
20:18 sapier        wait is timer update doing the timer mechanism only or is there full environment step behind it?
20:18 EvergreenTree Oh, so that's how it is
20:19 ShadowNinja   Heres another dev to anoy. ;-)
20:19 sapier        I'd have a look for those abms proller 1s 1 is quite a lot
20:19 ShadowNinja   sapier: Can you agree with #197?
20:20 proller       sapier, all abms, but need more digging
20:20 sapier        lemme have quick look at it shadow
20:20 sapier        proller did you enable asynchonous spawning in mobf?
20:21 proller       no, how?
20:22 sapier        open mobf settings gui (you need to have enough rights to do so)
20:23 sapier        select "delay spawning at mapgen"
20:24 sapier        this way spawn algorythms aren't run in mapgen but asynchronously ... mapgen only triggers jobs to be done ... be awere jobs are lost if they aren't completed in case of server crash
20:24 proller       its possible without gui?
20:24 proller       managing servers with gui is windows-way 8)
20:25 sapier        there should be a mobf _settings.conf in your world directory
20:26 ShadowNinja   sapier: mobf_settings.conf or _settings.conf?
20:26 sapier        actually it should be mobf_settings.conf
20:26 ShadowNinja   ^
20:26 sapier        if it isn't create it
20:27 sapier        yes but ppl obviously don't ever discover features if there's no gui pointing them to it ;-P
20:27 sapier        within that file add a line: mobf_delayed_spawning = true
20:27 PilzAdam      ShadowNinja, you can merge EvergreenTree's request
20:28 sapier        did anyone test 197?
20:28 EvergreenTree ShadowNinja did
20:28 sapier        ok then I'm fine too
20:29 EvergreenTree I did too of course.  :P
20:29 PilzAdam      EvergreenTree, the reason why this took so long is problably that its so small that nobody cared to actually merge it
20:29 EvergreenTree Ah, I see
20:29 sapier        a second test is minimum to get a little bit of confidence ... usually bugs don't occure within creation environment .. see build_bot
20:30 ShadowNinja   EvergreenTree: Pushed.
20:31 BlockMen      PilzAdam, any idea how to solve the problem with you infostring at #928?
20:31 PilzAdam      its even such a small thing that even a single core dev could merge it and nobody would care
20:32 sapier        as nyancat is very rare chances anyone would notice are quite small ;-)
20:32 EvergreenTree It's probably going to be obsolete if #959 is merged
20:32 EvergreenTree Yeah, it's probably too small to notice
20:32 PilzAdam      BlockMen, Id say just add the string as it is currently to the default formspec
20:32 sapier        but small things have to be fixed too
20:33 PilzAdam      or even remove it completly, I dont really care about that anymore
20:33 ShadowNinja   EvergreenTree: Nope, they are very different.
20:33 EvergreenTree No, I mean I would make them have 6d facedir if 959 is merged
20:33 proller       c++: Internal error: Killed: 9 (program cc1plus)
20:33 EvergreenTree I'm not talking about code conflicts
20:34 sapier        reduce number of parallel tasks
20:34 BlockMen      PilzAdam, adding as is doesnt work since the problem with the text length of labels, so i will leave it as is now
20:34 sapier        or replace the broken ram in your pc proller ;-)
20:34 BlockMen      can someone else agree on #928 then?
20:34 proller       time to reboot
20:34 PilzAdam      BlockMen, well, you are a core dev, arent you?
20:35 sapier        if you're on linux and really have bad ram you can use badram patches to shadow those areas proller
20:35 BlockMen      yes, but one alone isnt enough :P
20:35 proller       sapier,  i'm in freebsd
20:35 PilzAdam      oh, I havent said "yes"
20:35 sapier        ok no idea if there's something similar
20:35 PilzAdam      BlockMen, you can merge it if it works
20:36 BlockMen      ok, then i will merge it
20:37 sapier        wait
20:38 BlockMen      sapier, y?
20:39 sapier        did you fix the main menu?
20:39 EvergreenTree So the only reason 959 isn't being, merged is because it's in a separate file?
20:39 sapier        is mm_menubar really only place where colors are used?
20:40 ShadowNinja   EvergreenTree: No, there is disagreement over how it should work.
20:40 BlockMen      its the only hex colors without '#'
20:40 PilzAdam      EvergreenTree, no, there was discussion about that yesterday
20:40 EvergreenTree Ah, I see
20:40 BlockMen      so for the list i had to change it in guiFormspec.ccp, not in builtin
20:41 EvergreenTree Someone should implement it correctly though, it could be useful
20:41 sapier        no it isn't
20:41 PilzAdam      EvergreenTree, thats the problem: what is "correctly"?
20:41 sapier        if you'd merge it that way you break modstore
20:41 EvergreenTree hmmm
20:42 EvergreenTree Well that's just great
20:42 BlockMen      sapier, could you show me the code you talk about ;)
20:42 sapier        modstore.lua lines 186 188 and 209
20:43 ShadowNinja   VanessaE: It seems like invertwall makes more sense than forcewall as it allows you to force either wall or floor/ceiling.
20:43 sapier        sfan you wanted to add color defines some months ago ;-)
20:44 BlockMen      damn...missed that. thanks, will change that too
20:56 BlockMen      sapier, fine now?
20:57 sapier        did you try all pages in main menu?
21:01 BlockMen      all except modstore because it is broken in my builds
21:02 ShadowNinja   troller: What is there left to add to my serverlist?
21:03 ShadowNinja   I think that having a "More..." link for each server to keep the size of the main list down may be good.
21:03 thexyz        you forgot to add design
21:04 VanessaE      ShadowNinja: forcewall is there for moreblocks, basically.
21:04 thexyz        upi d
21:04 thexyz        wat
21:04 VanessaE      invertwall is how I personally would prefer it, so I included both.  let the modder decide.
21:04 ShadowNinja   thexyz: That can be added later, first get it to work with templates.
21:04 thexyz        you don't need to waste space on server address, you can put it under the title
21:04 thexyz        well, okay
21:04 thexyz        just check some sane minecraft serverlist
21:05 sapier        BlockMen why is it broken? no curl support?
21:05 thexyz        I think the font is too small
21:05 ShadowNinja   VanessaE: Invertwall makes more sense, make Calinou use the better way.
21:07 VanessaE      I tried.
21:07 VanessaE      he refused,
21:07 BlockMen      sapier, i wanted test it but always forgot to do. it may be related to curl, but i dont think so since it throws an "failed to parse json data" error
21:07 BlockMen      one sec, i copy debug
21:08 VanessaE      his main contention was that we have no proper modifier key, so we have to use sneak, which would affect the ability to build while sneaking.
21:08 BlockMen      sapier, http://pastie.org/private/w40mxklknnt8yvwho7uzq
21:08 thexyz        ShadowNinja: if it's based on templates then it's good enough
21:09 ShadowNinja   Ok.
21:09 sapier        do you have curl included blockmen?
21:09 BlockMen      yes
21:09 VanessaE      he felt the effect would be more manageable if sneak only forced rather than inverted.
21:09 BlockMen      is the public serverlist called by curl?
21:09 thexyz        ShadowNinja: wait, where can I see the source?
21:10 sapier        I'm not sure but for some reason you try to get mod details for non existant mods ... what os do you use?
21:11 ShadowNinja   thexyz: https://github.com/ShadowNinja/minetest/compare/template_serverlist
21:11 BlockMen      win7 64bit
21:12 BlockMen      i compile with vs2010
21:13 thexyz        okay, I guess it's fine
21:14 sapier        hmm I'll have a look at it those number you try to download seem to be wrong no idea why mt tries to download it
21:15 ShadowNinja   thexyz: Do you know how to compile the template?
21:16 thexyz        of course I don't, you should include some docs
21:16 BlockMen      sapier, bump me if you need more info.
21:17 BlockMen      soo..im going to merge #928 now
21:18 ShadowNinja   thexyz: http://pastebin.ubuntu.com/6355362/
21:19 PilzAdam      BlockMen, yes, the serverlist is downloaded with cURL
21:20 BlockMen      ok, then its not an curl problem i guess because it works fine
21:21 PilzAdam      oh nice, it doesnt even build
21:21 PilzAdam      /home/adam/Minetest/minetest/src/guiFormSpecMenu.cpp:1385:25: error: expected primary-expression before '||' token
21:21 PilzAdam      /home/adam/Minetest/minetest/src/guiFormSpecMenu.cpp:1385:70: error: expected ';' before ')' token
21:21 PilzAdam      /home/adam/Minetest/minetest/src/guiFormSpecMenu.cpp:2803:1: error: expected '}' at end of input
21:21 thexyz        ShadowNinja: you should include something like this to the source tree
21:22 thexyz        lol
21:22 thexyz        it's hard to balance yer ( and )
21:23 PilzAdam      BlockMen, are you going to fix that?
21:24 BlockMen      PilzAdam, yes
21:26 thexyz        this response is the correct one
21:26 thexyz        but next time please at least compile before committing
21:26 pitriss       I want to ask, are these changes in formspec visible or just "under the hood" tuning?
21:28 PilzAdam      they are visible for modders
21:29 PilzAdam      and modders can create things that are visible for the users
21:29 pitriss       PilzAdam: i just have look at code.. i don't understand it much but.. i guess, it allows to use colored text and backgrounds in formspec?
21:30 PilzAdam      it allows to change the color of the inventory slots, which were always grey previosuly
21:31 pitriss       ahh.. great:)
21:31 PilzAdam      and some other stuff too
21:31 pitriss       maybe sometime will be possible to make server messages in chat in another color too:)
21:32 ShadowNinja   thexyz: Added to README.md in utils/master. What are the setup instructions for master.cgi so that I can add that?
21:33 BlockMen      i have to override history, so not commits now plz
21:33 BlockMen      and no pulls plz
21:34 thexyz        ShadowNinja: I can show you the config file https://gist.github.com/xyzz/c0d28276d57c2a4b314e
21:35 thexyz        how about this
21:35 thexyz        when you break build
21:35 thexyz        you do 50 push ups
21:36 ShadowNinja   thexyz: But does the script have any dependencies other than a HTTPd and perl?
21:36 thexyz        ShadowNinja: I use nginx + perl + fcgiwrap and have almost no idea how this works
21:36 ShadowNinja   lol
21:36 * ShadowNinja starts reading master.cgi while trying to learn perl.
21:37 thexyz        or rather than breaking the build, when you rewrite the history
21:37 thexyz        ShadowNinja: hey i liek perl too https://github.com/minetest/minetest/blob/master/util/master/master.cgi#L93
21:38 ShadowNinja   And THAT is why I use python.
21:39 thexyz        you can write shit in python too
21:39 thexyz        proller told me this specific line was written for lulz
21:40 troller       yeah, and for killing phyton-damaged peoples 8)
21:40 ShadowNinja   Well sure you can, but I find python a lot easier to read than perl.
21:41 thexyz        troller: I forgot one thing; do you use something like this in production?
21:41 troller       thexyz, this line - sometimes yes
21:41 thexyz        heh
21:41 thexyz        yandex
21:41 troller       something much easier - yes
21:42 troller       in yandex - very rare, and must run quickly
21:42 troller       when someone reads 8)
21:42 ShadowNinja   Ok, well let's just hope nobody else tries to set up a serverlist.
21:43 troller       ShadowNinja, leave only first value in uptime
21:43 troller       and restore age
21:43 ShadowNinja   troller: Age is there, it is just always undefined.
21:43 troller       no.
21:44 ShadowNinja   And "1d 5h 3m" is much better than "1.2D" IMO.
21:44 troller       http://servers.minetest.net/
21:44 troller       NOO
21:45 troller       3m have no sense
21:45 troller       an 5h too
21:45 ShadowNinja   3m == 3 minutes.
21:45 ShadowNinja   Same for hours.
21:45 troller       its already i day, why to show seconda?
21:45 troller       1 day
21:46 troller       second value is jink
21:46 troller       junk
21:46 troller       maybe 1.2d-> 1d
21:48 PilzAdam      master branch is fixed now, it builds again
21:48 PilzAdam      (only took 25 minutes to fix a missing "(" )
21:49 BlockMen      ha ha... -.-'
21:49 PilzAdam      so we have nore and BlockMen now... next on the list is sapier :-p
21:50 PilzAdam      sapier, do you want to merge https://github.com/minetest/minetest/pull/962 ?
21:50 sapier        does anyone have an idea why modstore is broken in windows?
21:50 BlockMen      sapier, its not for cross builds
21:50 BlockMen      like sfans or PA'S
21:50 sapier        I built minetest myself
21:51 sapier        if everyone is ok with 962 I'm gonna merge it ... time to learn how to do it
21:51 PilzAdam      well, we have like 5 core devs who are ok with it when at least one has tested it
21:51 PilzAdam      and you said you have tested it on windows and linux, so I guess its fine
21:53 sapier        then I'm gonna have a try
21:53 ShadowNinja   Bigest problem I have is remembering to close pulls after merging them. ;-)
21:53 PilzAdam      do all the new core devs have read http://dev.minetest.net/Git_Guidelines ?
21:55 * ShadowNinja has.
21:55 * BlockMen    also has
21:56 ShadowNinja   In fact I've edited that page.
21:57 ShadowNinja   sapier: Have you read it? ^
21:58 sapier        ok I'm gonna read it again :-)
21:59 sapier        ok crossing thumbs and pushing now
21:59 VanessaE      LuaError: error: ...essa/.minetest/games/vanessae_game/mods/farming/init.lua:132: attempt to call field 'hoe_on_use' (a nil value)
21:59 VanessaE      um, wut?
22:00 ShadowNinja   Before pushing the template serverlist I'd like to fix the age. troller: Do you have any ideas as to why it is undefined?
22:00 sapier        ok seems to be fine
22:01 ShadowNinja   VanessaE: nore recently changed that to farming.hoe_on_use.
22:01 troller       ShadowNinja, no
22:01 troller       ShadowNinja, before pushing restore if (!master.no_total && r.total && r.total_max)
22:01 troller       if (++count > master.limit && master.limit) break;
22:01 troller       if (master.clients_min && s.clients < master.clients_min) continue;
22:02 troller       if (master.clients_min || master.limit)
22:02 troller       .. more.. link
22:02 ShadowNinja   troller: I already did the first, I don't know if the others are still relevant...
22:02 ShadowNinja   Oh, limit...
22:03 PilzAdam      VanessaE, oh damn, that conflicts with farming_plus
22:03 troller       its for placing list to any page
22:03 VanessaE      ok
22:04 troller       for example small list to http://minetest.net/
22:04 PilzAdam      VanessaE, pull farming_plus
22:05 PilzAdam      sapier, post the commit hash instead of "merged" when you close a pull request
22:05 VanessaE      PilzAdam: can't.  you still haven't merged zeg9's 'mapgen' branch :)
22:06 sapier        ok better?
22:06 troller       ShadowNinja, age called game_time
22:06 PilzAdam      VanessaE, then fetch and cherry-pick 7d86ca7367249e0c2ee78c5f7bb53a0430ceb3b6
22:06 VanessaE      thanks
22:07 ShadowNinja   troller: Ah, thanks.
22:07 PilzAdam      VanessaE, or wait, you have access to my repo, why dont _you_ merge zeg9's stuff then?
22:08 VanessaE      sure, I'll take care of it.
22:10 troller       9h 50m , 229d 18h 28m
22:10 troller       muuch better than 9.9h 7.7M
22:10 troller       microseconds need too!
22:16 ShadowNinja   troller: I agree, but game time isn't acurate to microseconds, and neither is uptime.
22:17 troller       need to patch up to nanoseconds
22:18 ShadowNinja   How about 10h, 229d18h38m -- I can remove minutes and make hours fractional.
22:19 troller       second value have no info
22:19 troller       18h^
22:19 ShadowNinja   What do you mean?
22:19 troller       229d is enough
22:21 EvergreenTree If I put VanessaE's code in lib_6d.lua into mibetest_game/mods/default/functions.lua would it break modstore?
22:21 EvergreenTree *minetest_game
22:24 ShadowNinja   Now it shows 1y2d3.4h
22:25 troller       fot what?
22:25 troller       for
22:25 ShadowNinja   Time.
22:25 troller       for who?
22:25 ShadowNinja   Uptime and age on the serverlist, that was only an example.
22:25 EvergreenTree I repeat, does VanessaE's 6d_lib only break modstore if it it is built in to minetest?
22:26 VanessaE      why would it break it at all?
22:26 troller       ShadowNinja, 1y is enough, remove 2d3.4h
22:26 ShadowNinja   troller: So that all servers show 0y for uptime and age?
22:27 troller       just leave my function about time
22:27 EvergreenTree sapier told me that it would break modstore if it were included in builtin/
22:27 ShadowNinja   EvergreenTree: He is incorrect.
22:27 VanessaE      why?  it's not used by anything yet.
22:27 sapier        what would break modstore?
22:27 VanessaE      and besides which, it's slated to go into builtin/misc_helpers.lua
22:27 troller       ShadowNinja, you maust show only first not-0 value
22:27 EvergreenTree You told me 959 would break modstore
22:28 troller       if 1y - 1y,  if 15m - 15m
22:28 EvergreenTree if it was merged
22:28 sapier        EvergreenTree I was talking to BlockMen ;-)
22:28 ShadowNinja   troller: B-b-but it's so ugly. I will write my own similar function.
22:28 EvergreenTree *facepalm*
22:28 sapier        sorry if you got this wrong I should've made that more clear
22:28 troller       ShadowNinja, its works ok.
22:28 EvergreenTree okay then, what was the problem with it then?
22:29 troller       ShadowNinja, you can make parseFloat(s).toFixed(0) in my
22:29 BlockMen      sapier, i have no idea yet
22:30 troller       ShadowNinja, my shows years and months
22:31 sapier        argh find_package curl fails on mingw build ...
22:31 EvergreenTree What was the problem with #959 again?
22:40 ShadowNinja   troller: Now it shows the largest unit it will fit into to one decimal place.
22:41 ShadowNinja   troller: M == Month?
22:41 troller       yes
22:41 troller       m=minute
22:41 troller       much better now
22:42 ShadowNinja   troller: What is a month? 29 days? 30 days? 31 days? Something else?
22:42 troller         30
22:42 troller       also, hide .0 when minute or hour
22:43 ShadowNinja   A month isn't a static unit, so IMO it shouldn't be used here.
22:43 troller       its only for average information
22:43 ShadowNinja   Hmmm, how can I have .0 not be included? I um using .toFixed(1).
22:44 troller       regexp after ;)
22:44 ShadowNinja   That's ugly...
22:44 troller       but beter to remove all .x
22:44 troller       they have too little info too
22:45 ShadowNinja   Well this is good enough to push now IMO.
22:48 ShadowNinja   thexyz: Update servers.minetest.net.
22:52 troller       nono
22:52 troller       its still badder
22:53 ShadowNinja   s/badder/worse/ And I disagree.
22:53 troller       and you broke http://minetest.net/servers
22:53 troller       you lost limit and min client filter
22:54 ShadowNinja   troller: Meh, I can update that easily.
22:54 ShadowNinja   troller: No, the limit is there.
22:54 troller       dont update
22:54 ShadowNinja   IDK what "min client" is.
22:55 troller       if (master.clients_min && s.clients < master.clients_min) continue;
22:55 troller       pushing without agreement not good
22:55 ShadowNinja   Ah, so only show servers with at least X clients?
22:56 troller       yes
22:56 ShadowNinja   I got agreement from the|xyz.
22:56 troller       -    if (master.clients_min || master.limit)
22:56 troller       124 	   	-        h += '<a href="#" onclick="delete master.limit;delete master.clients_min; get(1);">more...</a>';
22:57 troller       filtered list was with "more..."
22:58 ShadowNinja   I can literally just copy-paste that into the template with s/s/server/ inside {{ }}.
22:59 troller       do it
23:03 BlockMen      sapier, maybe its caused by https and cUrl under windows?
23:04 sapier        maybe I just found out why curl wasn't compiled for me ... cmake doesn't show up CURL_DLL setting in gui therfore it's not set and missing ... no error message is shown in this case
23:04 ShadowNinja   troller: http://git.io/2oeCvQ
23:05 troller       ok, but it not last fix ;)
23:06 BlockMen      yes, i remember, now you mention it^^
23:07 troller       ShadowNinja, more... link!
23:08 ShadowNinja   troller: What "More..." link?
23:08 troller       if (master.clients_min || master.limit)  h += '<a href="#" onclick="delete master.limit;delete master.clients_min; get(1);">more...</a>';
23:09 ShadowNinja   Ah, ok.
23:12 troller       and what about "popularity" value?
23:12 troller       http://minetest.setun.net/master/ press on players/max
23:13 troller       its average players number
23:13 ShadowNinja   Clicking on a nearby column is a bad way to implement it.
23:14 ShadowNinja   That can be added to the players column.
23:14 troller       too many values in players
23:14 troller       popup!
23:14 VanessaE      ShadowNinja: that last commit, shouldn't it be <=  ?
23:15 VanessaE      else master.min_clients has to be set to -1 to allow a zero-client server to show up?
23:15 troller       ShadowNinja, also, can you make "privs" from here https://github.com/minetest/minetest/pull/979/files
23:15 VanessaE      eh, wrong channel.
23:16 ShadowNinja   VanessaE: Or 0, or just don't set it.
23:16 ShadowNinja   troller: You can add that, you will have to rebase your pull.
23:16 VanessaE      hrm, ok
23:17 troller       its not rebase, its rewrite ;)
23:17 troller       but auto load of template needed, and maybe jquery too
23:18 troller       i will try
23:18 ShadowNinja   troller: Only the serverlist part. The client and server parts stay the same.
23:20 troller       ShadowNinja, why you move <script src="list.js"></script>
23:20 troller       to head?
23:21 ShadowNinja   troller: Because that is where <script> elements belong.
23:22 troller       no, it can broke page
23:22 troller       script can be runned before body exists (on some browsers)
23:23 ShadowNinja   Hmmm, then move get(); to onload.
23:23 troller       .html must be easy, only  <script src="list.js">
23:24 ShadowNinja   Well you can change that, I have some things to do now.
23:24 troller       and how to compile jst
23:25 troller       and .tooltip must be more unique
23:26 ShadowNinja   troller: README.md
23:27 troller       maybe commit it?
23:27 troller       compiled template
23:33 ShadowNinja   troller: No, that's like commiting a compiled minetest binary. It is duplication and has to be updated on every commit.
23:33 troller       Error: Cannot find module 'commander'
23:34 troller       after npm install dot
23:35 VanessaE      ShadowNinja: regarding #959, since calinou stonewalled me, I guess you'll merge it with the forcewall flag available?
23:36 VanessaE      s/you'll/you or someone will/
23:37 ShadowNinja   troller: "npm install" in the doT folder.
23:37 troller       no need to checkout it, npm install dot commander mkdirp
23:37 ShadowNinja   I'd rather not merge it that way.
23:46 sapier        I've found the modstore problem in windows I'm gonna create a pull request tomorrow
23:52 ShadowNinja   Can someone else agree with #751? I have rebased it and tested it and it works well.
23:56 VanessaE      +1 for that one.  I've used it before and found it preferable to the 't' dialog box, but it has one caveat:  you can't copy&paste with the F10/that console on linux