Time  Nick        Message
15:39 Sokomine    what about my pull request https://github.com/minetest/minetest/pull/951 ? hope it's ok now. if it gets merged, we can have very nice animated windmills. that's something i've been looking for for quite long
15:40 VanessaE    to that ^^^^ end, I'm sure this has other possible uses as well.
15:40 PilzAdam    I agree to the idea but havent tested the code
15:40 Sokomine    large cinema screens would also be possible. or other intresting things :-)
15:40 VanessaE    Sokomine: for example, RBA's stargate would benefit
15:41 VanessaE    yes, that too
15:41 Sokomine    oh yes
15:41 VanessaE    huge signs with server rules, billboards, etc become trivial
15:44 Sokomine    that would be great as well!
15:48 celeron55_  Sokomine: it's wrong now
15:48 celeron55_  you need to use float, not short
15:49 celeron55_  also why is the variable name "k"
15:50 celeron55_  i, j and k are generally used for indexing stuff
15:50 celeron55_  it should be s or l or something like that that even remotely represents size or length 8)
15:50 celeron55_  also, why is there stuff at three positions now?:q
15:51 celeron55_  -:q
15:51 celeron55_  oh ah, one is modifying the original plantlike
15:53 celeron55_  if you change those two and don't do anything else, then it's again fine for me
15:56 Sokomine    i was looking for a suitable unused var name. s would be ok as well. l is always a bit problematic due to possible confusion with 1. yes, i did introduce the var at all three positions (no point in keeping it diffrent) and added it for torchlike as well
15:58 celeron55_  >people coding using fonts that make 1 and l unobvious
16:00 celeron55_  oh also, look at what you did near line 1003
16:01 celeron55_  some of the stuff is replaced but not all, even on similar lines similar stuff is replaced differently
16:01 Sokomine    you're right! i missed that part on line 1003
16:04 Sokomine    oh...hm, no, it's not the same
16:10 ShadowNinja Sokomine: 1005 can become -s.
16:11 Sokomine    similar stuff is replaced differently? ok, some further occourances can be replaced by s*2. in general, -s instead of -1*s ought to work as well. which one is prefered? -s?
16:14 ShadowNinja -s is simpler.
16:15 Sokomine    ok
16:18 ShadowNinja Although single-charachter veriable names generaly aren't good. Consider changing to to size or similar.
16:21 proller     celeron55_, waiting 2 months for approving big pulls..
16:21 Sokomine    i'm aware of the problem of single-character names and wouldn't use them for vars that have a meaning in larger parts of the code. in this case, usage is limited to a very tiny piece of code which follows immediately
16:22 proller     but leveldb was 9+ months
16:22 Sokomine    oh? isn't it integrated? sfans5 helpful patch that makes the client save the world uses leveldb
16:23 ShadowNinja I think it took over a year for LevelDB to be merged.
16:31 thexyz      yeah it's been so long no one remembers who created it
16:32 celeron55_  you have your name on the initial commit of it though 8)
16:32 thexyz      https://forum.minetest.net/viewtopic.php?id=3005
16:36 celeron55_  i haven't even seen that topic; interesting
16:37 celeron55_  maybe someone should answer to it what has happened to it recently
16:37 thexyz      maybe
16:37 celeron55_  so that anyone looking for information there gets it
16:39 celeron55_  preferably someone who was involved in getting it finally merged, i've been quite absent
16:39 thexyz      > Commit messages must start with a capital letter, be in the present tense, and can not end with a period (look at the commit log) http://dev.minetest.net/index.php?title=Git_Guidelines&curid=389&diff=1559&oldid=1454&rcid=1683
16:39 thexyz      why's that?
16:39 thexyz      > can not end with a period
16:39 celeron55_  uhm
16:40 ShadowNinja That's the way that they all are.
16:40 thexyz      that doesn't mean we should force it
16:40 thexyz      it's pointless
16:40 ShadowNinja s/can/should/
16:40 ShadowNinja ?
16:41 celeron55_  well what it means is "formatted like headers where only first letter is specially capitalized"
16:41 celeron55_  or, that's how they're done
16:47 celeron55_  (and of course any commit message formatting rules apply only to the first line which is the header of the commit; extra info can be anything)
17:13 thexyz      suggestion: every lua api-related pull request should contain corresponding dev wiki article modification (user page); after pull request is merged docs modifications are merged into main article as well
17:45 Sokomine    finally managed to convice git to accept the changes (thanks to shadowninjas help). the pull request now ought to be up to date. shadowninja also told me that one should not open pull requests against master; hope this is not a problem now? or shall i start anew?
17:55 Sokomine    the correct commit message seems to be gone...
18:21 jojoa1997   VanessaE, you there
18:21 jojoa1997   sorry wrong channel
19:32 Sokomine    i'd be glad if you could take a new look on my pull request and tell me if there's something else wrong or if it's ok now
19:33 Sokomine    also...i just idled in one mt world. when i came back i was dead. most likely killed by another player. it would be great to be able to know the cause of heart-loss and to print a message in the log and on the server
19:34 ShadowNinja Sokomine: Fix the commit message.
19:40 Sokomine    ok. ought to be done now
19:41 proller     cool master server update https://github.com/proller/minetest/compare/masterserver
19:43 proller     https://github.com/minetest/minetest/pull/952
19:49 sfan5       proller: can you please learn to make js code that is not vulnerable to stored xss
19:49 ShadowNinja proller: Is game_time affected by time_speed?
19:50 proller     sfan5, stored where?
19:50 sfan5       proller: <wherever master.cgi stores it>
19:51 sfan5       even the current serverlist is vulnerable
19:51 proller     ShadowNinja, looks no
19:52 proller     sfan5, show
19:53 sfan5       { ... 'mods': ["<script>alert('meow');</script>" ] ... }
19:53 sfan5       your pull would open up { ... 'players': ["<script>alert('meow');</script>" ] ... }
19:57 thexyz      also, you should totally use some templating thing for javascript
19:57 sfan5       also { .. 'clients': "<script>alert('meow');</script>" ... }
19:58 proller     fixrd
19:58 proller     fixed
19:58 proller     thexyz, need rewrite js
19:58 thexyz      http://twigkit.github.io/tempo/ or http://beebole.com/pure/ or something else like this
19:59 thexyz      better now than later
19:59 sfan5       proller: <sfan5> also { .. 'clients': "<script>alert('meow');</script>" ... }
19:59 sfan5       fix that one too
19:59 thexyz      this code already doesn't look very nice
19:59 proller     sfan5, already
20:00 proller     ups no
20:02 proller     thexyz, less ugliest is http://olado.github.io/doT/index.html
20:03 thexyz      anything is fine I guess
20:04 proller     sfan5, fixed
20:04 proller     thexyz, need 1-3 hours for it..
20:12 proller     but not in this pull
21:13 kahrl       proller: in #952, the client names vector should be passed by const reference, not value
21:13 kahrl       also remove the m_ from the name
21:14 proller     ok
21:14 proller     how to correct cast to const?
21:14 kahrl       hm?
21:15 proller     std::vector<const & std::string> ?
21:15 kahrl       const std::vector<std::string> &
21:15 proller     ups ok
22:00 proller     kahrl, fixed